From: Petr Vorel <pvorel@suse.cz>
To: Richard Palethorpe <rpalethorpe@suse.de>,
Oliver Hartkopp <socketcan@hartkopp.net>,
Marc Kleine-Budde <mkl@pengutronix.de>,
ltp@lists.linux.it, linux-can@vger.kernel.org
Subject: Re: [LTP] [PATCH v3 2/7] can: Add can_common.h for vcan device setup
Date: Wed, 27 Jan 2021 16:07:27 +0100 [thread overview]
Message-ID: <YBGBr3mBUuX21mtE@pevik> (raw)
In-Reply-To: <YBFY7w1vseKSA4Df@pevik>
Hi Richie,
...
> > I wonder Petr, is it still necessary to define IFF_ECHO now only
> > <linux/if.h> is included? Or do they somehow symlink linux/if.h ->
> > net/if.h?
> No.
> > Indeed it seems the current version of uclibc-ng doesn't include
> > IFF_ECHO in <net/if.h>. OTOH musl does define it.
> Yes => please keep that definition in can_common.h (enough here, we don't have
> to bother with if.h when we don't have it yet).
> And I'll send tonight patch to uclibc-ng.
> The more mature musl is the less relevant uclibc-ng is.
Just for a record, I was wrong. Using <linux/if.h> is enough, no need to
keep definition on can_common.h. Sorry for wasting your time.
I mixed two problems: <linux/if.h> and <net/if.h> conflict (there are more headers
which conflict) [1] and sometimes missing definition on uclibc-ng.
*But* musl defines IFF_ECHO in <net/if.h> as they try to allow people not having
to depend on <linux/*.h>, which is IMHO better than blindly relying on
<linux/*.h> which glibc and uclibc{,-ng} (which follows glibc) does much more
than musl:
$ git grep '^#include <linux/.*\.h>' |wc -l
43 # glibc
37 # uclibc-ng
3 # musl
Kind regards,
Petr
[1] https://sourceware.org/glibc/wiki/Synchronizing_Headers#Known_Pairs_of_Headers_that_Conflict
next prev parent reply other threads:[~2021-01-27 15:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 14:37 [PATCH v3 0/7] Convert CAN tests to new LTP API Richard Palethorpe
2021-01-20 14:37 ` [PATCH v3 1/7] API: Add FILE_SCANF to new lib Richard Palethorpe
2021-01-20 14:37 ` [PATCH v3 2/7] can: Add can_common.h for vcan device setup Richard Palethorpe
2021-01-25 10:20 ` Oliver Hartkopp
2021-01-25 10:59 ` Richard Palethorpe
2021-01-26 21:28 ` Petr Vorel
2021-01-27 7:52 ` Oliver Hartkopp
2021-01-27 8:18 ` Richard Palethorpe
2021-01-27 12:13 ` Petr Vorel
2021-01-27 15:07 ` Petr Vorel [this message]
2021-01-20 14:37 ` [PATCH v3 3/7] can: Add COPYING with dual license text Richard Palethorpe
2021-01-20 14:37 ` [PATCH v3 4/7] can_filter: Convert to new library Richard Palethorpe
2021-01-20 14:37 ` [PATCH v3 5/7] can_recv_own_msgs: " Richard Palethorpe
2021-01-25 14:29 ` [LTP] " Cyril Hrubis
2021-01-20 14:37 ` [PATCH v3 6/7] can: Remove obsolete test wrapper script Richard Palethorpe
2021-01-25 9:10 ` [LTP] " Petr Vorel
2021-01-20 14:37 ` [PATCH v3 7/7] can: Update contact details Richard Palethorpe
2021-01-25 10:25 ` Oliver Hartkopp
2021-01-25 14:30 ` [LTP] " Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBGBr3mBUuX21mtE@pevik \
--to=pvorel@suse.cz \
--cc=linux-can@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=mkl@pengutronix.de \
--cc=rpalethorpe@suse.de \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).