From: Nathan Chancellor <natechancellor@gmail.com>
To: trix@redhat.com
Cc: sfrench@samba.org, ndesaulniers@google.com, aaptel@suse.com,
palcantara@suse.de, linux-cifs@vger.kernel.org,
samba-technical@lists.samba.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com
Subject: Re: [PATCH] cifs: check pointer before freeing
Date: Tue, 5 Jan 2021 15:25:59 -0700 [thread overview]
Message-ID: <20210105222559.GA4118247@ubuntu-m3-large-x86> (raw)
In-Reply-To: <20210105202126.2879650-1-trix@redhat.com>
On Tue, Jan 05, 2021 at 12:21:26PM -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> clang static analysis reports this problem
>
> dfs_cache.c:591:2: warning: Argument to kfree() is a constant address
> (18446744073709551614), which is not memory allocated by malloc()
> kfree(vi);
> ^~~~~~~~~
>
> In dfs_cache_del_vol() the volume info pointer 'vi' being freed
> is the return of a call to find_vol(). The large constant address
> is find_vol() returning an error.
>
> Add an error check to dfs_cache_del_vol() similar to the one done
> in dfs_cache_update_vol().
>
> Fixes: 54be1f6c1c37 ("cifs: Add DFS cache routines")
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> fs/cifs/dfs_cache.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/cifs/dfs_cache.c b/fs/cifs/dfs_cache.c
> index 6ad6ba5f6ebe..0fdb0de7ff86 100644
> --- a/fs/cifs/dfs_cache.c
> +++ b/fs/cifs/dfs_cache.c
> @@ -1260,7 +1260,8 @@ void dfs_cache_del_vol(const char *fullpath)
> vi = find_vol(fullpath);
> spin_unlock(&vol_list_lock);
>
> - kref_put(&vi->refcnt, vol_release);
> + if (!IS_ERR(vi))
> + kref_put(&vi->refcnt, vol_release);
> }
>
> /**
> --
> 2.27.0
>
next prev parent reply other threads:[~2021-01-05 22:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 20:21 [PATCH] cifs: check pointer before freeing trix
2021-01-05 22:25 ` Nathan Chancellor [this message]
2021-01-06 4:11 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210105222559.GA4118247@ubuntu-m3-large-x86 \
--to=natechancellor@gmail.com \
--cc=aaptel@suse.com \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=palcantara@suse.de \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).