linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Metzmacher <metze@samba.org>
To: Steve French <smfrench@gmail.com>
Cc: Steve French <stfrench@microsoft.com>,
	"linux-cifs@vger.kernel.org" <linux-cifs@vger.kernel.org>,
	Samba Technical <samba-technical@lists.samba.org>
Subject: Re: [MS-SMB2] 2.2.3.1.4 SMB2_NETNAME_NEGOTIATE_CONTEXT_ID
Date: Tue, 6 Aug 2019 07:17:01 +0200	[thread overview]
Message-ID: <442364df-1c26-4161-6a02-98417e8d6aa6@samba.org> (raw)
In-Reply-To: <CAH2r5mvJzTmg+mPDeDcS7RJzdtYV4Coq76fKkVBu3oysU6ihkA@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1162 bytes --]

Am 06.08.19 um 00:11 schrieb Steve French:
> How about this fix?

Looks good, if you have tested it :-)

metze

> On Fri, Jul 26, 2019 at 3:29 AM Stefan Metzmacher via samba-technical
> <samba-technical@lists.samba.org> wrote:
>>
>> Hi Steve,
>>
>> I just contacted dochelp for this and noticed (from reading the code)
>> that the kernel sends null-termination for the
>> SMB2_NETNAME_NEGOTIATE_CONTEXT_ID value.
>>
>> I think you should fix that and backport it to stable releases,
>> it would be good if all clients would implement it like windows.
>>
>> I implemented it for Samba here:
>> https://gitlab.com/samba-team/samba/merge_requests/666
>>
>> metze
>>
>> Am 26.07.19 um 10:22 schrieb Stefan Metzmacher via cifs-protocol:
>>> Hi DocHelp,
>>>
>>> I just noticed a documentation bug in
>>> [MS-SMB2] 2.2.3.1.4 SMB2_NETNAME_NEGOTIATE_CONTEXT_ID:
>>>
>>>    NetName (variable): A null-terminated Unicode string containing the
>>>    server name and specified by the client application.
>>>
>>> Windows Server 1903 sends the name without null-termination, see the
>>> attached capture.
>>>
>>> metze
>>
>>
> 
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2019-08-06  5:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <e51f32ff-ce54-d015-4ba0-572ec35f3e45@samba.org>
2019-07-26  8:27 ` [MS-SMB2] 2.2.3.1.4 SMB2_NETNAME_NEGOTIATE_CONTEXT_ID Stefan Metzmacher
2019-08-05 22:11   ` Steve French
2019-08-06  5:17     ` Stefan Metzmacher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=442364df-1c26-4161-6a02-98417e8d6aa6@samba.org \
    --to=metze@samba.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=samba-technical@lists.samba.org \
    --cc=smfrench@gmail.com \
    --cc=stfrench@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).