linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Metzmacher <metze@samba.org>
To: Tom Talpey <ttalpey@microsoft.com>,
	Jeremy Allison <jra@samba.org>, Steve French <smfrench@gmail.com>
Cc: CIFS <linux-cifs@vger.kernel.org>,
	samba-technical <samba-technical@lists.samba.org>
Subject: Re: [PATCH][SMB3] Add missing defines for new negotiate contexts
Date: Thu, 23 May 2019 15:51:13 +0200	[thread overview]
Message-ID: <4591362b-cb4e-7e22-00a6-bf7239584957@samba.org> (raw)
In-Reply-To: <CY4PR21MB0149DC81B079BCD36D580AC5A0350@CY4PR21MB0149.namprd21.prod.outlook.com>


[-- Attachment #1.1: Type: text/plain, Size: 847 bytes --]

Hi Tom,

>> The Windows protocol documents were updated on March 13 for the
>> upcoming "19H1" update cycle.
>>
>> MS-SMB2 version page, with latest, diffs, etc:
>>
>> https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-smb2/5606ad47-5ee0-437a-817e-70c366052962
> 
> So, there was a defect in the published spec which we just corrected, there's a new
> update online at the above page.
> 
> The value of the new compression contextid is actually "3", but the earlier document
> incorrectly said "4". There were several other fixes and clarifications in the pipeline
> which have also been included.
> 
> Redline diffs as well as the usual standard publication formats are available.

There's no server behavior defined for
SMB2_NETNAME_NEGOTIATE_CONTEXT_ID. If there's none, why was it added at all?

metze




[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2019-05-23 13:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-18 16:06 [PATCH][SMB3] Add missing defines for new negotiate contexts Steve French
2019-04-18 17:23 ` Jeremy Allison
2019-04-18 17:33   ` Steve French
2019-04-22 15:50   ` Tom Talpey
2019-05-03 15:57     ` Tom Talpey
2019-05-23 13:51       ` Stefan Metzmacher [this message]
2019-05-23 18:24         ` Tom Talpey
2019-05-23 23:06           ` Jeremy Allison
2019-05-24 10:27           ` Stefan Metzmacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4591362b-cb4e-7e22-00a6-bf7239584957@samba.org \
    --to=metze@samba.org \
    --cc=jra@samba.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=samba-technical@lists.samba.org \
    --cc=smfrench@gmail.com \
    --cc=ttalpey@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).