From: Paulo Alcantara <pc@cjr.nz>
To: Shyam Prasad N <nspmangalore@gmail.com>
Cc: "Steve French" <smfrench@gmail.com>,
"Aurélien Aptel" <aaptel@suse.com>,
CIFS <linux-cifs@vger.kernel.org>,
sribhat.msa@outlook.com, "rohiths msft" <rohiths.msft@gmail.com>
Subject: Re: Multichannel patches
Date: Fri, 04 Jun 2021 12:25:33 -0300 [thread overview]
Message-ID: <87y2bpk5xu.fsf@cjr.nz> (raw)
In-Reply-To: <CANT5p=o6Oq-27Xj4Z6-XzXKL45Dwg7JjGw2HA9jv5+YFQKpHUg@mail.gmail.com>
Shyam Prasad N <nspmangalore@gmail.com> writes:
> @Paulo Alcantara That would be great if you can help testing my
> changes. Please test with these new changes.
OK.
>> The super is only used for providing cifs_sb_info::origin_fullpath as key to find the corresponding failover targets in referral cache.
> I'm wondering what would happen if there are multiple tcons to the
> same origin_fullpath (possibly in different sessions)?
That is certainly a problem, indeed. I'm waiting for the DFS tests to
finish and then send a series that contains a potential fix for that --
e.g. not sharing TCP servers when mounting DFS shares. We used to not
share tcons with DFS mounts because they might contain different prefix
paths but connected to same share, however that wasn't enough because
multiple DFS mounts may connect to same target servers, although they
might failover to completely different servers.
> Also, doesn't failover targets apply to each channel under a session?
> Shouldn't we switch targets on reconnect of secondary channels too?
That's a interesting question. I recall discussing this with Aurelien
some time ago while running a few DFS + multichannel tests.
So yes, I agree with you that when we successfully reconnect to failover
target (primary channel), then we should also update all secondary
channels with the new server's ip address and reconnect them.
next prev parent reply other threads:[~2021-06-04 15:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 12:43 Multichannel patches Shyam Prasad N
2021-06-02 15:57 ` Aurélien Aptel
2021-06-02 18:55 ` Steve French
2021-06-02 16:45 ` Paulo Alcantara
2021-06-04 9:13 ` Shyam Prasad N
2021-06-04 15:10 ` Steve French
2021-06-04 15:25 ` Paulo Alcantara [this message]
2021-06-05 14:08 ` Shyam Prasad N
2021-06-05 17:43 ` Steve French
2021-06-05 17:57 ` Steve French
2021-06-08 9:54 ` Shyam Prasad N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2bpk5xu.fsf@cjr.nz \
--to=pc@cjr.nz \
--cc=aaptel@suse.com \
--cc=linux-cifs@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=rohiths.msft@gmail.com \
--cc=smfrench@gmail.com \
--cc=sribhat.msa@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).