Re: nsdeps not working on modules in 5.4-rc1

From: Steve French <smfrench@gmail.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Matthias Maennich <maennich@google.com>,
	LKML <linux-kernel@vger.kernel.org>,
	CIFS <linux-cifs@vger.kernel.org>, Jessica Yu <jeyu@kernel.org>
Subject: Re: nsdeps not working on modules in 5.4-rc1
Date: Thu, 3 Oct 2019 11:06:42 -0500	[thread overview]
Message-ID: <CAH2r5ms_GdhAG4q3kcadeU44EQPjnebzBG8=DUcsi9Gh5J8UXw@mail.gmail.com> (raw)
In-Reply-To: <CAK7LNARrdQad9=U1LknT9yRYtRagNVS8T5r_Ovv5Sa91QO3TsA@mail.gmail.com>

On Thu, Oct 3, 2019 at 10:24 AM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> Hi Steve,
>
> On Fri, Oct 4, 2019 at 12:15 AM Steve French <smfrench@gmail.com> wrote:
> >
> > On Thu, Oct 3, 2019 at 5:43 AM Matthias Maennich <maennich@google.com> wrote:
> > >
> > > Hi Steve!
> > >
> > > On Wed, Oct 02, 2019 at 06:54:26PM -0500, Steve French wrote:
> > > >And running the build differently, from the root of the git tree
> > > >(5.4-rc1) rather than using the Ubuntu 5.4-rc1 headers also fails
> > > >
> > > >e.g. "make  M=fs/cifs modules nsdeps"
> > > >
> > > >...
> > > >  LD [M]  fs/cifs/cifs.o
> > > >  Building modules, stage 2.
> > > >  MODPOST 1 modules
> > > >WARNING: module cifs uses symbol sigprocmask from namespace
> > > >_fs/cifs/cache.o), but does not import it.
> > > >...
> > > >WARNING: module cifs uses symbol posix_test_lock from namespace
> > > >cifs/cache.o), but does not import it.
> > > >  CC [M]  fs/cifs/cifs.mod.o
> > > >  LD [M]  fs/cifs/cifs.ko
> > > >  Building modules, stage 2.
> > > >  MODPOST 1 modules
> > > >./scripts/nsdeps: 34: local: ./fs/cifs/cifsfs.c: bad variable name
> > > >make: *** [Makefile:1710: nsdeps] Error 2
> > >
> > > Thanks for reporting this. It appears to me you hit a bug that was
> > > recently discovered: when building with `make M=some/subdirectory`,
> > > modpost is misbehaving. Can you try whether this patch series solves
> > > your problems:
> > > https://lore.kernel.org/lkml/20191003075826.7478-1-yamada.masahiro@socionext.com/
> > > In particular patch 2/6 out of the series.
> > >
> > > Cheers,
> > > Matthias
> >
> >
> > Applying just patch 2 and doing "make" from the root of the git tree
> > (5.4-rc1), at the tail end of the build I got
> >
> > ...
> > Kernel: arch/x86/boot/bzImage is ready  (#87)
> >   Building modules, stage 2.
> >   MODPOST 5340 modules
> > free(): invalid pointer
> > Aborted (core dumped)
>
>
> Right.
>
> Since 2/6 depends on 1/6,
> applying only the second one does not work.

Applying both 1 and 2 I get the following error doing make (although
it makes it a long way into the build)

<snip>
WARNING: drivers/usb/storage/usb-storage: 'USB_STORAGE' exported
twice. Previous export was in drivers/usb/storage/usb-storage.ko
ERROR: "usb_stor_set_xfer_buf" [drivers/usb/storage/ums-usbat.ko] undefined!
ERROR: "usb_stor_access_xfer_buf" [drivers/usb/storage/ums-usbat.ko] undefined!
ERROR: "usb_stor_post_reset" [drivers/usb/storage/ums-usbat.ko] undefined!
ERROR: "usb_stor_disconnect" [drivers/usb/storage/ums-usbat.ko] undefined!
<snip>
ERROR: "usb_stor_adjust_quirks" [drivers/usb/storage/uas.ko] undefined!
ERROR: "usb_stor_sense_invalidCDB" [drivers/usb/storage/uas.ko] undefined!
WARNING: "USB_STORAGE" [drivers/usb/storage/usb-storage] is a static
EXPORT_SYMBOL_GPL
make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
make: *** [Makefile:1303: modules] Error 2

Running "make M=fs/cifs nsdeps" I still get the error

  Building modules, stage 2.
  MODPOST 1 modules
./scripts/nsdeps: 34: local: ./fs/cifs/cifsfs.c: bad variable name
make: *** [Makefile:1710: nsdeps] Error 2

-- 
Thanks,

Steve