linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve French <smfrench@gmail.com>
To: Rohith Surabattula <rohiths.msft@gmail.com>
Cc: Shyam Prasad N <nspmangalore@gmail.com>,
	linux-cifs <linux-cifs@vger.kernel.org>,
	ronnie sahlberg <ronniesahlberg@gmail.com>
Subject: Re: [PATCH][CIFS]Call close synchronously during unlink/rename/lease break.
Date: Tue, 10 Aug 2021 14:28:36 -0500	[thread overview]
Message-ID: <CAH2r5mtQCC8upykXm5zZVO94-TRbxq2HMN5S65ROASwaRqOfuA@mail.gmail.com> (raw)
In-Reply-To: <CACdtm0aGGqtSsv1t2=VTGZZTBD52JvOsWD_oqXuUnejeDCVJFw@mail.gmail.com>

I saw some test failures in

and looking in /var/log/messages I see e.g.

Aug 10 14:00:22 fedora29 systemd[1]: Started /usr/bin/bash -c exit 77.
Aug 10 14:00:25 fedora29 kernel: kmemleak: 10 new suspected memory
leaks (see /sys/kernel/debug/kmemleak)
Aug 10 14:00:28 fedora29 kernel: kmemleak: 1 new suspected memory
leaks (see /sys/kernel/debug/kmemleak)
Aug 10 14:00:28 fedora29 kernel: CIFS: Attempting to mount
\\win16.vm.test\Scratch
Aug 10 14:00:28 fedora29 kernel: CIFS: Attempting to mount
\\win16.vm.test\Scratch
Aug 10 14:00:29 fedora29 root[6460]: run xfstest cifs/100
Aug 10 14:00:29 fedora29 journal: run fstests cifs/100 at 2021-08-10 14:00:29
Aug 10 14:00:29 fedora29 systemd[1]: Started /usr/bin/bash -c test -w
/proc/self/oom_score_adj && echo 250 > /proc/self/oom_score_adj; exec
./tests/cifs/100.
Aug 10 14:00:30 fedora29 kernel: general protection fault, probably
for non-canonical address 0xdead000000000110: 0000 [#4] SMP PTI
Aug 10 14:00:30 fedora29 kernel: CPU: 0 PID: 6624 Comm: rm Tainted: G
    D           5.14.0-rc4 #1
Aug 10 14:00:30 fedora29 kernel: Hardware name: Red Hat KVM, BIOS
0.5.1 01/01/2011
Aug 10 14:00:30 fedora29 kernel: RIP:
0010:cifs_close_deferred_file+0x77/0x140 [cifs]
Aug 10 14:00:30 fedora29 kernel: Code: 85 de 00 00 00 4c 89 ef e8 06
96 2e e8 48 8b 1c 24 4c 39 e3 74 55 49 bd 00 01 00 00 00 00 ad de 48
bd 22 01 00 00 00 00 ad de <48> 8b 7b 10 31 d2 be 01 00 00 00 e8 a9 c5
fe ff 48 89 df e8 61 46
Aug 10 14:00:30 fedora29 kernel: RSP: 0018:ffffb121806dbdd0 EFLAGS: 00010287
Aug 10 14:00:30 fedora29 kernel: RAX: ffff88dc55b8ca01 RBX:
dead000000000100 RCX: 00000000000034d9
Aug 10 14:00:30 fedora29 kernel: RDX: 00000000000034d8 RSI:
67739b6f43694caa RDI: 0000000000032080

and

Aug 10 14:00:30 fedora29 kernel: ---[ end trace b062b12a095f4dd5 ]---
Aug 10 14:00:30 fedora29 kernel: RIP:
0010:cifs_close_deferred_file+0x77/0x140 [cifs]
Aug 10 14:00:30 fedora29 kernel: Code: 85 de 00 00 00 4c 89 ef e8 06
96 2e e8 48 8b 1c 24 4c 39 e3 74 55 49 bd 00 01 00 00 00 00 ad de 48
bd 22 01 00 00 00 00 ad de <48> 8b 7b 10 31 d2 be 01 00 00 00 e8 a9 c5
fe ff 48 89 df e8 61 46
Aug 10 14:00:30 fedora29 kernel: RSP: 0018:ffffb12180f0fc80 EFLAGS: 00010283
Aug 10 14:00:30 fedora29 kernel: RAX: ffff88dc5b2ca201 RBX:
dead000000000100 RCX: 0000000000002367
Aug 10 14:00:30 fedora29 kernel: RDX: 0000000000002366 RSI:
67100f614dfd246a RDI: 0000000000032080
Aug 10 14:00:30 fedora29 kernel: RBP: dead000000000122 R08:
0000000000000001 R09: 0000000000000001
Aug 10 14:00:30 fedora29 kernel: R10: ffffb12180f0fba0 R11:
0000000000000001 R12: ffffb12180f0fc80

On Tue, Aug 10, 2021 at 12:29 PM Rohith Surabattula
<rohiths.msft@gmail.com> wrote:
>
> Hi All,
>
> Have updated the patch to fix the memleak.
>
> Regards,
> Rohith
>
> On Tue, Aug 10, 2021 at 5:18 PM Shyam Prasad N <nspmangalore@gmail.com> wrote:
> >
> > Already gave my review comments along with this one to the other email.
> >
> > Reviewed-by: Shyam Prasad N <sprasad@microsoft.com>
> >
> > On Mon, Aug 9, 2021 at 3:28 PM Rohith Surabattula
> > <rohiths.msft@gmail.com> wrote:
> > >
> > > Hi Steve/All,
> > >
> > > During unlink/rename/lease break, deferred work for close is
> > > scheduled immediately but in asynchronous manner which might
> > > lead to race with actual(unlink/rename) commands.
> > >
> > > This change will schedule close synchronously which will avoid
> > > the race conditions with other commands.
> > >
> > > Regards,
> > > Rohith
> >
> >
> >
> > --
> > Regards,
> > Shyam



-- 
Thanks,

Steve

  reply	other threads:[~2021-08-10 19:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-09  9:58 [PATCH][CIFS]Call close synchronously during unlink/rename/lease break Rohith Surabattula
2021-08-10 11:47 ` Shyam Prasad N
2021-08-10 17:29   ` Rohith Surabattula
2021-08-10 19:28     ` Steve French [this message]
2021-08-10 19:31       ` Steve French
2021-08-10 19:48         ` Rohith Surabattula
2021-08-11  5:28           ` Steve French
2021-08-11  5:35             ` Rohith Surabattula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAH2r5mtQCC8upykXm5zZVO94-TRbxq2HMN5S65ROASwaRqOfuA@mail.gmail.com \
    --to=smfrench@gmail.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=nspmangalore@gmail.com \
    --cc=rohiths.msft@gmail.com \
    --cc=ronniesahlberg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).