Fixed typo, and added the update of AllocationSize (and added reviewed by). See attached. On Tue, Dec 3, 2019 at 10:45 AM Aurélien Aptel wrote: > > Steve French writes: > > > diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c > > index cec53eb8a6da..8444b8425876 100644 > > --- a/fs/cifs/smb2pdu.c > > +++ b/fs/cifs/smb2pdu.c > ... > > @@ -2997,9 +3008,16 @@ SMB2_close(const unsigned int xid, struct cifs_tcon *tcon, > .. > > ses->Suid); > > + /* > > + * Note that have to subtract 4 since struct network_open_info > > + * has a final 4 byte pad that close respose does not have > > + */ > > respose => response typo > > Otherwise LGTM > > Reviewed-by: Aurelien Aptel > > -- > Aurélien Aptel / SUSE Labs Samba Team > GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 > SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE > GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München) -- Thanks, Steve