From: Pavel Shilovsky <piastryyy@gmail.com>
To: linux-cifs <linux-cifs@vger.kernel.org>
Cc: Steve French <smfrench@gmail.com>,
Pavel Shilovskiy <pshilov@microsoft.com>
Subject: Re: [PATCH 3/3] CIFS: Force reval dentry if LOOKUP_REVAL flag is set
Date: Thu, 10 Oct 2019 11:06:41 -0700 [thread overview]
Message-ID: <CAKywueSX_KQqyFaQQgJBt2AYivNP=Y+mBmJH+XVoCbQBCsoBCg@mail.gmail.com> (raw)
In-Reply-To: <20190930170620.29979-3-pshilov@microsoft.com>
The updated version of this has been merged into for-next:
https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commitdiff;h=0b3d0ef9840f7be202393ca9116b857f6f793715
--
Best regards,
Pavel Shilovsky
пн, 30 сент. 2019 г. в 10:06, Pavel Shilovsky <piastryyy@gmail.com>:
>
> Mark inode for force revalidation if LOOKUP_REVAL flag is set.
> This tells the client to actually send a QueryInfo request to
> the server to obtain the latest metadata in case a directory
> or a file were changed remotely.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
> ---
> fs/cifs/dir.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c
> index be424e81e3ad..91a46b01d748 100644
> --- a/fs/cifs/dir.c
> +++ b/fs/cifs/dir.c
> @@ -738,10 +738,16 @@ cifs_lookup(struct inode *parent_dir_inode, struct dentry *direntry,
> static int
> cifs_d_revalidate(struct dentry *direntry, unsigned int flags)
> {
> + struct inode *inode;
> +
> if (flags & LOOKUP_RCU)
> return -ECHILD;
>
> if (d_really_is_positive(direntry)) {
> + inode = d_inode(direntry);
> + if (flags & LOOKUP_REVAL)
> + CIFS_I(inode)->time = 0; /* force reval */
> +
> if (cifs_revalidate_dentry(direntry))
> return 0;
> else {
> @@ -752,7 +758,7 @@ cifs_d_revalidate(struct dentry *direntry, unsigned int flags)
> * attributes will have been updated by
> * cifs_revalidate_dentry().
> */
> - if (IS_AUTOMOUNT(d_inode(direntry)) &&
> + if (IS_AUTOMOUNT(inode) &&
> !(direntry->d_flags & DCACHE_NEED_AUTOMOUNT)) {
> spin_lock(&direntry->d_lock);
> direntry->d_flags |= DCACHE_NEED_AUTOMOUNT;
> --
> 2.17.1
>
prev parent reply other threads:[~2019-10-10 18:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 17:06 [PATCH 1/3] CIFS: Gracefully handle QueryInfo errors during open Pavel Shilovsky
2019-09-30 17:06 ` [PATCH 2/3] CIFS: Force revalidate inode when dentry is stale Pavel Shilovsky
2019-09-30 17:06 ` [PATCH 3/3] CIFS: Force reval dentry if LOOKUP_REVAL flag is set Pavel Shilovsky
2019-10-10 18:06 ` Pavel Shilovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKywueSX_KQqyFaQQgJBt2AYivNP=Y+mBmJH+XVoCbQBCsoBCg@mail.gmail.com' \
--to=piastryyy@gmail.com \
--cc=linux-cifs@vger.kernel.org \
--cc=pshilov@microsoft.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).