Re: [PATCH v2] cifs: fix that return -EINVAL when do dedupe operation

From: Pavel Shilovsky <piastryyy@gmail.com>
To: 冯小丽 <fengxiaoli0714@gmail.com>
Cc: XiaoLi Feng <xifeng@redhat.com>,
	CIFS <linux-cifs@vger.kernel.org>,
	Steve French <smfrench@gmail.com>
Subject: Re: [PATCH v2] cifs: fix that return -EINVAL when do dedupe operation
Date: Sun, 17 Mar 2019 13:52:21 -0700	[thread overview]
Message-ID: <CAKywueSvAFiyVH387BXQJOdC1Rt4LQT2DjeCqq5WDWJzZTkK+A@mail.gmail.com> (raw)
In-Reply-To: <CAOoqPcQN-bqfiMkGWffXZ-EZqiZZ=NEySUF8PmPzcaK2s=yHPA@mail.gmail.com>

Thanks for confirming this!

--
Best regards,
Pavel Shilovsky

вс, 17 мар. 2019 г. в 06:46, 冯小丽 <fengxiaoli0714@gmail.com>:
>
> I checked my test kernel. It didn't include the fixed patch you mention. And after including this fixed
> patch, bz202785 is gone. Thank you for this information. I will update the commit log.
>
> (re-send this mail again. Because the last mail message contains HTML subpart. Sorry about that)
>
> Pavel Shilovsky <piastryyy@gmail.com> 于2019年3月17日周日 上午12:46写道：
>>
>> пт, 15 мар. 2019 г. в 22:39, Steve French <smfrench@gmail.com>:
>>
>> >
>> > updated and tentatively placed in for-next - running the automated tests now
>> >
>> > On Fri, Mar 15, 2019 at 11:12 PM XiaoLi Feng <xifeng@redhat.com> wrote:
>> > >
>> > > From: Xiaoli Feng <fengxiaoli0714@gmail.com>
>> > >
>> > > dedupe_file_range operations is combiled into remap_file_range.
>> > > But it's always skipped for dedupe operations in function
>> > > cifs_remap_file_range.
>> > >
>> > > Example to test:
>> > > Before this patch:
>> > >   # dd if=/dev/zero of=cifs/file bs=1M count=1
>> > >   # xfs_io -c "dedupe cifs/file 4k 64k 4k" cifs/file
>> > >   XFS_IOC_FILE_EXTENT_SAME: Invalid argument
>> > >
>> > > After this patch:
>> > >   # dd if=/dev/zero of=cifs/file bs=1M count=1
>> > >   # xfs_io -c "dedupe cifs/file 4k 64k 4k" cifs/file
>> > >   XFS_IOC_FILE_EXTENT_SAME: Operation not supported
>> > >
>> > > Influence for xfstests:
>> > > generic/091
>> > > generic/112
>> > > generic/127
>> > > generic/263
>> > > These tests report this error "do_copy_range:: Invalid
>> > > argument" instead of "FIDEDUPERANGE: Invalid argument".
>> > > Because there are still two bugs cause these test failed.
>> > > https://bugzilla.kernel.org/show_bug.cgi?id=202935
>> > > https://bugzilla.kernel.org/show_bug.cgi?id=202785
>>
>> Hi Xiaoli,
>>
>> About https://bugzilla.kernel.org/show_bug.cgi?id=202785: which kernel
>> version did you use for testing?
>>
>> There is a fix merged recently that fixes a similar problem:
>> https://patchwork.ozlabs.org/patch/1052067/.
>>
>> --
>> Best regards,
>> Pavel Shilovsky