From: Pavel Shilovsky <piastryyy@gmail.com>
To: "Paulo Alcantara (SUSE)" <pc@cjr.nz>
Cc: "Steve French" <smfrench@gmail.com>,
"Aurélien Aptel" <aaptel@suse.com>,
linux-cifs <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH v2 4/7] cifs: Clean up DFS referral cache
Date: Mon, 25 Nov 2019 13:06:47 -0800 [thread overview]
Message-ID: <CAKywueTb_RNZKgykwrfqYaPGirzOOjfKWEqkCK7ebGd=KRipAA@mail.gmail.com> (raw)
In-Reply-To: <20191125165758.3793-5-pc@cjr.nz>
пн, 25 нояб. 2019 г. в 09:00, Paulo Alcantara (SUSE) <pc@cjr.nz>:
>
> This patch does a couple of things:
>
> - Do some renaming in static code (cosmetic)
> - Use rwlock for cache list
> - Use spinlock for volume list
> - Avoid lock contention in some places
Could you separate the changes into several (ideally 4) patches? This
patch is huge which may be a problem when viewing the changes and or
bisecting for potential regression in future.
--
Best regards,
Pavel Shilovsky
next prev parent reply other threads:[~2019-11-25 21:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 16:57 [PATCH v2 0/7] DFS fixes Paulo Alcantara (SUSE)
2019-11-25 16:57 ` [PATCH v2 1/7] cifs: Fix use-after-free bug in cifs_reconnect() Paulo Alcantara (SUSE)
2019-11-25 16:57 ` [PATCH v2 2/7] cifs: Fix lookup of root ses in DFS referral cache Paulo Alcantara (SUSE)
2019-11-25 16:57 ` [PATCH v2 3/7] cifs: Fix potential softlockups while refreshing DFS cache Paulo Alcantara (SUSE)
2019-11-25 16:57 ` [PATCH v2 4/7] cifs: Clean up DFS referral cache Paulo Alcantara (SUSE)
2019-11-25 21:06 ` Pavel Shilovsky [this message]
2019-11-25 21:18 ` Paulo Alcantara
2019-11-25 16:57 ` [PATCH v2 5/7] cifs: Fix potential deadlock when updating vol in cifs_reconnect() Paulo Alcantara (SUSE)
2019-11-25 16:57 ` [PATCH v2 6/7] cifs: Fix retrieval of DFS referrals in cifs_mount() Paulo Alcantara (SUSE)
2019-11-25 16:57 ` [PATCH v2 7/7] cifs: Always update signing key of first channel Paulo Alcantara (SUSE)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKywueTb_RNZKgykwrfqYaPGirzOOjfKWEqkCK7ebGd=KRipAA@mail.gmail.com' \
--to=piastryyy@gmail.com \
--cc=aaptel@suse.com \
--cc=linux-cifs@vger.kernel.org \
--cc=pc@cjr.nz \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).