From: Dan Carpenter <dan.carpenter@oracle.com>
To: namjae.jeon@samsung.com
Cc: linux-cifs@vger.kernel.org
Subject: [bug report] cifsd: add file operations
Date: Wed, 7 Jul 2021 13:11:53 +0300 [thread overview]
Message-ID: <YOV96UFhrII4qwXg@mwanda> (raw)
Hello Namjae Jeon,
The patch f44158485826: "cifsd: add file operations" from Mar 16,
2021, leads to the following static checker warning:
fs/ksmbd/vfs_cache.c:661 ksmbd_file_table_flush()
warn: was expecting a 64 bit value instead of '0'
fs/ksmbd/vfs_cache.c
653 int ksmbd_file_table_flush(struct ksmbd_work *work)
654 {
655 struct ksmbd_file *fp = NULL;
656 unsigned int id;
657 int ret;
658
659 read_lock(&work->sess->file_table.lock);
660 idr_for_each_entry(work->sess->file_table.idr, fp, id) {
661 ret = ksmbd_vfs_fsync(work, fp->volatile_id, KSMBD_NO_FID);
TBH, I'm not sure what's triggering this warning, but ksmbd_vfs_fsync()
takes a u64 and fp->volatile_id is a u32. The ksmbd_lookup_fd_slow()
function takes a u32 so passing a u64 value seems like it would lead to
a bug. And smb2_flush() passes a u64 so this seems buggy.
662 if (ret)
663 break;
664 }
665 read_unlock(&work->sess->file_table.lock);
666 return ret;
667 }
regards,
dan carpenter
next reply other threads:[~2021-07-07 10:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 10:11 Dan Carpenter [this message]
2023-03-03 14:10 [bug report] cifsd: add file operations Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOV96UFhrII4qwXg@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-cifs@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).