From: Stephen Boyd <sboyd@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>,
Mircea Caprioru <mircea.caprioru@analog.com>
Cc: Michael.Hennerich@analog.com, knaack.h@gmx.de, lars@metafoo.de,
pmeerw@pmeerw.net, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devel@driverdev.osuosl.org, Rob Herring <robh+dt@kernel.org>,
linux-clk@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: iio: adc: ad7192: Add clock for external clock reference
Date: Thu, 13 Dec 2018 17:39:22 -0800 [thread overview]
Message-ID: <154475156267.19322.6284056396098102605@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20181208152954.596529f8@archlinux>
Quoting Jonathan Cameron (2018-12-08 07:29:54)
> On Thu, 6 Dec 2018 11:10:51 +0200
> Mircea Caprioru <mircea.caprioru@analog.com> wrote:
>
> > This patch adds a clock to the state structure of ad7192 for getting the
> > external clock frequency. This modifications is in accordance with clock
> > framework dt bindings documentation.
> >
> > Signed-off-by: Mircea Caprioru <mircea.caprioru@analog.com>
>
> +cc Rob and the clk list for advise on how to do the binding for this one.
>
> It is basically 2 pins, you can put a clock in on one of them or connect
> a crystal across them. The driver has to set a register to say which is
> the case.
>
> Current proposal is two optional clocks (fall back to internal oscillator)
> but that doesn't seem to be commonly done, so I'm wondering if there
> is a 'standard' way to handle this sort of thing.
>
I'm not sure I fully understand, but I think perhaps
assigned-clock-parents would work? Or does that not work because either
way some parent is assigned, either the crystal or the optional clk that
isn't a crystal?
next prev parent reply other threads:[~2018-12-14 1:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181206091052.7644-1-mircea.caprioru@analog.com>
2018-12-08 15:29 ` [PATCH 1/2] staging: iio: adc: ad7192: Add clock for external clock reference Jonathan Cameron
2018-12-14 1:39 ` Stephen Boyd [this message]
2018-12-16 10:07 ` Jonathan Cameron
2019-01-24 22:41 ` Stephen Boyd
2019-01-25 8:16 ` Alexandru Ardelean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154475156267.19322.6284056396098102605@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-clk@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mircea.caprioru@analog.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).