From: Stephen Boyd <sboyd@kernel.org>
To: Govind Singh <govinds@codeaurora.org>,
bjorn.andersson@linaro.org, linux-remoteproc@vger.kernel.org
Cc: linux-clk@vger.kernel.org, sricharan@codeaurora.org,
sibis@codeaurora.org, linux-arm-msm@vger.kernel.org,
andy.gross@linaro.org, david.brown@linaro.org,
linux-soc@vger.kernel.org, devicetree@vger.kernel.org,
Govind Singh <govinds@codeaurora.org>
Subject: Re: [PATCH v3 5/7] remoteproc: qcom: wcss: populate hardcoded param using driver data
Date: Mon, 17 Dec 2018 10:55:24 -0800 [thread overview]
Message-ID: <154507292461.19322.16649255647859149880@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20181215103557.2748-6-govinds@codeaurora.org>
Quoting Govind Singh (2018-12-15 02:35:55)
> diff --git a/drivers/remoteproc/qcom_q6v5_wcss.c b/drivers/remoteproc/qcom_q6v5_wcss.c
> index f93e1e4a1cc0..129f82404656 100644
> --- a/drivers/remoteproc/qcom_q6v5_wcss.c
> +++ b/drivers/remoteproc/qcom_q6v5_wcss.c
> @@ -16,7 +17,6 @@
> #include "qcom_common.h"
> #include "qcom_q6v5.h"
>
> -#define WCSS_CRASH_REASON 421
>
> /* Q6SS Register Offsets */
> #define Q6SS_RESET_REG 0x014
> @@ -70,6 +70,14 @@
> #define TCSR_WCSS_CLK_MASK 0x1F
> #define TCSR_WCSS_CLK_ENABLE 0x14
>
> +struct wcss_data {
> + void (*pas_handover)(struct qcom_q6v5 *q6v5);
> + const char *firmware_name;
> + int crash_reason_smem;
> + int version;
version can be negative?
> + int pas_id;
And the pas_id can be negative too?
> +};
> +
> struct q6v5_wcss {
> struct device *dev;
>
> @@ -553,7 +573,8 @@ static int q6v5_wcss_probe(struct platform_device *pdev)
> if (ret)
> goto free_rproc;
>
> - ret = qcom_q6v5_init(&wcss->q6v5, pdev, rproc, WCSS_CRASH_REASON, NULL);
> + ret = qcom_q6v5_init(&wcss->q6v5, pdev, rproc, desc->crash_reason_smem,
> + desc->pas_handover);
> if (ret)
> goto free_rproc;
>
> @@ -581,8 +602,15 @@ static int q6v5_wcss_remove(struct platform_device *pdev)
> return 0;
> }
>
> +static const struct wcss_data wcss_ipq8074_res_init = {
> + .firmware_name = "IPQ8074/q6_fw.mdt",
> + .crash_reason_smem = 421,
Why destroy the #define and inline it here? Keep the define around and
use it here instead?
> + .pas_handover = NULL,
This surely isn't needed to be assigned to NULL.
next prev parent reply other threads:[~2018-12-17 18:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-15 10:35 [PATCH v3 0/7] Add non PAS wcss Q6 support for QCS404 Govind Singh
2018-12-15 10:35 ` [PATCH v3 1/7] dt-bindings: clock: qcom: Introduce QCOM WCSS Q6DSP clock bindings Govind Singh
2018-12-17 19:33 ` Stephen Boyd
2019-02-02 15:35 ` Govind Singh
2018-12-15 10:35 ` [PATCH v3 2/7] clk: qcom: Add WCSS Q6DSP clock controller for QCS404 Govind Singh
2018-12-17 18:52 ` Stephen Boyd
2019-02-02 15:45 ` Govind Singh
2018-12-15 10:35 ` [PATCH v3 3/7] dt-bindings: clock: qcom: Add QCOM WCSS GCC clock bindings Govind Singh
2018-12-17 19:34 ` Stephen Boyd
2019-02-02 15:33 ` Govind Singh
2018-12-15 10:35 ` [PATCH v3 4/7] clk: qcom: Add WCSS gcc clock control for QCS404 Govind Singh
2018-12-15 17:56 ` Bjorn Andersson
2019-02-02 15:32 ` Govind Singh
2018-12-17 18:53 ` Stephen Boyd
2018-12-15 10:35 ` [PATCH v3 5/7] remoteproc: qcom: wcss: populate hardcoded param using driver data Govind Singh
2018-12-17 18:55 ` Stephen Boyd [this message]
2018-12-15 10:35 ` [PATCH v3 6/7] remoteproc: qcom: wcss: Add non pas wcss Q6 support for QCS404 Govind Singh
2018-12-17 19:00 ` Stephen Boyd
2018-12-17 20:48 ` Rob Herring
2018-12-15 10:35 ` [PATCH v3 7/7] remoteproc: qcom: wcss: explicitly request exclusive reset control Govind Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154507292461.19322.16649255647859149880@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=govinds@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=sibis@codeaurora.org \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).