From: Stephen Boyd <sboyd@kernel.org>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: broonie@kernel.org, lee.jones@linaro.org,
linus.walleij@linaro.org, mturquette@baylibre.com,
robh+dt@kernel.org, mark.rutland@arm.com, lgirdwood@gmail.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com, linux-clk@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v5 7/8] clk: lochnagar: Add support for the Cirrus Logic Lochnagar
Date: Fri, 21 Dec 2018 12:44:37 -0800 [thread overview]
Message-ID: <154542507738.13075.5210584076841559233@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20181221135037.GH16508@imbe.wolfsonmicro.main>
Quoting Charles Keepax (2018-12-21 05:50:37)
> On Thu, Nov 29, 2018 at 11:53:51PM -0800, Stephen Boyd wrote:
> > Quoting Charles Keepax (2018-11-20 06:16:30)
>
> > > + break;
> > > + default:
> > > + dev_err(priv->dev, "Unknown Lochnagar type: %d\n", priv->type);
> > > + return -EINVAL;
> > > + }
> > > +
> > > + if (!priv->parents)
> > > + return -ENOMEM;
> > > +
> > > + for (i = 0; i < priv->nparents; i++) {
> > > + j = of_property_match_string(np, "clock-names",
> > > + priv->parents[i]);
> > > + if (j >= 0)
> > > + priv->parents[i] = of_clk_get_parent_name(np, j);
> >
> > Isn't this of_clk_parent_fill()? But there are holes or something?
> >
>
> I guess rather than a fill, this is perhaps more of a name and
> replace. I could make this a core function if you prefer? I think
> there are a couple of other drivers that could also use it,
> although might be worth doing that as a separate series rather
> than holding this one up.
No worries. I'm actively changing the parent_names design anyway so this
is fine.
>
>
> > > +static struct platform_driver lochnagar_clk_driver = {
> > > + .driver = {
> > > + .name = "lochnagar-clk",
> > > + .of_match_table = of_match_ptr(lochnagar_of_match),
> >
> > I suspect of_match_ptr() makes the build complain about unused match
> > table when CONFIG_OF=N. Can you try building it that way?
> >
>
> The driver depends on the MFD which in turn depends on CONFIG_OF
> so that shouldn't be a problem.
Ok. Then it's really not needed and it's better to drop the usage of
of_match_ptr() then.
>
next prev parent reply other threads:[~2018-12-21 20:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 14:16 [PATCH v5 1/8] regulator: lochnagar: Move driver to binding from DT Charles Keepax
2018-11-20 14:16 ` [PATCH v5 2/8] mfd: lochnagar: Add initial binding documentation Charles Keepax
2018-11-28 9:18 ` Lee Jones
2018-11-20 14:16 ` [PATCH v5 3/8] clk: " Charles Keepax
2018-11-26 20:16 ` Rob Herring
2018-11-27 9:34 ` Charles Keepax
2018-11-20 14:16 ` [PATCH v5 4/8] pinctrl: " Charles Keepax
2018-12-07 17:07 ` Rob Herring
2018-12-16 0:16 ` Linus Walleij
2018-11-20 14:16 ` [PATCH v5 5/8] regulator: " Charles Keepax
2018-11-20 14:16 ` [PATCH v5 6/8] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar Charles Keepax
2018-11-23 9:00 ` kbuild test robot
2018-11-23 9:15 ` Charles Keepax
2018-11-28 9:22 ` Lee Jones
2018-11-20 14:16 ` [PATCH v5 7/8] clk: " Charles Keepax
2018-11-30 7:53 ` Stephen Boyd
2018-12-21 13:50 ` Charles Keepax
2018-12-21 15:28 ` Charles Keepax
2018-12-21 20:44 ` Stephen Boyd [this message]
2018-11-20 14:16 ` [PATCH v5 8/8] pinctrl: " Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154542507738.13075.5210584076841559233@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=patches@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).