From: Stephen Boyd <sboyd@kernel.org>
To: Marek Vasut <marek.vasut@gmail.com>, linux-clk@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Alexey Firago <alexey_firago@mentor.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH] clk: vc5: Abort clock configuration without upstream clock
Date: Wed, 09 Jan 2019 10:54:24 -0800 [thread overview]
Message-ID: <154706006447.15366.17768068514421647549@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20181215005519.3695-1-marek.vasut+renesas@gmail.com>
Quoting Marek Vasut (2018-12-14 16:55:19)
> In case the upstream clock are not set, which can happen in case the
> VC5 has no valid upstream clock, the $src variable is used uninited
> by regmap_update_bits(). Check for this condition and return -EINVAL
> in such case.
>
> Note that in case the VC5 has no valid upstream clock, the VC5 can
> not operate correctly. That is a hardware property of the VC5. The
> internal oscilator present in some VC5 models is also considered
> upstream clock.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Alexey Firago <alexey_firago@mentor.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: linux-renesas-soc@vger.kernel.org
> ---
Applied to clk-fixes
prev parent reply other threads:[~2019-01-09 18:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-15 0:55 [PATCH] clk: vc5: Abort clock configuration without upstream clock Marek Vasut
2018-12-16 7:19 ` Laurent Pinchart
2018-12-16 17:14 ` Marek Vasut
2018-12-28 22:30 ` Stephen Boyd
2018-12-29 16:34 ` Laurent Pinchart
2019-01-09 18:49 ` Stephen Boyd
2019-01-09 18:54 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154706006447.15366.17768068514421647549@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=alexey_firago@mentor.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=marek.vasut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).