From: Weiyi Lu <weiyi.lu@mediatek.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Nicolas Boichat <drinkcat@chromium.org>,
Rob Herring <robh@kernel.org>,
Stephen Boyd <sboyd@codeaurora.org>,
James Liao <jamesjj.liao@mediatek.com>,
<srv_heupstream@mediatek.com>, <linux-kernel@vger.kernel.org>,
<stable@vger.kernel.org>, Fan Chen <fan.chen@mediatek.com>,
<linux-mediatek@lists.infradead.org>, <linux-clk@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 08/12] clk: mediatek: Add MT8183 clock support
Date: Fri, 1 Feb 2019 16:22:23 +0800 [thread overview]
Message-ID: <1549009343.22634.4.camel@mtksdaap41> (raw)
In-Reply-To: <154482479243.19322.7465842539016312943@swboyd.mtv.corp.google.com>
On Fri, 2018-12-14 at 13:59 -0800, Stephen Boyd wrote:
> Quoting Weiyi Lu (2018-12-09 23:32:36)
> > + "apll2_ck"
> > +};
> > +
> > +static const struct mtk_mux top_muxes[] = {
> > + /* CLK_CFG_0 */
> > + MUX_GATE_CLR_SET_UPD_FLAGS(CLK_TOP_MUX_AXI, "axi_sel",
> > + axi_parents, 0x40,
> > + 0x44, 0x48, 0, 2, 7, 0x004, 0, CLK_IS_CRITICAL),
>
> Please document why CLK_IS_CRITICAL is being used everywhere it's used.
>
OK, I'll add some more comment at where critical clock data is declared.
> > + MUX_GATE_CLR_SET_UPD(CLK_TOP_MUX_MM, "mm_sel",
> > + mm_parents, 0x40,
> > + 0x44, 0x48, 8, 3, 15, 0x004, 1),
> > + MUX_GATE_CLR_SET_UPD(CLK_TOP_MUX_IMG, "img_sel",
> > + img_parents, 0x40,
> > + 0x44, 0x48, 16, 3, 23, 0x004, 2),
> > + MUX_GATE_CLR_SET_UPD(CLK_TOP_MUX_CAM, "cam_sel",
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2019-02-01 8:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 7:32 [PATCH v3 00/11] Mediatek MT8183 clock and scpsys support Weiyi Lu
2018-12-10 7:32 ` [PATCH v3 00/12] " Weiyi Lu
2018-12-10 7:32 ` [PATCH v3 01/12] clk: mediatek: fixup: Disable tuner_en before change PLL rate Weiyi Lu
2018-12-14 21:57 ` Stephen Boyd
2019-02-01 8:21 ` Weiyi Lu
2018-12-10 7:32 ` [PATCH v3 02/12] clk: mediatek: add new clkmux register API Weiyi Lu
2018-12-10 12:30 ` Nicolas Boichat
2019-02-01 8:22 ` Weiyi Lu
2018-12-10 7:32 ` [PATCH v3 03/12] clk: mediatek: add configurable pcwibits and fmin to mtk_pll_data Weiyi Lu
2018-12-14 22:02 ` Stephen Boyd
2019-02-01 8:22 ` Weiyi Lu
2018-12-10 7:32 ` [PATCH v3 04/12] soc: mediatek: add new flow for mtcmos power Weiyi Lu
2018-12-10 12:52 ` Nicolas Boichat
2018-12-10 7:32 ` [PATCH v3 05/12] dt-bindings: ARM: Mediatek: Document bindings for MT8183 Weiyi Lu
2018-12-14 21:57 ` Stephen Boyd
2018-12-10 7:32 ` [PATCH v3 06/12] clk: mediatek: Add dt-bindings for MT8183 clocks Weiyi Lu
2018-12-10 7:32 ` [PATCH v3 07/12] clk: mediatek: Add flags support for mtk_gate data Weiyi Lu
2018-12-10 7:32 ` [PATCH v3 08/12] clk: mediatek: Add MT8183 clock support Weiyi Lu
2018-12-11 1:00 ` Nicolas Boichat
2019-02-01 8:22 ` Weiyi Lu
2018-12-14 21:59 ` Stephen Boyd
2019-02-01 8:22 ` Weiyi Lu [this message]
2018-12-10 7:32 ` [PATCH v3 09/12] dt-bindings: soc: fix typo of MT8173 power dt-bindings Weiyi Lu
2018-12-10 7:32 ` [PATCH v3 10/12] dt-bindings: soc: Add MT8183 " Weiyi Lu
2018-12-10 7:32 ` [PATCH v3 11/12] soc: mediatek: Add MT8183 scpsys support Weiyi Lu
2018-12-10 7:32 ` [PATCH v3 12/12] clk: mediatek: Allow changing PLL rate when it is off Weiyi Lu
2018-12-14 22:01 ` Stephen Boyd
2019-02-01 8:22 ` Weiyi Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1549009343.22634.4.camel@mtksdaap41 \
--to=weiyi.lu@mediatek.com \
--cc=drinkcat@chromium.org \
--cc=fan.chen@mediatek.com \
--cc=jamesjj.liao@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).