From: Paul Cercueil <paul@crapouillou.net>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
Mathieu Malaterre <malat@debian.org>,
Thierry Reding <thierry.reding@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@mips.com>,
James Hogan <jhogan@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
Ezequiel Garcia <ezequiel@collabora.co.uk>,
PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>,
linux-pwm@vger.kernel.org,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
linux-watchdog@vger.kernel.org, linux-mips@vger.kernel.org,
linux-doc@vger.kernel.org, linux-clk@vger.kernel.org, od@zcrc.me,
Maarten ter Huurne <maarten@treewalker.org>
Subject: Re: [PATCH v8 05/26] clocksource: Add driver for the Ingenic JZ47xx OST
Date: Sat, 23 Feb 2019 00:17:25 -0300 [thread overview]
Message-ID: <1550891845.20534.1@crapouillou.net> (raw)
In-Reply-To: <1548370388.3881.2@crapouillou.net>
Hi,
Le jeu. 24 janv. 2019 à 19:53, Paul Cercueil <paul@crapouillou.net> a
écrit :
>
>
> Le jeu. 24 janv. 2019 à 19:46, Stephen Boyd <sboyd@kernel.org> a
> écrit :
>> Quoting Paul Cercueil (2019-01-24 12:46:28)
>>>
>>>
>>> Le jeu. 24 janv. 2019 à 16:28, Stephen Boyd <sboyd@kernel.org> a
>>> écrit :
>>> > Quoting Guenter Roeck (2019-01-23 10:01:55)
>>> >> On Wed, Jan 23, 2019 at 02:25:53PM -0300, Paul Cercueil wrote:
>>> >> > Hi,
>>> >> >
>>> >> > Le mer. 23 janv. 2019 Ã 11:31, Guenter Roeck
>>> >> <linux@roeck-us.net> a écrit :
>>> >> > >On 1/23/19 4:58 AM, Mathieu Malaterre wrote:
>>> >> > >>On Wed, Dec 12, 2018 at 11:09 PM Paul Cercueil
>>> >> <paul@crapouillou.net>
>>> >> > >>wrote:
>>> >> > >>>
>>> >> > >>>From: Maarten ter Huurne <maarten@treewalker.org>
>>> >> > >>>
>>> >> > >>>OST is the OS Timer, a 64-bit timer/counter with buffered
>>> >> reading.
>>> >> > >>>
>>> >> > >>>SoCs before the JZ4770 had (if any) a 32-bit OST; the
>>> \x7f\x7fJZ4770
>>> >> and
>>> >> > >>>JZ4780 have a 64-bit OST.
>>> >> > >>>
>>> >> > >>>This driver will register both a clocksource and a
>>> \x7f\x7fsched_clock
>>> >> to the
>>> >> > >>>system.
>>> >> > >>>
>>> >> > >>>Signed-off-by: Maarten ter Huurne <maarten@treewalker.org>
>>> >> > >>>Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>>> >> > >>>---
>>> >> > >>>
>>> >> > >>>Notes:
>>> >> > >>> v5: New patch
>>> >> > >>>
>>> >> > >>> v6: - Get rid of SoC IDs; pass pointer to
>>> >> ingenic_ost_soc_info
>>> >> > >>>as
>>> >> > >>> devicetree match data instead.
>>> >> > >>> - Use device_get_match_data() instead of the
>>> of_*
>>> >> variant
>>> >> > >>> - Handle error of dev_get_regmap() properly
>>> >> > >>>
>>> >> > >>> v7: Fix section mismatch by using
>>> >> > >>>builtin_platform_driver_probe()
>>> >> > >>>
>>> >> > >>> v8: builtin_platform_driver_probe() does not work
>>> >> anymore in
>>> >> > >>> 4.20-rc6? The probe function won't be called.
>>> \x7f\x7fWork
>>> >> around
>>> >> > >>>this
>>> >> > >>> for now by using late_initcall.
>>> >> > >>>
>>> >> > >
>>> >> > >Did anyone notice this ? Either something is wrong with the
>>> >> driver, or
>>> >> > >with the kernel core. Hacking around it seems like the worst
>>> >> possible
>>> >> > >"solution".
>>> >> >
>>> >> > I can confirm it still happens on 5.0-rc3.
>>> >> >
>>> >> > Just to explain what I'm doing:
>>> >> >
>>> >> > My ingenic-timer driver probes with
>>> \x7f\x7fbuiltin_platform_driver_probe
>>> >> (this
>>> >> > works),
>>> >> > and then calls of_platform_populate to probe its children.
>>> \x7f\x7fThis
>>> >> driver,
>>> >> > ingenic-ost, is one of them, and will fail to probe with
>>> >> > builtin_platform_driver_probe.
>>> >> >
>>> >>
>>> >> The big question is _why_ it fails to probe.
>>> >>
>>> >
>>> > Are you sharing the device tree node between a 'normal' platform
>>> > device
>>> > driver and something more low level DT that marks the device's
>>> \x7f\x7fbacking
>>> > DT node as OF_POPULATED early on? That's my only guess why it's
>>> \x7f\x7fnot
>>> > working.
>>>
>>> I do, but I clear the OF_POPULATED flag so that it is then probed
>>> \x7f\x7fas a
>>> normal platform device, and it's not on this driver's node but its
>>> parent.
>>>
>>
>> Where do you clear the OF_POPULATED flag?
>>
>
> In the ingenic-timer driver introduced in patch [04/26], inside the
> probe function.
Anything new on this? It still happens on 5.0-rc7.
It probes with late_initcall, and not with device_initcall.
I have no clue what's going on.
-Paul
next prev parent reply other threads:[~2019-02-23 3:17 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 22:08 [PATCH v8 00/26] Ingenic TCU patchset v8 Paul Cercueil
2018-12-12 22:08 ` [PATCH v8 01/26] dt-bindings: ingenic: Add DT bindings for TCU clocks Paul Cercueil
2018-12-17 23:18 ` Stephen Boyd
2018-12-12 22:08 ` [PATCH v8 02/26] doc: Add doc for the Ingenic TCU hardware Paul Cercueil
2018-12-12 22:08 ` [PATCH v8 03/26] dt-bindings: Add doc for the Ingenic TCU drivers Paul Cercueil
2018-12-17 21:05 ` Rob Herring
2018-12-17 22:03 ` Paul Cercueil
2018-12-18 16:36 ` Rob Herring
2018-12-22 11:09 ` Paul Cercueil
2018-12-12 22:08 ` [PATCH v8 04/26] clocksource: Add a new timer-ingenic driver Paul Cercueil
2018-12-12 22:09 ` [PATCH v8 05/26] clocksource: Add driver for the Ingenic JZ47xx OST Paul Cercueil
2019-01-23 12:58 ` Mathieu Malaterre
2019-01-23 14:31 ` Guenter Roeck
2019-01-23 17:25 ` Paul Cercueil
2019-01-23 18:01 ` Guenter Roeck
2019-01-24 19:28 ` Stephen Boyd
2019-01-24 20:46 ` Paul Cercueil
2019-01-24 22:46 ` Stephen Boyd
2019-01-24 22:53 ` Paul Cercueil
2019-02-23 3:17 ` Paul Cercueil [this message]
2019-02-25 18:05 ` Stephen Boyd
2019-02-27 23:54 ` Paul Cercueil
2019-01-23 17:27 ` Paul Cercueil
2018-12-12 22:09 ` [PATCH v8 06/26] MAINTAINERS: Add myself as maintainer for Ingenic TCU drivers Paul Cercueil
2018-12-12 22:09 ` [PATCH v8 07/26] watchdog: jz4740: Use WDT clock provided by TCU driver Paul Cercueil
2018-12-12 22:09 ` [PATCH v8 08/26] watchdog: jz4740: Use regmap " Paul Cercueil
2018-12-12 22:09 ` [PATCH v8 09/26] watchdog: jz4740: Avoid starting watchdog in set_timeout Paul Cercueil
2018-12-12 22:09 ` [PATCH v8 10/26] watchdog: jz4740: Drop dependency on MACH_JZ47xx, use COMPILE_TEST Paul Cercueil
2018-12-12 22:09 ` [PATCH v8 11/26] pwm: jz4740: Use regmap and clocks from TCU driver Paul Cercueil
2018-12-13 9:30 ` Uwe Kleine-König
2018-12-13 14:34 ` Paul Cercueil
2018-12-12 22:09 ` [PATCH v8 12/26] pwm: jz4740: Allow selection of PWM channels 0 and 1 Paul Cercueil
2018-12-13 9:18 ` Uwe Kleine-König
2018-12-13 13:58 ` Paul Cercueil
2018-12-13 20:32 ` Uwe Kleine-König
2018-12-16 13:36 ` Paul Cercueil
2018-12-17 7:43 ` Uwe Kleine-König
2018-12-12 22:09 ` [PATCH v8 13/26] pwm: jz4740: Drop dependency on MACH_INGENIC, use COMPILE_TEST Paul Cercueil
2018-12-12 22:09 ` [PATCH v8 14/26] pwm: jz4740: Remove unused devicetree compatible strings Paul Cercueil
2018-12-12 22:09 ` [PATCH v8 15/26] pwm: jz4740: Add support for the JZ4725B Paul Cercueil
2018-12-13 9:24 ` Uwe Kleine-König
2018-12-13 14:03 ` Paul Cercueil
2018-12-13 16:18 ` Thierry Reding
2018-12-13 20:42 ` Uwe Kleine-König
2018-12-14 13:50 ` Linus Walleij
2018-12-14 14:26 ` Uwe Kleine-König
2018-12-14 14:56 ` Linus Walleij
2018-12-16 14:18 ` Paul Cercueil
2018-12-17 7:53 ` Uwe Kleine-König
2018-12-20 17:39 ` Thierry Reding
2018-12-20 20:58 ` Uwe Kleine-König
2018-12-12 22:09 ` [PATCH v8 16/26] clk: jz4740: Add TCU clock Paul Cercueil
2018-12-12 22:09 ` [PATCH v8 17/26] MIPS: Kconfig: Select TCU timer driver when MACH_INGENIC is set Paul Cercueil
2018-12-12 22:09 ` [PATCH v8 18/26] MIPS: jz4740: Add DTS nodes for the TCU drivers Paul Cercueil
2018-12-12 22:09 ` [PATCH v8 19/26] MIPS: qi_lb60: Move PWM devices to devicetree Paul Cercueil
2018-12-12 22:09 ` [PATCH v8 20/26] MIPS: qi_lb60: Reduce system timer and clocksource to 750 kHz Paul Cercueil
2018-12-12 22:12 ` [PATCH v8 21/26] MIPS: CI20: Reduce system timer and clocksource to 3 MHz Paul Cercueil
2018-12-12 22:12 ` [PATCH v8 22/26] MIPS: CI20: defconfig: enable OST driver Paul Cercueil
2018-12-12 22:13 ` [PATCH v8 23/26] MIPS: GCW0: Move clocksource to TCU channel 2 Paul Cercueil
2018-12-12 22:13 ` [PATCH v8 24/26] MIPS: GCW0: Reduce system timer and clocksource to 750 kHz Paul Cercueil
2018-12-12 22:14 ` [PATCH v8 25/26] MIPS: GCW0: defconfig: Enable OST, watchdog, PWM drivers Paul Cercueil
2018-12-12 22:15 ` [PATCH v8 26/26] MIPS: jz4740: Drop obsolete code Paul Cercueil
2019-01-24 21:26 ` [PATCH v8 00/26] Ingenic TCU patchset v8 Mathieu Malaterre
2019-01-24 21:41 ` Paul Cercueil
2019-01-25 8:21 ` Mathieu Malaterre
2019-01-25 17:04 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1550891845.20534.1@crapouillou.net \
--to=paul@crapouillou.net \
--cc=corbet@lwn.net \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@collabora.co.uk \
--cc=jhogan@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maarten@treewalker.org \
--cc=malat@debian.org \
--cc=mark.rutland@arm.com \
--cc=od@zcrc.me \
--cc=paul.burton@mips.com \
--cc=prasannatsmkumar@gmail.com \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).