From: Stephen Boyd <sboyd@kernel.org>
To: Tero Kristo <t-kristo@ti.com>,
linux-clk@vger.kernel.org, mturquette@baylibre.com
Cc: linux-omap@vger.kernel.org, tony@atomide.com
Subject: Re: [PATCH 0/4] clk: ti: get rid of CLK_IS_BASIC
Date: Mon, 25 Feb 2019 09:12:33 -0800 [thread overview]
Message-ID: <155111475379.77512.6004310681803541628@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <5e6295e2-6916-5ffb-e9e9-c0fa4ed29aa5@ti.com>
Quoting Tero Kristo (2019-02-24 23:18:57)
> On 22/02/2019 21:50, Stephen Boyd wrote:
> > Quoting Tero Kristo (2019-01-15 01:15:11)
> >> Hi Stephen,
> >>
> >> As requested, this series gets rid of CLK_IS_BASIC flag usage from
> >> TI clock drivers.
> >>
> >> Boot tested on am3/am4/am5/omap3/omap4 series of SoCs. Also, ran a quick
> >> suspend/resume test on omap3/omap4/am5.
> >>
> >
> > I'm looking at clk-next now that this is all merged in and I still see
> > one usage of CLK_IS_BASIC in the omap2 hwmod code.
> >
> > arch/arm/mach-omap2/omap_hwmod.c: if (__clk_get_flags(oh->_clk) & CLK_IS_BASIC)
> >
> > Can that also be removed? If not, what clk types are on this platform?
> > Maybe I can remove CLK_IS_BASIC from every clk type except for the ones
> > that this code is checking for.
> >
>
> Hmm, I missed this in my update, only looked at the drivers/clk/ti
> portion of code. However, this can be fixed with the following patch, I
> would need to export the omap2_clk_is_hw_omap() func from the driver and
> call it from the omap2 platform code. What do you think? Shall I post
> this as an official change? This one still has the issue that I am
> calling __clk_get_hw() though.
Looks ok to me. Please post it as an official change. I think we should
look into making clk domains with genpds and plumb that through the clk
framework so that devices calling clk_get() can have their domains
attached automatically on clk_get(). Maybe that would help here. Not
sure.
prev parent reply other threads:[~2019-02-25 17:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 9:15 [PATCH 0/4] clk: ti: get rid of CLK_IS_BASIC Tero Kristo
2019-01-15 9:15 ` [PATCH 1/4] clk: ti: move clk_hw_omap list handling under generic part of the driver Tero Kristo
2019-01-15 9:15 ` [PATCH 2/4] clk: ti: add new API for checking if a provided clock is an OMAP clock Tero Kristo
2019-01-15 9:15 ` [PATCH 3/4] clk: ti: remove usage of CLK_IS_BASIC Tero Kristo
2019-01-15 9:15 ` [PATCH 4/4] clk: ti: generalize the init sequence of clk_hw_omap clocks Tero Kristo
2019-01-15 18:20 ` [PATCH 0/4] clk: ti: get rid of CLK_IS_BASIC Tony Lindgren
2019-01-15 18:31 ` Tero Kristo
2019-01-15 20:24 ` Andreas Kemnade
2019-01-21 19:58 ` Tony Lindgren
2019-02-15 19:19 ` Tero Kristo
2019-02-22 19:50 ` Stephen Boyd
2019-02-25 7:18 ` Tero Kristo
2019-02-25 17:12 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155111475379.77512.6004310681803541628@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).