From: Claudiu Beznea <claudiu.beznea@microchip.com>
To: <mturquette@baylibre.com>, <sboyd@kernel.org>,
<nicolas.ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
<ludovic.desroches@microchip.com>
Cc: <bbrezillon@kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-clk@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
"Claudiu Beznea" <claudiu.beznea@microchip.com>
Subject: [PATCH v2 04/18] clk: at91: sam9x60-pll: use logical or for range check
Date: Wed, 22 Jul 2020 10:38:12 +0300 [thread overview]
Message-ID: <1595403506-8209-5-git-send-email-claudiu.beznea@microchip.com> (raw)
In-Reply-To: <1595403506-8209-1-git-send-email-claudiu.beznea@microchip.com>
Use logical or for range check. In case bestrate is not in
characteristics->output[0].min..characteristics->output[0].max
range we should return -ERANGE.
Fixes: a436c2a447e59 ("clk: at91: add sam9x60 PLL driver")
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
drivers/clk/at91/clk-sam9x60-pll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/at91/clk-sam9x60-pll.c b/drivers/clk/at91/clk-sam9x60-pll.c
index 3522eae2edd6..4b7b6c435d4e 100644
--- a/drivers/clk/at91/clk-sam9x60-pll.c
+++ b/drivers/clk/at91/clk-sam9x60-pll.c
@@ -231,7 +231,7 @@ static long sam9x60_pll_get_best_div_mul(struct sam9x60_pll *pll,
}
/* Check if bestrate is a valid output rate */
- if (bestrate < characteristics->output[0].min &&
+ if (bestrate < characteristics->output[0].min ||
bestrate > characteristics->output[0].max)
return -ERANGE;
--
2.7.4
next prev parent reply other threads:[~2020-07-22 7:38 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 7:38 [PATCH v2 00/18] clk: at91: add sama7g5 clock support Claudiu Beznea
2020-07-22 7:38 ` [PATCH v2 01/18] clk: at91: clk-generated: continue if __clk_determine_rate() returns error Claudiu Beznea
2020-07-24 9:20 ` Stephen Boyd
2020-07-22 7:38 ` [PATCH v2 02/18] clk: at91: clk-generated: check best_rate against ranges Claudiu Beznea
2020-07-24 9:20 ` Stephen Boyd
2020-07-22 7:38 ` [PATCH v2 03/18] clk: at91: clk-sam9x60-pll: fix mul mask Claudiu Beznea
2020-07-24 9:20 ` Stephen Boyd
2020-07-22 7:38 ` Claudiu Beznea [this message]
2020-07-24 9:20 ` [PATCH v2 04/18] clk: at91: sam9x60-pll: use logical or for range check Stephen Boyd
2020-07-22 7:38 ` [PATCH v2 05/18] clk: at91: sam9x60-pll: check fcore against ranges Claudiu Beznea
2020-07-24 9:20 ` Stephen Boyd
2020-07-22 7:38 ` [PATCH v2 06/18] clk: at91: sam9x60-pll: use frac when setting frequency Claudiu Beznea
2020-07-24 9:21 ` Stephen Boyd
2020-07-22 7:38 ` [PATCH v2 07/18] clk: at91: sam9x60: fix main rc oscillator frequency Claudiu Beznea
2020-07-24 9:21 ` Stephen Boyd
2020-07-22 7:38 ` [PATCH v2 08/18] clk: at91: sckc: register slow_rc with accuracy option Claudiu Beznea
2020-07-24 9:21 ` Stephen Boyd
2020-07-22 7:38 ` [PATCH v2 09/18] clk: at91: replace conditional operator with double logical not Claudiu Beznea
2020-07-24 9:21 ` Stephen Boyd
2020-07-22 7:38 ` [PATCH v2 10/18] clk: at91: clk-generated: pass the id of changeable parent at registration Claudiu Beznea
2020-07-24 9:21 ` Stephen Boyd
2020-07-22 7:38 ` [PATCH v2 11/18] clk: at91: clk-generated: add mux_table option Claudiu Beznea
2020-07-24 9:21 ` Stephen Boyd
2020-07-22 7:38 ` [PATCH v2 12/18] clk: at91: clk-master: add master clock support for SAMA7G5 Claudiu Beznea
2020-07-24 9:21 ` Stephen Boyd
2020-07-22 7:38 ` [PATCH v2 13/18] clk: at91: clk-peripheral: add support for changeable parent rate Claudiu Beznea
2020-07-24 9:21 ` Stephen Boyd
2020-07-22 7:38 ` [PATCH v2 14/18] clk: at91: clk-programmable: add mux_table option Claudiu Beznea
2020-07-24 9:21 ` Stephen Boyd
2020-07-22 7:38 ` [PATCH v2 15/18] clk: at91: add macro for pll ids mask Claudiu Beznea
2020-07-24 9:21 ` Stephen Boyd
2020-07-22 7:38 ` [PATCH v2 16/18] clk: at91: clk-sam9x60-pll: re-factor to support plls with multiple outputs Claudiu Beznea
2020-07-24 9:22 ` Stephen Boyd
2020-07-24 9:22 ` Stephen Boyd
2020-07-22 7:38 ` [PATCH v2 17/18] clk: at91: clk-utmi: add utmi support for sama7g5 Claudiu Beznea
2020-07-24 9:22 ` Stephen Boyd
2020-07-22 7:38 ` [PATCH v2 18/18] clk: at91: sama7g5: add clock " Claudiu Beznea
2020-07-24 9:22 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1595403506-8209-5-git-send-email-claudiu.beznea@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=mturquette@baylibre.com \
--cc=nicolas.ferre@microchip.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).