From: Dinh Nguyen <dinguyen@kernel.org>
To: linux-clk@vger.kernel.org
Cc: mturquette@baylibre.com, sboyd@kernel.org, linux-stable@vger.kernel.org
Subject: Re: [PATCH RESEND 1/2] clk: socfpga: stratix10: fix naming convention for the fixed-clocks
Date: Mon, 14 Jan 2019 09:45:57 -0600 [thread overview]
Message-ID: <178e0501-5e75-20b0-4650-08b1d0e80f3e@kernel.org> (raw)
In-Reply-To: <20190102145932.26423-1-dinguyen@kernel.org>
Hi Stephen,
You've already applied 2/2 of this patch series[1] to clk-fixes, but can
you also apply this patch as well?
Thanks,
Dinh
[1] https://www.spinics.net/lists/linux-clk/msg33940.html
On 1/2/19 8:59 AM, Dinh Nguyen wrote:
> The fixed clocks in the DTS file have a hyphen, but the clock driver has
> the fixed clocks using underbar. Thus the clock driver cannot detect the
> other fixed clocks correctly. Change the fixed clock names to a hyphen.
>
> Fixes: 07afb8db7340 ("clk: socfpga: stratix10: add clock driver for
> Stratix10 platform")
> Cc: linux-stable@vger.kernel.org
> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
> ---
> drivers/clk/socfpga/clk-s10.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/clk/socfpga/clk-s10.c b/drivers/clk/socfpga/clk-s10.c
> index 5b238fc314ac..8281dfbf38c2 100644
> --- a/drivers/clk/socfpga/clk-s10.c
> +++ b/drivers/clk/socfpga/clk-s10.c
> @@ -12,17 +12,17 @@
>
> #include "stratix10-clk.h"
>
> -static const char * const pll_mux[] = { "osc1", "cb_intosc_hs_div2_clk",
> - "f2s_free_clk",};
> +static const char * const pll_mux[] = { "osc1", "cb-intosc-hs-div2-clk",
> + "f2s-free-clk",};
> static const char * const cntr_mux[] = { "main_pll", "periph_pll",
> - "osc1", "cb_intosc_hs_div2_clk",
> - "f2s_free_clk"};
> -static const char * const boot_mux[] = { "osc1", "cb_intosc_hs_div2_clk",};
> + "osc1", "cb-intosc-hs-div2-clk",
> + "f2s-free-clk"};
> +static const char * const boot_mux[] = { "osc1", "cb-intosc-hs-div2-clk",};
>
> static const char * const noc_free_mux[] = {"main_noc_base_clk",
> "peri_noc_base_clk",
> - "osc1", "cb_intosc_hs_div2_clk",
> - "f2s_free_clk"};
> + "osc1", "cb-intosc-hs-div2-clk",
> + "f2s-free-clk"};
>
> static const char * const emaca_free_mux[] = {"peri_emaca_clk", "boot_clk"};
> static const char * const emacb_free_mux[] = {"peri_emacb_clk", "boot_clk"};
> @@ -33,14 +33,14 @@ static const char * const s2f_usr1_free_mux[] = {"peri_s2f_usr1_clk", "boot_clk"
> static const char * const psi_ref_free_mux[] = {"peri_psi_ref_clk", "boot_clk"};
> static const char * const mpu_mux[] = { "mpu_free_clk", "boot_clk",};
>
> -static const char * const s2f_usr0_mux[] = {"f2s_free_clk", "boot_clk"};
> +static const char * const s2f_usr0_mux[] = {"f2s-free-clk", "boot_clk"};
> static const char * const emac_mux[] = {"emaca_free_clk", "emacb_free_clk"};
> static const char * const noc_mux[] = {"noc_free_clk", "boot_clk"};
>
> static const char * const mpu_free_mux[] = {"main_mpu_base_clk",
> "peri_mpu_base_clk",
> - "osc1", "cb_intosc_hs_div2_clk",
> - "f2s_free_clk"};
> + "osc1", "cb-intosc-hs-div2-clk",
> + "f2s-free-clk"};
>
> /* clocks in AO (always on) controller */
> static const struct stratix10_pll_clock s10_pll_clks[] = {
>
next prev parent reply other threads:[~2019-01-14 15:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 14:59 [PATCH RESEND 1/2] clk: socfpga: stratix10: fix naming convention for the fixed-clocks Dinh Nguyen
2019-01-02 14:59 ` [PATCH RESEND 2/2] clk: socfpga: stratix10: fix rate calculation for pll clocks Dinh Nguyen
2019-01-14 15:45 ` Dinh Nguyen [this message]
2019-01-15 20:58 ` [PATCH RESEND 1/2] clk: socfpga: stratix10: fix naming convention for the fixed-clocks Stephen Boyd
2019-01-15 20:58 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178e0501-5e75-20b0-4650-08b1d0e80f3e@kernel.org \
--to=dinguyen@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-stable@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).