From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, andy.gross@linaro.org,
david.brown@linaro.org, sboyd@kernel.org, will.deacon@arm.com,
mturquette@baylibre.com, jassisinghbrar@gmail.com,
vkoul@kernel.org, niklas.cassel@linaro.org, sibis@codeaurora.org,
georgi.djakov@linaro.org, arnd@arndb.de,
horms+renesas@verge.net.au, heiko@sntech.de,
enric.balletbo@collabora.com, jagan@amarulasolutions.com,
olof@lixom.net, amit.kucheria@linaro.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH 04/13] dt-bindings: mailbox: qcom: Add clock-name optional property
Date: Wed, 16 Jan 2019 22:44:11 -0800 [thread overview]
Message-ID: <20190117064411.GK25498@builder> (raw)
In-Reply-To: <1545039990-19984-5-git-send-email-jorge.ramirez-ortiz@linaro.org>
On Mon 17 Dec 01:46 PST 2018, Jorge Ramirez-Ortiz wrote:
> When the APCS clock is registered (platform dependent), it retrieves
> its parent names from hardcoded values in the driver.
>
> The following commit allows the DT node to provide such clock names to
> the platform data based clock driver therefore avoiding having to
> explicitly embed those names in the clock driver source code.
>
> Co-developed-by: Niklas Cassel <niklas.cassel@linaro.org>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
> ---
> .../bindings/mailbox/qcom,apcs-kpss-global.txt | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt
> index 1232fc9..f252439 100644
> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt
> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt
> @@ -23,6 +23,10 @@ platforms.
> Value type: <phandle>
> Definition: phandle to the input PLL, which feeds the APCS mux/divider
>
> + Usage: required if #clock-names property is present
> + Value type: <phandle array>
> + Definition: phandles to the two parent clocks of the clock driver.
I presume you meant to replace the existing definition of "clocks"?
I think the purpose of "required if #clock-cells" comes from that
meaning that it represents a clock-controller if #clock-cells is
specified, in which case it requires the upstream clock(s).
Regards,
Bjorn
> +
> - #mbox-cells:
> Usage: required
> Value type: <u32>
> @@ -33,6 +37,12 @@ platforms.
> Value type: <u32>
> Definition: as described in clock.txt, must be 0
>
> +- clock-names:
> + Usage: required if the platform data based clock driver needs to
> + retrieve the parent clock names from device tree.
> + This will requires two mandatory clocks to be defined.
> + Value type: <string-array>
> + Definition: must be "aux" and "pll"
>
> = EXAMPLE
> The following example describes the APCS HMSS found in MSM8996 and part of the
> @@ -65,3 +75,14 @@ Below is another example of the APCS binding on MSM8916 platforms:
> clocks = <&a53pll>;
> #clock-cells = <0>;
> };
> +
> +Below is another example of the APCS binding on QCS404 platforms:
> +
> + apcs_glb: mailbox@b011000 {
> + compatible = "qcom,qcs404-apcs-apps-global", "syscon";
> + reg = <0x0b011000 0x1000>;
> + #mbox-cells = <1>;
> + clocks = <&gcc GCC_GPLL0_AO_OUT_MAIN>, <&apcs_hfpll>;
> + clock-names = "aux", "pll";
> + #clock-cells = <0>;
> + };
> --
> 2.7.4
>
next prev parent reply other threads:[~2019-01-17 6:44 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 9:46 [PATCH 00/13] Support CPU frequency scaling on QCS404 Jorge Ramirez-Ortiz
2018-12-17 9:46 ` [PATCH 01/13] clk: qcom: gcc: limit GPLL0_AO_OUT operating frequency Jorge Ramirez-Ortiz
2018-12-21 11:19 ` Taniya Das
2018-12-21 12:36 ` Jorge Ramirez
2018-12-21 17:58 ` Taniya Das
2018-12-21 19:28 ` Bjorn Andersson
2018-12-21 19:45 ` Jorge Ramirez
2018-12-21 21:40 ` Stephen Boyd
2018-12-21 21:45 ` Jorge Ramirez
2018-12-21 21:51 ` Stephen Boyd
2018-12-17 9:46 ` [PATCH 02/13] mbox: qcom: add APCS child device for QCS404 Jorge Ramirez-Ortiz
2019-01-17 6:25 ` Bjorn Andersson
2018-12-17 9:46 ` [PATCH 03/13] mbox: qcom: replace integer with valid macro Jorge Ramirez-Ortiz
2019-01-17 6:25 ` Bjorn Andersson
2018-12-17 9:46 ` [PATCH 04/13] dt-bindings: mailbox: qcom: Add clock-name optional property Jorge Ramirez-Ortiz
2018-12-20 21:37 ` Rob Herring
2019-01-17 6:44 ` Bjorn Andersson [this message]
2019-01-28 16:57 ` Jorge Ramirez
2019-01-28 17:46 ` Jorge Ramirez
2018-12-17 9:46 ` [PATCH 05/13] clk: qcom: apcs-msm8916: get parent clock names from DT Jorge Ramirez-Ortiz
2018-12-17 23:37 ` Stephen Boyd
2018-12-18 8:37 ` Jorge Ramirez
2018-12-18 14:35 ` Niklas Cassel
2018-12-26 9:20 ` Jorge Ramirez
2018-12-28 22:28 ` Stephen Boyd
2018-12-31 8:42 ` Jorge Ramirez
2019-01-17 6:54 ` Bjorn Andersson
2018-12-28 22:27 ` Stephen Boyd
2018-12-17 9:46 ` [PATCH 06/13] clk: qcom: hfpll: " Jorge Ramirez-Ortiz
2019-01-17 6:27 ` Bjorn Andersson
2018-12-17 9:46 ` [PATCH 07/13] clk: qcom: hfpll: register as clock provider Jorge Ramirez-Ortiz
2019-01-17 6:28 ` Bjorn Andersson
2018-12-17 9:46 ` [PATCH 08/13] clk: qcom: hfpll: CLK_IGNORE_UNUSED Jorge Ramirez-Ortiz
2019-01-17 6:33 ` Bjorn Andersson
2019-01-17 8:38 ` Jorge Ramirez
2019-01-17 10:08 ` Viresh Kumar
2019-01-17 10:46 ` Jorge Ramirez
2019-01-22 18:47 ` Stephen Boyd
2019-01-22 19:35 ` Jorge Ramirez
2018-12-17 9:46 ` [PATCH 09/13] arm64: dts: qcom: qcs404: Add OPP table Jorge Ramirez-Ortiz
2019-01-17 6:35 ` Bjorn Andersson
2018-12-17 9:46 ` [PATCH 10/13] arm64: dts: qcom: qcs404: Add HFPLL node Jorge Ramirez-Ortiz
2018-12-17 19:39 ` Stephen Boyd
2019-01-17 6:38 ` Bjorn Andersson
2019-01-22 18:49 ` Stephen Boyd
2018-12-17 9:46 ` [PATCH 11/13] arm64: dts: qcom: qcs404: Add the clocks for APCS mux/divider Jorge Ramirez-Ortiz
2019-01-17 6:35 ` Bjorn Andersson
2018-12-17 9:46 ` [PATCH 12/13] arm64: dts: qcom: qcs404: Add cpufreq support Jorge Ramirez-Ortiz
2019-01-17 6:36 ` Bjorn Andersson
2018-12-17 9:46 ` [PATCH 13/13] arm64: defconfig: Enable HFPLL Jorge Ramirez-Ortiz
2019-01-17 6:36 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190117064411.GK25498@builder \
--to=bjorn.andersson@linaro.org \
--cc=amit.kucheria@linaro.org \
--cc=andy.gross@linaro.org \
--cc=arnd@arndb.de \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=georgi.djakov@linaro.org \
--cc=heiko@sntech.de \
--cc=horms+renesas@verge.net.au \
--cc=jagan@amarulasolutions.com \
--cc=jassisinghbrar@gmail.com \
--cc=jorge.ramirez-ortiz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=niklas.cassel@linaro.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sibis@codeaurora.org \
--cc=vkoul@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).