From: Simon Horman <horms@verge.net.au>
To: Biju Das <biju.das@bp.renesas.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Subject: Re: [PATCH/RFT v2 6/6] clk: renesas: r8a7745: Implement Z2 as a variable clock
Date: Wed, 30 Jan 2019 11:11:49 +0100 [thread overview]
Message-ID: <20190130101148.xjtulgx2zhx3n2e5@verge.net.au> (raw)
In-Reply-To: <OSBPR01MB2103B656FF9DCBCC2F48E9A3B8900@OSBPR01MB2103.jpnprd01.prod.outlook.com>
On Wed, Jan 30, 2019 at 09:46:35AM +0000, Biju Das wrote:
> Hi Simon,
>
> Thanks for the patch
>
> > Subject: [PATCH/RFT v2 6/6] clk: renesas: r8a7745: Implement Z2 as a variable
> > clock
> >
> > On the RZ/G2E (r8a7745) SoC the Z2 clock is not a fixed clock.
> > Rather it is a clock with:
>
> RZ/G2E SoC id is r8a774c0.
Sorry about that, somehow I got confused.
> > * A parent of CLK_PLL0 running at 4.8GHz
> > * A fixed divider of 4
> > * A variable divider controlled by the Z2FC bits of the RFQCRC register
> >
> > This can be described using the DEF_GEN3_Z with a clock type of
> > CLK_TYPE_GEN3_Z2.
> >
> > This change is made with reference to the User's Manual v0.61.
> >
> > Fixes: 9127d54bb894 ("clk: renesas: cpg-mssr: Add R8A7745 support")
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> > drivers/clk/renesas/r8a7745-cpg-mssr.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/clk/renesas/r8a7745-cpg-mssr.c
> > b/drivers/clk/renesas/r8a7745-cpg-mssr.c
> > index 493874e5ebee..f2ea72d9d663 100644
> > --- a/drivers/clk/renesas/r8a7745-cpg-mssr.c
> > +++ b/drivers/clk/renesas/r8a7745-cpg-mssr.c
> > @@ -53,7 +53,7 @@ static const struct cpg_core_clk r8a7745_core_clks[]
> > __initconst = {
> > DEF_BASE("qspi", R8A7745_CLK_QSPI, CLK_TYPE_GEN2_QSPI,
> > CLK_PLL1_DIV2),
> > DEF_BASE("rcan", R8A7745_CLK_RCAN, CLK_TYPE_GEN2_RCAN,
> > CLK_USB_EXTAL),
> >
> > -DEF_FIXED("z2", R8A7745_CLK_Z2,CLK_PLL0, 1, 1),
> > +DEF_GEN3_Z("z2", R8A77990_CLK_Z2, CLK_TYPE_GEN3_Z2,
> > CLK_PLL0, 4),
>
> Looks like wrong file name. it is supposed to be r8a774c0-cpg-mssr.c
>
> > DEF_FIXED("zg", R8A7745_CLK_ZG,CLK_PLL1, 6, 1),
> > DEF_FIXED("zx", R8A7745_CLK_ZX,CLK_PLL1, 3, 1),
> > DEF_FIXED("zs", R8A7745_CLK_ZS,CLK_PLL1, 6, 1),
> > --
> > 2.11.0
>
>
>
>
> Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
>
next prev parent reply other threads:[~2019-01-30 10:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 9:40 [PATCH v2 0/6] clk: renesas: r8a77990: Add Z2 clock Simon Horman
2019-01-30 9:40 ` [PATCH v2 1/6] clk: renesas: rcar-gen3: Parameterise Z and Z2 clock fixed divisor Simon Horman
2019-01-30 9:40 ` [PATCH v2 2/6] clk: renesas: rcar-gen3: Support r8a77990 Z2 clock divider Simon Horman
2019-01-30 9:40 ` [PATCH v2 3/6] clk: renesas: rcar-gen3: Support Z and Z2 clocks with high frequency parents Simon Horman
2019-01-30 9:40 ` [PATCH v2 4/6] clk: renesas: r8a77990: Add Z2 clock Simon Horman
2019-01-30 9:40 ` [PATCH/RFT v2 5/6] clk: renesas: rcar-gen3: Support r8a7745 Z2 clock divider Simon Horman
2019-01-30 9:43 ` Biju Das
2019-01-30 10:10 ` Simon Horman
2019-01-30 18:51 ` Fabrizio Castro
2019-01-30 9:40 ` [PATCH/RFT v2 6/6] clk: renesas: r8a7745: Implement Z2 as a variable clock Simon Horman
2019-01-30 9:46 ` Biju Das
2019-01-30 10:11 ` Simon Horman [this message]
2019-01-30 18:43 ` Fabrizio Castro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130101148.xjtulgx2zhx3n2e5@verge.net.au \
--to=horms@verge.net.au \
--cc=biju.das@bp.renesas.com \
--cc=fabrizio.castro@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-clk@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).