From: Rob Herring <robh@kernel.org>
To: Johan Jonker <jbx6244@gmail.com>
Cc: heiko@sntech.de, hjc@rock-chips.com, airlied@linux.ie,
mark.rutland@arm.com, mturquette@baylibre.com, sboyd@kernel.org,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: display: rockchip: add document for rk3066 hdmi
Date: Mon, 25 Feb 2019 10:59:23 -0600 [thread overview]
Message-ID: <20190225165923.GA2578@bogus> (raw)
In-Reply-To: <20190201123235.1693-1-jbx6244@gmail.com>
On Fri, Feb 01, 2019 at 01:32:35PM +0100, Johan Jonker wrote:
> This patch adds a binding that describes the HDMI controller for
> rk3066.
This is not using the DW block like other Rockchip SoCs (IIRC)?
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
> .../display/rockchip/rk3066_hdmi-rockchip.txt | 60 ++++++++++++++++++++++
Using the compatible string plus '.txt' is the preferred naming.
> 1 file changed, 60 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/rockchip/rk3066_hdmi-rockchip.txt
>
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rk3066_hdmi-rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/rk3066_hdmi-rockchip.txt
> new file mode 100644
> index 000000000..6a8f3754f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/rockchip/rk3066_hdmi-rockchip.txt
> @@ -0,0 +1,60 @@
> +Rockchip specific extensions for rk3066 HDMI
> +============================================
> +
> +Required properties:
> +- compatible:
> + "rockchip,rk3066-hdmi";
> +- reg:
> + Physical base address and length of the controller's registers.
> +- clocks, clock-names:
> + Phandle to HDMI controller clock, name should be "hclk".
> +- interrupts:
> + HDMI interrupt number.
> +- power-domains:
> + Phandle to the RK3066_PD_VIO power domain.
> +- rockchip,grf:
> + This soc uses GRF regs to switch the HDMI TX input between vop0 and vop1.
> +- ports:
> + Contains one port node with two endpoints, numbered 0 and 1,
> + connected respectively to vop0 and vop1.
You should have an output port to an hdmi-connector node (or bridge) as
well.
> +- pinctrl-0, pinctrl-name:
> + Switch the iomux for the HPD/I2C pins to HDMI function.
> +
> +Example:
> + hdmi: hdmi@10116000 {
> + compatible = "rockchip,rk3066-hdmi";
> + reg = <0x10116000 0x2000>;
> + interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru HCLK_HDMI>;
> + clock-names = "hclk";
> + power-domains = <&power RK3066_PD_VIO>;
> + rockchip,grf = <&grf>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&hdmii2c_xfer>, <&hdmi_hpd>;
> + status = "disabled";
Don't show status in examples.
> +
> + hdmi_in: port {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + hdmi_in_vop0: endpoint@0 {
> + reg = <0>;
> + remote-endpoint = <&vop0_out_hdmi>;
> + };
> + hdmi_in_vop1: endpoint@1 {
> + reg = <1>;
> + remote-endpoint = <&vop1_out_hdmi>;
> + };
> + };
> + };
> +
> +&pinctrl {
> + hdmi {
> + hdmi_hpd: hdmi-hpd {
> + rockchip,pins = <0 RK_PA0 1 &pcfg_pull_default>;
> + };
> + hdmii2c_xfer: hdmii2c-xfer {
> + rockchip,pins = <0 RK_PA1 1 &pcfg_pull_none>,
> + <0 RK_PA2 1 &pcfg_pull_none>;
> + };
> + };
> +};
> --
> 2.11.0
>
next prev parent reply other threads:[~2019-02-25 16:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-29 13:33 [PATCH v2 0/7] Enable rk3066 VOP and HDMI for MK808 Johan Jonker
2018-12-29 13:33 ` [PATCH v2 1/7] ARM: dts: rockchip: rk3066: add HCLK_HDMI to pmu node Johan Jonker
2018-12-30 14:03 ` Heiko Stuebner
2018-12-29 13:33 ` [PATCH v2 2/7] clk: rockchip: rk3188: add CLK_SET_RATE_PARENT for lcdc dclk Johan Jonker
2018-12-30 17:05 ` Heiko Stuebner
2018-12-29 13:33 ` [PATCH v2 3/7] drm: rockchip: vop: add rk3066 vop definitions Johan Jonker
2018-12-30 17:22 ` Heiko Stuebner
2019-01-11 14:54 ` Rob Herring
2019-01-12 18:53 ` Heiko Stuebner
2018-12-29 13:33 ` [PATCH v2 4/7] drm: rockchip: introduce rk3066 hdmi Johan Jonker
2019-02-01 14:25 ` Johan Jonker
2018-12-29 13:33 ` [PATCH v2 5/7] ARM: dts: rockchip: add rk3066 vop display nodes Johan Jonker
2019-01-12 19:24 ` Heiko Stuebner
2018-12-29 13:33 ` [PATCH v2 6/7] ARM: dts: rockchip: add rk3066 hdmi nodes Johan Jonker
2018-12-29 13:33 ` [PATCH v2 7/7] ARM: dts: rockchip: rk3066a-mk808: enable vop0 and " Johan Jonker
2019-02-01 12:32 ` [PATCH] dt-bindings: display: rockchip: add document for rk3066 hdmi Johan Jonker
2019-02-25 16:59 ` Rob Herring [this message]
2019-02-27 18:04 ` Johan Jonker
2019-02-27 19:06 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225165923.GA2578@bogus \
--to=robh@kernel.org \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=jbx6244@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).