Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes

From: Simon Horman <horms@verge.net.au>
To: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Wolfgang Grandegger <wg@grandegger.com>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Magnus Damm <magnus.damm@gmail.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Biju Das <biju.das@bp.renesas.com>,
	"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org" 
	<linux-renesas-soc@vger.kernel.org>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>
Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
Date: Tue, 19 Mar 2019 12:55:09 +0100	[thread overview]
Message-ID: <20190319115509.pnwcqma472xnjeng@verge.net.au> (raw)
In-Reply-To: <TY1PR01MB1770A2ACD8287D3675270A0AC0400@TY1PR01MB1770.jpnprd01.prod.outlook.com>

On Tue, Mar 19, 2019 at 11:22:35AM +0000, Fabrizio Castro wrote:
> Hello Simon,
> 
> > From: devicetree-owner@vger.kernel.org <devicetree-owner@vger.kernel.org> On Behalf Of Fabrizio Castro
> > Sent: 28 January 2019 14:49
> > Subject: RE: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > 
> > > From: Simon Horman <horms@verge.net.au>
> > > Sent: 28 January 2019 13:01
> > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > >
> > > On Fri, Jan 25, 2019 at 11:33:41AM +0000, Fabrizio Castro wrote:
> > > > Hello Simon,
> > > >
> > > > Thank you for your feedback!
> > > >
> > > > > From: Simon Horman <horms@verge.net.au>
> > > > > Sent: 24 January 2019 10:01
> > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > > > >
> > > > > On Wed, Jan 23, 2019 at 12:18:45PM +0000, Fabrizio Castro wrote:
> > > > > > Hello Geert,
> > > > > >
> > > > > > Thank you for your feedback!
> > > > > >
> > > > > > > From: Geert Uytterhoeven <geert@linux-m68k.org>
> > > > > > > Sent: 23 January 2019 12:08
> > > > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > > > > > >
> > > > > > > Hi Fabrizio,
> > > > > > >
> > > > > > > On Wed, Jan 23, 2019 at 1:01 PM Fabrizio Castro
> > > > > > > <fabrizio.castro@bp.renesas.com> wrote:
> > > > > > > > > From: Simon Horman <horms@verge.net.au>
> > > > > > > > > Sent: 23 January 2019 11:38
> > > > > > > > > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes
> > > > > > > > >
> > > > > > > > > On Wed, Jan 23, 2019 at 10:51:23AM +0100, Simon Horman wrote:
> > > > > > > > > > On Fri, Jan 18, 2019 at 01:13:53PM +0100, Simon Horman wrote:
> > > > > > > > > > > On Thu, Jan 17, 2019 at 02:54:15PM +0000, Fabrizio Castro wrote:
> > > > > > > > > > > > According to the latest information, clkp2 is available on RZ/G2.
> > > > > > > > > > > > Modify CAN0 and CAN1 nodes accordingly.
> > > > > > > > > > > >
> > > > > > > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > > > > > > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> > > > > > >
> > > > > > > > > > Thanks again, applied for v5.1.
> > > > > > > > >
> > > > > > > > > Sorry, I was a little hasty there.
> > > > > > > > >
> > > > > > > > > This patch depends on the presence of R8A774A1_CLK_CANFD which
> > > > > > > > > (rightly) is added in a different patch in this series which is to
> > > > > > > > > go upstream via a different tree.
> > > > > > > > >
> > > > > > > > > I have dropped this patch for now. I think there are two solution to this
> > > > > > > > > problem.
> > > > > > > > >
> > > > > > > > > 1. Provide a version of this patch which uses a numeric index instead of
> > > > > > > > >    R8A774A1_CLK_CANFD. And then, once R8A774A1_CLK_CANFD is present in an
> > > > > > > > >    RC release provide a patch to switch to using R8A774A1_CLK_CANFD.
> > > > > > > > >
> > > > > > > > > 2. Defer this patch until R8A774A1_CLK_CANFD is present in an RC release.
> > > > > > > >
> > > > > > > > Yeah, my personal preference is solution 2.
> > > > > > >
> > > > > > > Note that solution 2 will probably defer the DT patch to v5.2.
> > > > > >
> > > > > > Yeah, my understanding is that even if we chose solution 1 we would still
> > > > > > need to be waiting for v5.2 for the patch to switch to using
> > > > > > R8A774A1_CLK_CANFD to appear in a rc, therefore I think solution 2 is
> > > > > > fine.
> > > > >
> > > > > Your understanding is the same as mine.
> > > > >
> > > > > I do seem some slight value in option 1 in terms of getting the change,
> > > > > less the minor issue of using an index rather than a symbol, upstream
> > > > > earlier. But I do not feel strongly about this.
> > > > >
> > > > > I am marking this patch as deferred. Please repost or otherwise ping me
> > > > > when you would like to revisit this topic.
> > > >
> > > > Thank you. Will do.
> > >
> > > Thanks.
> > >
> > > I believe "[10/11] arm64: dts: renesas: r8a774c0: Add clkp2 clock to CAN nodes"
> > > falls into the same category. I have marked it as deferred accordingly.
> > 
> > Ok, thank you Simon
> 
> My understanding is that this patch can now be taken, and it still applies neatly.

Thanks, I agree this should be ready now.
I've applied it for v5.2.