From: Abel Vesa <abel.vesa@nxp.com>
To: Leonard Crestez <leonard.crestez@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>,
Daniel Baluta <daniel.baluta@nxp.com>,
Dong Aisheng <aisheng.dong@nxp.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Jacky Bai <ping.bai@nxp.com>,
kernel@pengutronix.de, linux-imx@nxp.com,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: imx8mm: Fix boot hang at clk init
Date: Wed, 24 Jul 2019 23:28:43 +0300 [thread overview]
Message-ID: <20190724202843.o66jwjnid32vyx62@fsr-ub1664-175> (raw)
In-Reply-To: <62d9c73aafcdc171edcd9e03fa81f451a42d5227.1563995813.git.leonard.crestez@nxp.com>
On 19-07-24 22:17:15, Leonard Crestez wrote:
> The assigned-clock-rates property is incorrect (shorter than
> assigned-clocks) and boot hangs becuause incorrect rates are assigned.
>
> Fix by inserting another <0>
>
> Fixes: df1703896a17 ("arm64: dts: imx8mm: Init rates and parents configs for clocks")
>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> ---
> Found in next-20190724 because that's when df1703896a17 was included.
> Perhaps this should be squashed?
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index c9a7c0054c5c..8737f833cf9c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -461,10 +461,11 @@
> <&clk IMX8MM_SYS_PLL3>,
> <&clk IMX8MM_VIDEO_PLL1>;
> assigned-clock-parents = <&clk IMX8MM_SYS_PLL3_OUT>,
> <&clk IMX8MM_SYS_PLL1_800M>;
> assigned-clock-rates = <0>,
> + <0>,
In our tree we have this in the clock provider:
clk_set_rate(clks[IMX8MM_CLK_AUDIO_AHB], 400000000);
clk_set_rate(clks[IMX8MM_CLK_IPG_AUDIO_ROOT], 400000000);
So I guess instead of the newly added <0> you'll have to put <400000000>
which would be the rate for IMX8MM_CLK_IPG_AUDIO_ROOT.
> <400000000>,
> <750000000>,
> <594000000>;
> };
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-07-24 20:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 19:17 [PATCH] arm64: dts: imx8mm: Fix boot hang at clk init Leonard Crestez
2019-07-24 20:28 ` Abel Vesa [this message]
2019-07-25 9:50 Leonard Crestez
2019-07-26 8:44 ` Abel Vesa
2019-08-03 10:29 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724202843.o66jwjnid32vyx62@fsr-ub1664-175 \
--to=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=daniel.baluta@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=mturquette@baylibre.com \
--cc=ping.bai@nxp.com \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).