From: Stephen Boyd <sboyd@kernel.org>
To: YueHaibing <yuehaibing@huawei.com>,
allison@lohutok.net, gregkh@linuxfoundation.org,
mturquette@baylibre.com,
Gabriel FERNANDEZ <gabriel.fernandez@st.com>
Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
YueHaibing <yuehaibing@huawei.com>
Subject: Re: [PATCH -next] clk: st: clkgen-pll: remove unused variable 'st_pll3200c32_407_a0'
Date: Fri, 16 Aug 2019 10:36:12 -0700 [thread overview]
Message-ID: <20190816173613.491082086C@mail.kernel.org> (raw)
In-Reply-To: <20190816135523.73520-1-yuehaibing@huawei.com>
Quoting YueHaibing (2019-08-16 06:55:23)
> drivers/clk/st/clkgen-pll.c:64:37: warning:
> st_pll3200c32_407_a0 defined but not used [-Wunused-const-variable=]
>
> It is never used, so can be removed.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
Adding Gabriel, please ack/review.
> drivers/clk/st/clkgen-pll.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/drivers/clk/st/clkgen-pll.c b/drivers/clk/st/clkgen-pll.c
> index d8a688b..c3952f2 100644
> --- a/drivers/clk/st/clkgen-pll.c
> +++ b/drivers/clk/st/clkgen-pll.c
> @@ -61,19 +61,6 @@ static const struct clk_ops stm_pll3200c32_ops;
> static const struct clk_ops stm_pll3200c32_a9_ops;
> static const struct clk_ops stm_pll4600c28_ops;
>
> -static const struct clkgen_pll_data st_pll3200c32_407_a0 = {
> - /* 407 A0 */
> - .pdn_status = CLKGEN_FIELD(0x2a0, 0x1, 8),
> - .pdn_ctrl = CLKGEN_FIELD(0x2a0, 0x1, 8),
> - .locked_status = CLKGEN_FIELD(0x2a0, 0x1, 24),
> - .ndiv = CLKGEN_FIELD(0x2a4, C32_NDIV_MASK, 16),
> - .idf = CLKGEN_FIELD(0x2a4, C32_IDF_MASK, 0x0),
> - .num_odfs = 1,
> - .odf = { CLKGEN_FIELD(0x2b4, C32_ODF_MASK, 0) },
> - .odf_gate = { CLKGEN_FIELD(0x2b4, 0x1, 6) },
> - .ops = &stm_pll3200c32_ops,
> -};
> -
> static const struct clkgen_pll_data st_pll3200c32_cx_0 = {
> /* 407 C0 PLL0 */
> .pdn_status = CLKGEN_FIELD(0x2a0, 0x1, 8),
next prev parent reply other threads:[~2019-08-16 17:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 13:55 [PATCH -next] clk: st: clkgen-pll: remove unused variable 'st_pll3200c32_407_a0' YueHaibing
2019-08-16 17:36 ` Stephen Boyd [this message]
2019-08-19 5:29 ` Gabriel FERNANDEZ
2019-09-06 17:27 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190816173613.491082086C@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=allison@lohutok.net \
--cc=gabriel.fernandez@st.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).