From: Vinod Koul <vkoul@kernel.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, Taniya Das <tdas@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: qcom: gcc: Add missing clocks in SM8150
Date: Mon, 21 Oct 2019 16:24:35 +0530 [thread overview]
Message-ID: <20191021105435.GE2654@vkoul-mobl> (raw)
In-Reply-To: <20191017174820.F08422089C@mail.kernel.org>
On 17-10-19, 10:48, Stephen Boyd wrote:
> > > > diff --git a/drivers/clk/qcom/gcc-sm8150.c b/drivers/clk/qcom/gcc-sm8150.c
> > > > index 12ca2d14797f..13d4d14a5744 100644
> > > > --- a/drivers/clk/qcom/gcc-sm8150.c
> > > > +++ b/drivers/clk/qcom/gcc-sm8150.c
> > > > @@ -1616,6 +1616,38 @@ static struct clk_branch gcc_gpu_cfg_ahb_clk = {
> > > > },
> > > > };
> > > >
> > > > +static struct clk_branch gcc_gpu_gpll0_clk_src = {
> > > > + .halt_check = BRANCH_HALT_SKIP,
> > >
> > > Why skip?
> >
> > I will explore and add comments for that
> >
> > > > + .clkr = {
> > > > + .enable_reg = 0x52004,
> > > > + .enable_mask = BIT(15),
> > > > + .hw.init = &(struct clk_init_data){
> > > > + .name = "gcc_gpu_gpll0_clk_src",
> > > > + .parent_hws = (const struct clk_hw *[]){
> > > > + &gpll0.clkr.hw },
> > > > + .num_parents = 1,
> > > > + .flags = CLK_SET_RATE_PARENT,
> > > > + .ops = &clk_branch2_ops,
> > > > + },
> > > > + },
> > > > +};
> > > > +
> > > > +static struct clk_branch gcc_gpu_gpll0_div_clk_src = {
> > > > + .halt_check = BRANCH_HALT_SKIP,
> > >
> > > Why skip?
> > >
>
> Any answer from the explorations?
Yeah so asking around the answer I got is that these are external
clocks and we need cannot rely on CLK_OFF bit for these clocks
Thanks
--
~Vinod
next prev parent reply other threads:[~2019-10-21 10:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 9:16 [PATCH] clk: qcom: gcc: Add missing clocks in SM8150 Vinod Koul
2019-09-17 16:09 ` Stephen Boyd
2019-10-16 12:23 ` Vinod Koul
2019-10-17 17:48 ` Stephen Boyd
2019-10-21 10:54 ` Vinod Koul [this message]
2019-10-27 21:25 ` Stephen Boyd
2019-10-28 7:23 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021105435.GE2654@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).