From: Rob Herring <robh@kernel.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: mturquette@baylibre.com, sboyd@kernel.org, mark.rutland@arm.com,
geert+renesas@glider.be, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 2/4] dt-bindings: clock: renesas: rcar-usb2-clock-sel: Add power-domains and resets properties
Date: Wed, 30 Oct 2019 09:34:10 -0500 [thread overview]
Message-ID: <20191030143410.GA11171@bogus> (raw)
In-Reply-To: <1572242850-9073-3-git-send-email-yoshihiro.shimoda.uh@renesas.com>
On Mon, Oct 28, 2019 at 03:07:28PM +0900, Yoshihiro Shimoda wrote:
> This patch adds missing required properties of power-domains and resets.
> Fortunately, no one has this device node for now, so that we don't
> need to think of backward compatibility.
>
> Fixes: 311accb64570 ("clk: renesas: rcar-usb2-clock-sel: Add R-Car USB 2.0 clock selector PHY")
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> .../devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt b/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt
> index 5c1903f..bad876f 100644
> --- a/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt
> +++ b/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt
> @@ -43,6 +43,9 @@ Required properties:
> - The USB_EXTAL clock pin must be "usb_extal"
> - The USB_XTAL clock pin must be "usb_xtal"
> - #clock-cells: Must be 0
> +- power-domains: A phandle and symbolic PM domain specifier.
> + See power/renesas,rcar-sysc.txt.
> +- resets: A list of phandles and specifier pairs.
>
> Example (R-Car H3):
>
> @@ -54,4 +57,6 @@ Example (R-Car H3):
> <&usb_extal>, <&usb_xtal>;
> clock-names = "ehci_ohci", "hs-usb-if", "usb_extal", "usb_xtal";
> #clock-cells = <0>;
> + power-domains = <&sysc R8A7795_PD_ALWAYS_ON>>;
Typo in '>>'
With that,
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2019-10-30 14:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 6:07 [PATCH v2 0/4] clk: renesas: rcar-usb2-clock-sel: Fix clks/resets handling Yoshihiro Shimoda
2019-10-28 6:07 ` [PATCH v2 1/4] dt-bindings: clock: renesas: rcar-usb2-clock-sel: Fix clock[-name]s properties Yoshihiro Shimoda
2019-10-30 14:33 ` Rob Herring
2019-10-28 6:07 ` [PATCH v2 2/4] dt-bindings: clock: renesas: rcar-usb2-clock-sel: Add power-domains and resets properties Yoshihiro Shimoda
2019-10-30 14:34 ` Rob Herring [this message]
2019-10-28 6:07 ` [PATCH v2 3/4] clk: renesas: rcar-usb2-clock-sel: Add multiple clocks management Yoshihiro Shimoda
2019-10-28 6:07 ` [PATCH v2 4/4] clk: renesas: rcar-usb2-clock-sel: Add reset_control Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191030143410.GA11171@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-clk@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).