From: Benoit Parrot <bparrot@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>, Tero Kristo <t-kristo@ti.com>,
<linux-omap@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-media@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [Patch v2 3/5] ARM: dts: dra7: add vpe clkctrl node
Date: Fri, 8 Nov 2019 11:02:31 -0600 [thread overview]
Message-ID: <20191108170231.ubwfu2nvcwjfabas@ti.com> (raw)
In-Reply-To: <20191108165554.GF5610@atomide.com>
Tony Lindgren <tony@atomide.com> wrote on Fri [2019-Nov-08 08:55:54 -0800]:
> Hi,
>
> * Benoit Parrot <bparrot@ti.com> [191104 20:39]:
> > Add clkctrl nodes for VPE module.
>
> Can you please add a comment describing that we currently need to
> use custom node names here instead of the standard naming?
Tony, what do you mean "custom node name" here?
I followed the exact same syntax that was already there... confused..
Benoit
>
> I can queue this and other dts change once I have an immutable clock
> changes branch from Tero.
>
> Or if Tero wants to also pick up the clock node dtsi patch I can ack it,
> up to Tero.
>
> Regards,
>
> Tony
>
>
> > Signed-off-by: Benoit Parrot <bparrot@ti.com>
> > ---
> > arch/arm/boot/dts/dra7xx-clocks.dtsi | 18 ++++++++++++++++--
> > 1 file changed, 16 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/dra7xx-clocks.dtsi b/arch/arm/boot/dts/dra7xx-clocks.dtsi
> > index 93e1eb83bed9..d1c2406ec71c 100644
> > --- a/arch/arm/boot/dts/dra7xx-clocks.dtsi
> > +++ b/arch/arm/boot/dts/dra7xx-clocks.dtsi
> > @@ -1591,10 +1591,10 @@
> >
> > rtc_cm: rtc-cm@700 {
> > compatible = "ti,omap4-cm";
> > - reg = <0x700 0x100>;
> > + reg = <0x700 0x60>;
> > #address-cells = <1>;
> > #size-cells = <1>;
> > - ranges = <0 0x700 0x100>;
> > + ranges = <0 0x700 0x60>;
> >
> > rtc_clkctrl: rtc-clkctrl@20 {
> > compatible = "ti,clkctrl";
> > @@ -1603,6 +1603,20 @@
> > };
> > };
> >
> > + vpe_cm: vpe-cm@760 {
> > + compatible = "ti,omap4-cm";
> > + reg = <0x760 0xc>;
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + ranges = <0 0x760 0xc>;
> > +
> > + vpe_clkctrl: vpe-clkctrl@0 {
> > + compatible = "ti,clkctrl";
> > + reg = <0x0 0xc>;
> > + #clock-cells = <2>;
> > + };
> > + };
> > +
> > };
> >
> > &cm_core {
> > --
> > 2.17.1
> >
next prev parent reply other threads:[~2019-11-08 16:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 20:38 [Patch v2 0/5] ARM: dts: dra7: add vpe nodes Benoit Parrot
2019-11-04 20:38 ` [Patch v2 1/5] dt-bindings: media: ti-vpe: Document VPE driver Benoit Parrot
2019-11-05 23:05 ` Rob Herring
2019-11-04 20:38 ` [Patch v2 2/5] clk: ti: dra7: add vpe clkctrl data Benoit Parrot
2019-11-04 20:38 ` [Patch v2 3/5] ARM: dts: dra7: add vpe clkctrl node Benoit Parrot
2019-11-08 16:55 ` Tony Lindgren
2019-11-08 17:02 ` Benoit Parrot [this message]
2019-11-08 17:06 ` Tony Lindgren
2019-11-04 20:38 ` [Patch v2 4/5] ARM: dts: dra7: Add ti-sysc node for VPE Benoit Parrot
2019-11-04 20:38 ` [Patch v2 5/5] media: ti-vpe: vpe: fix compatible to match bindings Benoit Parrot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108170231.ubwfu2nvcwjfabas@ti.com \
--to=bparrot@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).