From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"phil.edworthy@renesas.com" <phil.edworthy@renesas.com>,
"dmurphy@ti.com" <dmurphy@ti.com>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"mchehab+samsung@kernel.org" <mchehab+samsung@kernel.org>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"jacek.anaszewski@gmail.com" <jacek.anaszewski@gmail.com>,
"mazziesaccount@gmail.com" <mazziesaccount@gmail.com>,
"a.zummo@towertech.it" <a.zummo@towertech.it>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"noralf@tronnes.org" <noralf@tronnes.org>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"pavel@ucw.cz" <pavel@ucw.cz>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"wsa+renesas@sang-engineering.com"
<wsa+renesas@sang-engineering.com>
Subject: Re: [PATCH v6 05/15] mfd: bd71828: Support ROHM BD71828 PMIC - core
Date: Tue, 17 Dec 2019 15:08:10 +0100 [thread overview]
Message-ID: <20191217140810.GD3489463@kroah.com> (raw)
In-Reply-To: <20191217135430.GM18955@dell>
On Tue, Dec 17, 2019 at 01:54:30PM +0000, Lee Jones wrote:
> On Tue, 17 Dec 2019, Vaittinen, Matti wrote:
>
> > Hello Lee,
> >
> > On Mon, 2019-12-16 at 16:46 +0000, Lee Jones wrote:
> > > On Wed, 11 Dec 2019, Matti Vaittinen wrote:
> > >
> > > > BD71828GW is a single-chip power management IC for battery-powered
> > > > portable
> > > > devices. The IC integrates 7 buck converters, 7 LDOs, and a 1500 mA
> > > > single-cell linear charger. Also included is a Coulomb counter, a
> > > > real-time
> > > > clock (RTC), 3 GPO/regulator control pins, HALL input and a 32.768
> > > > kHz
> > > > clock gate.
> > > >
> > > > Add MFD core driver providing interrupt controller facilities and
> > > > i2c
> > > > access to sub device drivers.
> > > >
> > > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > > > ---
> > > >
> > > > Changes since v5:
> > > > - No changes
> > > >
> > > > drivers/mfd/Kconfig | 15 ++
> > > > drivers/mfd/Makefile | 2 +-
> > > > drivers/mfd/rohm-bd71828.c | 319 +++++++++++++++++++++++
> > > > include/linux/mfd/rohm-bd71828.h | 425
> > > > +++++++++++++++++++++++++++++++
> > > > include/linux/mfd/rohm-generic.h | 1 +
> > > > 5 files changed, 761 insertions(+), 1 deletion(-)
> > > > create mode 100644 drivers/mfd/rohm-bd71828.c
> > > > create mode 100644 include/linux/mfd/rohm-bd71828.h
> > >
> > > Couple of small nits. Once fixed, please apply my:
> > >
> > > For my own reference:
> > > Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
> > >
> > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > > > index 420900852166..c3c9432ef51c 100644
> > > > --- a/drivers/mfd/Kconfig
> > > > +++ b/drivers/mfd/Kconfig
> > > > @@ -1906,6 +1906,21 @@ config MFD_ROHM_BD70528
> > > > 10 bits SAR ADC for battery temperature monitor and 1S
> > > > battery
> > > > charger.
> > > >
> > > > +config MFD_ROHM_BD71828
> > > > + tristate "ROHM BD71828 Power Management IC"
> > > > + depends on I2C=y
> > > > + depends on OF
> > > > + select REGMAP_I2C
> > > > + select REGMAP_IRQ
> > > > + select MFD_CORE
> > > > + help
> > > > + Select this option to get support for the ROHM BD71828 Power
> > > > + Management IC. BD71828GW is a single-chip power management IC
> > > > for
> > > > + battery-powered portable devices. The IC integrates 7 buck
> > > > + converters, 7 LDOs, and a 1500 mA single-cell linear charger.
> > > > + Also included is a Coulomb counter, a real-time clock (RTC),
> > > > and
> > > > + a 32.768 kHz clock gate.
> > > > +
> > > > config MFD_STM32_LPTIMER
> > > > tristate "Support for STM32 Low-Power Timer"
> > > > depends on (ARCH_STM32 && OF) || COMPILE_TEST
> > > > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> > > > index aed99f08739f..ca2d55c679c5 100644
> > > > --- a/drivers/mfd/Makefile
> > > > +++ b/drivers/mfd/Makefile
> > > > @@ -252,6 +252,6 @@ obj-$(CONFIG_MFD_MXS_LRADC) += mxs-lradc.o
> > > > obj-$(CONFIG_MFD_SC27XX_PMIC) += sprd-sc27xx-spi.o
> > > > obj-$(CONFIG_RAVE_SP_CORE) += rave-sp.o
> > > > obj-$(CONFIG_MFD_ROHM_BD70528) += rohm-bd70528.o
> > > > +obj-$(CONFIG_MFD_ROHM_BD71828) += rohm-bd71828.o
> > > > obj-$(CONFIG_MFD_ROHM_BD718XX) += rohm-bd718x7.o
> > > > obj-$(CONFIG_MFD_STMFX) += stmfx.o
> > > > -
> > >
> > > Nit: This is an unrelated change and should not really be in this
> > > patch.
> >
> > Ok. Will get rid of it.
> >
> > >
> > > > diff --git a/drivers/mfd/rohm-bd71828.c b/drivers/mfd/rohm-
> > > > bd71828.c
> > > > new file mode 100644
> > > > index 000000000000..7f445d699fd9
> > > > --- /dev/null
> > > > +++ b/drivers/mfd/rohm-bd71828.c
> > > > @@ -0,0 +1,319 @@
> > > > +// SPDX-License-Identifier: GPL-2.0-only
> > > > +//
> > > > +// Copyright (C) 2019 ROHM Semiconductors
> > > > +//
> > > > +// ROHM BD71828 PMIC driver
> > > > +
> >
> > //snip
> >
> > > > +
> > > > +static struct i2c_driver bd71828_drv = {
> > > > + .driver = {
> > > > + .name = "rohm-bd71828",
> > > > + .of_match_table = bd71828_of_match,
> > > > + },
> > > > + .probe_new = &bd71828_i2c_probe,
> > > > +};
> > > > +
> > >
> > > Nit: You can remove this line.
> >
> > Will do.
> >
> > >
> > > > +module_i2c_driver(bd71828_drv);
> > > > +
> > > > +MODULE_AUTHOR("Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > > > ");
> > > > +MODULE_DESCRIPTION("ROHM BD71828 Power Management IC driver");
> > > > +MODULE_LICENSE("GPL");
> > >
> > > This does not match the header.
> >
> > How is that? This is what is stated in module.h for the
> > MODULE_LICENSE:
> >
> > /*
> > * The following license idents are currently accepted as indicating
> > free
> > * software modules
> > *
> > * "GPL" [GNU Public License v2]
> > * "GPL v2" [GNU Public License v2]
> > * "GPL and additional rights" [GNU Public License v2 rights
> > and more]
> > * "Dual BSD/GPL" [GNU Public License v2
> > * or BSD license choice]
> > * "Dual MIT/GPL" [GNU Public License v2
> > * or MIT license choice]
> > * "Dual MPL/GPL" [GNU Public License v2
> > * or Mozilla license choice]
> > *
> > * The following other idents are available
> > *
> > * "Proprietary" [Non free products]
> > *
> > * Both "GPL v2" and "GPL" (the latter also in dual licensed strings)
> > are
> > * merely stating that the module is licensed under the GPL v2, but are
> > not
> > * telling whether "GPL v2 only" or "GPL v2 or later". The reason why
> > there
> > * are two variants is a historic and failed attempt to convey more
> > * information in the MODULE_LICENSE string. For module loading the
> > * "only/or later" distinction is completely irrelevant and does
> > neither
> > * replace the proper license identifiers in the corresponding source
> > file
> > * nor amends them in any way. The sole purpose is to make the
> > * 'Proprietary' flagging work and to refuse to bind symbols which are
> > * exported with EXPORT_SYMBOL_GPL when a non free module is loaded.
> > *
> > * In the same way "BSD" is not a clear license information. It merely
> > * states, that the module is licensed under one of the compatible BSD
> > * license variants. The detailed and correct license information is
> > again
> > * to be found in the corresponding source files.
> > *
> > * There are dual licensed components, but when running with Linux it
> > is the
> > * GPL that is relevant so this is a non issue. Similarly LGPL linked
> > with GPL
> > * is a GPL combined work.
> > *
> > * This exists for several reasons
> > * 1. So modinfo can show license info for users wanting to vet their
> > setup
> > * is free
> > * 2. So the community can ignore bug reports including proprietary
> > modules
> > * 3. So vendors can do likewise based on their own policies
> > */
> > #define MODULE_LICENSE(_license) MODULE_INFO(license, _license)
> >
> > I have no objections on changing the license if needed but can you
> > please tell me what is Ok combos then - I am having hard time when
> > trying to select licenses which are acceptable for all.
>
> If you have this in your header:
>
> GPL-2.0-only
>
> Your MODULE tags should read:
>
> MODULE_LICENSE("GPL v2");
Nope, as per module.h, which is quoted here, either:
MODULE_LICENSE("GPL");
or:
MODULE_LICENSE("GPL v2");
mean the exact same thing.
thanks,
greg k-h
next prev parent reply other threads:[~2019-12-17 14:08 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 9:33 [PATCH v6 00/15] Support ROHM BD71828 PMIC Matti Vaittinen
2019-12-11 9:35 ` [PATCH v6 01/15] dt-bindings: regulator: Document ROHM BD71282 regulator bindings Matti Vaittinen
2019-12-17 12:39 ` Applied "dt-bindings: regulator: Document ROHM BD71282 regulator bindings" to the regulator tree Mark Brown
2019-12-11 9:36 ` [PATCH v6 02/15] dt-bindings: leds: ROHM BD71282 PMIC LED driver Matti Vaittinen
2019-12-18 18:07 ` Rob Herring
2019-12-11 9:37 ` [PATCH v6 03/15] dt-bindings: mfd: Document ROHM BD71828 bindings Matti Vaittinen
2019-12-18 18:08 ` Rob Herring
2019-12-11 9:39 ` [PATCH v6 04/15] mfd: rohm PMICs - use platform_device_id to match MFD sub-devices Matti Vaittinen
2019-12-16 16:41 ` Lee Jones
2019-12-11 9:42 ` [PATCH v6 05/15] mfd: bd71828: Support ROHM BD71828 PMIC - core Matti Vaittinen
2019-12-16 16:46 ` Lee Jones
2019-12-17 9:39 ` Vaittinen, Matti
2019-12-17 13:54 ` Lee Jones
2019-12-17 14:08 ` gregkh [this message]
2019-12-17 14:25 ` Lee Jones
2019-12-11 9:43 ` [PATCH v6 06/15] mfd: input: bd71828: Add power-key support Matti Vaittinen
2019-12-11 9:43 ` [PATCH v6 07/15] clk: bd718x7: Support ROHM BD71828 clk block Matti Vaittinen
2019-12-16 16:47 ` Lee Jones
2019-12-11 9:44 ` [PATCH v6 08/15] regulator: bd718x7: Split driver to common and bd718x7 specific parts Matti Vaittinen
2019-12-18 13:12 ` Mark Brown
2019-12-18 17:27 ` Mark Brown
2019-12-11 9:46 ` [PATCH v6 09/15] regulator: bd71828: Basic support for ROHM bd71828 PMIC regulators Matti Vaittinen
2019-12-16 14:55 ` Mark Brown
2019-12-17 6:56 ` Vaittinen, Matti
2019-12-17 9:15 ` Vaittinen, Matti
2019-12-17 12:39 ` Applied "regulator: bd71828: Basic support for ROHM bd71828 PMIC regulators" to the regulator tree Mark Brown
2019-12-18 8:06 ` Vaittinen, Matti
2019-12-18 13:17 ` Mark Brown
2019-12-18 13:33 ` Vaittinen, Matti
2019-12-18 14:01 ` Vaittinen, Matti
2019-12-18 17:24 ` Mark Brown
2019-12-11 9:47 ` [PATCH v6 10/15] gpio: devres: Add devm_gpiod_get_parent_array Matti Vaittinen
2019-12-16 8:29 ` Linus Walleij
2019-12-16 8:59 ` Vaittinen, Matti
2019-12-16 12:21 ` Linus Walleij
2019-12-11 9:47 ` [PATCH v6 11/15] docs: driver-model: Add missing managed GPIO array get functions Matti Vaittinen
2019-12-16 8:31 ` Linus Walleij
2019-12-11 9:48 ` [PATCH v6 12/15] rtc: bd70528 add BD71828 support Matti Vaittinen
2019-12-11 11:38 ` Alexandre Belloni
2019-12-11 11:48 ` Vaittinen, Matti
2019-12-11 9:49 ` [PATCH v6 13/15] gpio: bd71828: Initial support for ROHM BD71828 PMIC GPIOs Matti Vaittinen
2019-12-16 8:32 ` Linus Walleij
2019-12-11 10:00 ` [PATCH v6 14/15] leds: Add common LED binding parsing support to LED class/core Matti Vaittinen
2019-12-11 10:02 ` [PATCH v6 15/15] led: bd71828: Support LED outputs on ROHM BD71828 PMIC Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217140810.GD3489463@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Matti.Vaittinen@fi.rohmeurope.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mazziesaccount@gmail.com \
--cc=mchehab+samsung@kernel.org \
--cc=mturquette@baylibre.com \
--cc=noralf@tronnes.org \
--cc=pavel@ucw.cz \
--cc=phil.edworthy@renesas.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).