From: Stephen Boyd <sboyd@kernel.org>
To: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>,
Taniya Das <tdas@codeaurora.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
David Brown <david.brown@linaro.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
MSM <linux-arm-msm@vger.kernel.org>,
linux-soc@vger.kernel.org, linux-clk@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>,
DTML <devicetree@vger.kernel.org>, Rob Herring <robh@kernel.org>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v2 3/8] dt-bindings: clock: Add YAML schemas for the QCOM GPUCC clock bindings
Date: Wed, 18 Dec 2019 21:32:43 -0800 [thread overview]
Message-ID: <20191219053244.88D3A222C2@mail.kernel.org> (raw)
In-Reply-To: <0101016eab0a4e76-b8eb44c5-d076-46b9-a156-b80dc650ca31-000000@us-west-2.amazonses.com>
Quoting Taniya Das (2019-11-26 20:06:49)
>
>
> On 11/26/2019 11:41 PM, Stephen Boyd wrote:
> > Quoting Jeffrey Hugo (2019-11-15 07:11:01)
> >> On Fri, Nov 15, 2019 at 3:07 AM Taniya Das <tdas@codeaurora.org> wrote:
> >>> diff --git a/Documentation/devicetree/bindings/clock/qcom,gpucc.yaml b/Documentation/devicetree/bindings/clock/qcom,gpucc.yaml
> >>> new file mode 100644
> >>> index 0000000..c2d6243
> >>> --- /dev/null
> >>> +++ b/Documentation/devicetree/bindings/clock/qcom,gpucc.yaml
> >>> + - description: GPLL0 source from GCC
> >>
> >> This is not an accurate conversion. GPLL0 was not valid for 845, and
> >> is required for 8998.
> >
> > Thanks for checking Jeff.
> >
> > It looks like on 845 there are two gpll0 clocks going to gpucc. From
> > gpu_cc_parent_map_0:
> >
> > "gcc_gpu_gpll0_clk_src",
> > "gcc_gpu_gpll0_div_clk_src",
> >
>
> There are branches of GPLL0 which would be connected to most external
> CCs. It is upto to the external CCs to either use them to source a
> frequency or not.
Yes, they can decide to use them or not, but they really do go to the
CCs so the DT should describe that.
next prev parent reply other threads:[~2019-12-19 5:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 10:04 [PATCH v2 0/8] Add GPU & Video Clock controller driver for SC7180 Taniya Das
2019-11-15 10:04 ` [PATCH v2 1/8] clk: qcom: alpha-pll: Remove useless read from set rate Taniya Das
2019-12-24 6:37 ` Stephen Boyd
2019-11-15 10:04 ` [PATCH v2 2/8] clk: qcom: clk-alpha-pll: Add support for Fabia PLL calibration Taniya Das
2019-12-24 6:37 ` Stephen Boyd
2019-11-15 10:04 ` [PATCH v2 3/8] dt-bindings: clock: Add YAML schemas for the QCOM GPUCC clock bindings Taniya Das
2019-11-15 15:11 ` Jeffrey Hugo
2019-11-26 18:11 ` Stephen Boyd
2019-11-27 4:06 ` Taniya Das
2019-12-19 5:32 ` Stephen Boyd [this message]
2019-12-27 6:43 ` Taniya Das
2019-11-15 10:05 ` [PATCH v2 4/8] dt-bindings: clock: Introduce QCOM Graphics " Taniya Das
2019-11-15 10:05 ` [PATCH v2 5/8] clk: qcom: Add graphics clock controller driver for SC7180 Taniya Das
2019-11-15 10:05 ` [PATCH v2 6/8] dt-bindings: clock: Add YAML schemas for the QCOM VIDEOCC clock bindings Taniya Das
2019-11-15 10:05 ` [PATCH v2 7/8] dt-bindings: clock: Introduce QCOM Video " Taniya Das
2019-12-03 17:22 ` Rob Herring
2019-11-15 10:05 ` [PATCH v2 8/8] clk: qcom: Add video clock controller driver for SC7180 Taniya Das
2019-12-24 2:30 ` Stephen Boyd
2019-12-27 6:41 ` Taniya Das
2019-12-24 2:32 ` [PATCH v2 0/8] Add GPU & Video Clock " Stephen Boyd
2019-12-27 6:44 ` Taniya Das
-- strict thread matches above, loose matches on Subject: below --
2019-11-15 9:56 Taniya Das
2019-11-15 9:56 ` [PATCH v2 3/8] dt-bindings: clock: Add YAML schemas for the QCOM GPUCC clock bindings Taniya Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219053244.88D3A222C2@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).