From: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
To: Rob Herring <robh@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
punit1.agrawal@toshiba.co.jp, yuji2.ishikawa@toshiba.co.jp,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/4] dt-bindings: clock: Add DT bindings for PLL of Toshiba Visconti TMPV770x SoC
Date: Tue, 20 Jul 2021 10:40:54 +0900 [thread overview]
Message-ID: <20210720014054.fvgncx4dacojrl6q@toshiba.co.jp> (raw)
In-Reply-To: <20210714192339.GA3052504@robh.at.kernel.org>
Hi,
Thanks for your review.
On Wed, Jul 14, 2021 at 01:23:39PM -0600, Rob Herring wrote:
> On Thu, Jun 24, 2021 at 12:43:35PM +0900, Nobuhiro Iwamatsu wrote:
> > Add device tree bindings for PLL of Toshiba Visconti TMPV770x SoC series.
> >
> > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> > ---
> > .../clock/toshiba,tmpv770x-pipllct.yaml | 49 +++++++++++++++++++
> > 1 file changed, 49 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/clock/toshiba,tmpv770x-pipllct.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/clock/toshiba,tmpv770x-pipllct.yaml b/Documentation/devicetree/bindings/clock/toshiba,tmpv770x-pipllct.yaml
> > new file mode 100644
> > index 000000000000..e88c9e4c4982
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/toshiba,tmpv770x-pipllct.yaml
> > @@ -0,0 +1,49 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/clock/toshiba,tmpv770x-pipllct.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Toshiba Visconti5 TMPV770X PLL Controller Device Tree Bindings
> > +
> > +maintainers:
> > + - Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> > +
> > +description:
> > + Toshia Visconti5 PLL controller which supports the PLLs on TMPV770X.
> > +
> > +properties:
> > + compatible:
> > + const: toshiba,tmpv7708-pipllct
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + '#clock-cells':
> > + const: 1
> > +
> > + osc2-clk-frequency:
> > + description: Frequency of the OSC2 oscillator.
>
> This is an external input? This should be a fixed-clock and this node
> needs 'clocks' to connect it.
OK, I will rewrite using fixed-clock.
>
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - "#clock-cells"
> > + - osc2-clk-frequency
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + soc {
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > +
> > + pipllct: pipllct@24220000 {
>
> clock-controller@...
I will fix.
>
> > + compatible = "toshiba,tmpv7708-pipllct";
> > + reg = <0 0x24220000 0 0x820>;
> > + #clock-cells = <1>;
> > + osc2-clk-frequency = <20000000>;
> > + };
> > + };
> > +...
> > --
> > 2.32.0
> >
> >
>
Best regards,
Nobuhiro
next prev parent reply other threads:[~2021-07-20 1:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 3:43 [PATCH v3 0/4] clk: visconti: Add support common clock driver and reset driver Nobuhiro Iwamatsu
2021-06-24 3:43 ` [PATCH v3 1/4] " Nobuhiro Iwamatsu
2021-07-14 19:21 ` Rob Herring
2021-07-20 1:39 ` Nobuhiro Iwamatsu
2021-06-24 3:43 ` [PATCH v3 2/4] dt-bindings: clock: Add DT bindings for PLL of Toshiba Visconti TMPV770x SoC Nobuhiro Iwamatsu
2021-07-14 19:23 ` Rob Herring
2021-07-20 1:40 ` Nobuhiro Iwamatsu [this message]
2021-06-24 3:43 ` [PATCH v3 3/4] dt-bindings: clock: Add DT bindings for SMU " Nobuhiro Iwamatsu
2021-07-14 19:24 ` Rob Herring
2021-07-20 1:53 ` Nobuhiro Iwamatsu
2021-06-24 3:43 ` [PATCH v3 4/4] MAINTAINERS: Add entries for Toshiba Visconti PLL and clock controller Nobuhiro Iwamatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210720014054.fvgncx4dacojrl6q@toshiba.co.jp \
--to=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=punit1.agrawal@toshiba.co.jp \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=yuji2.ishikawa@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).