Re: [PATCH 1/3] mailbox: Make BCM2835_MBOX default to ARCH_BCM2835

From: Conor Dooley <conor@kernel.org>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: linux-arm-kernel@lists.infradead.org,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Bjorn Andersson <quic_bjorande@quicinc.com>,
	Maximilian Luz <luzmaximilian@gmail.com>,
	Ard Biesheuvel <ardb@kernel.org>,
	Johan Hovold <johan+linaro@kernel.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Conor Dooley <conor.dooley@microchip.com>,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
	"open list:COMMON CLK FRAMEWORK" <linux-clk@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	Stefan Wahren <wahrenst@gmx.net>
Subject: Re: [PATCH 1/3] mailbox: Make BCM2835_MBOX default to ARCH_BCM2835
Date: Tue, 14 May 2024 13:29:43 +0100	[thread overview]
Message-ID: <20240514-amiable-unequal-d4133956c80c@spud> (raw)
In-Reply-To: <20240513235234.1474619-2-florian.fainelli@broadcom.com>

[-- Attachment #1: Type: text/plain, Size: 1248 bytes --]

On Mon, May 13, 2024 at 04:52:32PM -0700, Florian Fainelli wrote:
> This driver is depended on by CONFIG_FIRMWARE_RASPBERRYPI which provides
> a number of essential services, including but not limited to a Linux
> common clock framework provider. Make sure that enable
> CONFIG_ARCH_BCM2835 does enable the corresponding mailbox driver.
> 
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> ---
>  drivers/mailbox/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
> index 42940108a187..2b4cde562a90 100644
> --- a/drivers/mailbox/Kconfig
> +++ b/drivers/mailbox/Kconfig
> @@ -109,6 +109,7 @@ config ALTERA_MBOX
>  config BCM2835_MBOX
>  	tristate "BCM2835 Mailbox"
>  	depends on ARCH_BCM2835
> +	default ARCH_BCM2835

This is just "default y", since I doubt ARCH_BCM2835 can be a module?

If so, patch 2 could also just be "default y" and I think patch 3 can
have the same logic applied to it, given you're defaulting it to a
dependency also?

Thanks,
Conor.

>  	help
>  	  An implementation of the BCM2385 Mailbox.  It is used to invoke
>  	  the services of the Videocore. Say Y here if you want to use the
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]