From: gokulsri@codeaurora.org
To: Stephen Boyd <sboyd@kernel.org>
Cc: bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, linux-remoteproc@vger.kernel.org,
agross@kernel.org, linux-soc@vger.kernel.org,
devicetree@vger.kernel.org, govinds@codeaurora.org,
sricharan@codeaurora.org
Subject: Re: [v7 1/4] remoteproc: qcom: wcss: populate hardcoded param using driver data
Date: Tue, 28 Jul 2020 16:15:42 +0530 [thread overview]
Message-ID: <2cf8aa0af13a104a8e4171ebcb0a6e62@codeaurora.org> (raw)
In-Reply-To: <159442464252.1987609.9113647358389820731@swboyd.mtv.corp.google.com>
Thanks for your comments Stephen.
Will address your comments below and re-submit.
On 2020-07-11 05:14, Stephen Boyd wrote:
> Quoting Gokul Sriram Palanisamy (2020-07-03 01:58:39)
>> From: Govind Singh <govinds@codeaurora.org>
>>
>> Q6 based WiFi fw loading is supported across
>> different targets, ex: IPQ8074/QCS404. In order to
>> support different fw names/pas id etc, populate
>> hardcoded param using driver data.
>>
>> Signed-off-by: Govind Singh <govinds@codeaurora.org>
>> [rebased on top of 5.8-rc3]
>
> This tag is not really useful and doesn't follow the style of having
> your email prefix the text. I'd expect to see
>
> [gokulsri@codeaurora.org: made some sort of change]
>
>> Signed-off-by: Gokul Sriram Palanisamy <gokulsri@codeaurora.org>
>> ---
>> drivers/remoteproc/qcom_q6v5_wcss.c | 31
>> ++++++++++++++++++++++++++-----
>> 1 file changed, 26 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/remoteproc/qcom_q6v5_wcss.c
>> b/drivers/remoteproc/qcom_q6v5_wcss.c
>> index 88c76b9..abc5f9d 100644
>> --- a/drivers/remoteproc/qcom_q6v5_wcss.c
>> +++ b/drivers/remoteproc/qcom_q6v5_wcss.c
>> @@ -70,6 +71,11 @@
>> #define TCSR_WCSS_CLK_MASK 0x1F
>> #define TCSR_WCSS_CLK_ENABLE 0x14
>>
>> +struct wcss_data {
>> + const char *firmware_name;
>> + int crash_reason_smem;
>
> Is it signed for some reason?
Can be unsigned. Will update.
>
>> +};
>> +
>> struct q6v5_wcss {
>> struct device *dev;
>>
>> @@ -92,6 +98,8 @@ struct q6v5_wcss {
>> void *mem_region;
>> size_t mem_size;
>>
>> + int crash_reason_smem;
>> +
>
> Same question, why not unsigned?
Can be unsigned. Will update.
>
>> struct qcom_rproc_glink glink_subdev;
>> struct qcom_rproc_ssr ssr_subdev;
>> };
>> @@ -430,7 +438,7 @@ static int q6v5_wcss_load(struct rproc *rproc,
>> const struct firmware *fw)
>> wcss->mem_size,
>> &wcss->mem_reloc);
>> }
>>
>> -static const struct rproc_ops q6v5_wcss_ops = {
>> +static const struct rproc_ops q6v5_wcss_ipq8074_ops = {
>> .start = q6v5_wcss_start,
>> .stop = q6v5_wcss_stop,
>> .da_to_va = q6v5_wcss_da_to_va,
>> @@ -530,12 +538,17 @@ static int q6v5_alloc_memory_region(struct
>> q6v5_wcss *wcss)
>>
>> static int q6v5_wcss_probe(struct platform_device *pdev)
>> {
>> + const struct wcss_data *desc;
>> struct q6v5_wcss *wcss;
>> struct rproc *rproc;
>> int ret;
>>
>> - rproc = rproc_alloc(&pdev->dev, pdev->name, &q6v5_wcss_ops,
>> - "IPQ8074/q6_fw.mdt", sizeof(*wcss));
>> + desc = of_device_get_match_data(&pdev->dev);
>
> Use device_get_match_data() and drop the of_device.h include.
ok, will do.
>
>> + if (!desc)
>> + return -EINVAL;
>> +
>> + rproc = rproc_alloc(&pdev->dev, pdev->name,
>> &q6v5_wcss_ipq8074_ops,
>> + desc->firmware_name, sizeof(*wcss));
>> if (!rproc) {
>> dev_err(&pdev->dev, "failed to allocate rproc\n");
>> return -ENOMEM;
>> @@ -587,8 +602,14 @@ static int q6v5_wcss_remove(struct
>> platform_device *pdev)
>> return 0;
>> }
>>
>> +static const struct wcss_data wcss_ipq8074_res_init = {
>> + .firmware_name = "IPQ8074/q6_fw.mdt",
>> + .crash_reason_smem = WCSS_CRASH_REASON,
>> +};
>> +
>> static const struct of_device_id q6v5_wcss_of_match[] = {
>> - { .compatible = "qcom,ipq8074-wcss-pil" },
>> + { .compatible = "qcom,ipq8074-wcss-pil", .data =
>> &wcss_ipq8074_res_init },
>> +
>
> Please remove this extra newline.
ok. Will do.
>
>> { },
>> };
>> MODULE_DEVICE_TABLE(of, q6v5_wcss_of_match);
next prev parent reply other threads:[~2020-07-28 10:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 9:23 [PATCH v5 0/7] Add non PAS wcss Q6 support for QCS404 Govind Singh
2019-07-26 9:23 ` [PATCH v5 1/7] clk: qcom: Add WCSS gcc clock control " Govind Singh
2019-08-08 15:10 ` Stephen Boyd
2019-07-26 9:23 ` [PATCH v5 2/7] dt-bindings: clock: qcom: Add QCOM Q6SSTOP clock controller bindings Govind Singh
2019-07-26 19:43 ` Stephen Boyd
2019-07-26 9:23 ` [PATCH v5 3/7] clk: qcom: define probe by index API as common API Govind Singh
2019-08-08 15:20 ` Stephen Boyd
2019-07-26 9:23 ` [PATCH v5 4/7] clk: qcom: Add Q6SSTOP clock controller for QCS404 Govind Singh
2019-08-08 15:09 ` Stephen Boyd
2019-08-13 13:14 ` Govind Singh
2019-07-26 9:23 ` [PATCH v5 5/7] remoteproc: qcom: wcss: populate hardcoded param using driver data Govind Singh
2019-07-26 9:23 ` [PATCH v5 6/7] remoteproc: qcom: wcss: Add non pas wcss Q6 support for QCS404 Govind Singh
2019-07-26 9:23 ` [PATCH v5 7/7] remoteproc: qcom: wcss: explicitly request exclusive reset control Govind Singh
2020-07-03 8:12 ` [v6 0/4] Add non PAS wcss Q6 support for QCS404 Gokul Sriram Palanisamy
2020-07-03 8:12 ` [v6 1/4] remoteproc: qcom: wcss: populate hardcoded param using driver data Gokul Sriram Palanisamy
2020-07-03 8:12 ` [v6 2/4] dt-bindings: remoteproc: qcom: Add Q6V5 Modem PIL binding for QCS404 Gokul Sriram Palanisamy
2020-07-03 8:12 ` [v6 3/4] remoteproc: qcom: wcss: Add non pas wcss Q6 support " Gokul Sriram Palanisamy
2020-07-03 8:12 ` [v6 4/4] remoteproc: qcom: wcss: explicitly request exclusive reset control Gokul Sriram Palanisamy
2020-07-03 8:58 ` [v7 0/4] Add non PAS wcss Q6 support for QCS404 Gokul Sriram Palanisamy
2020-07-03 8:58 ` [v7 1/4] remoteproc: qcom: wcss: populate hardcoded param using driver data Gokul Sriram Palanisamy
2020-07-10 23:44 ` Stephen Boyd
2020-07-28 10:45 ` gokulsri [this message]
2020-07-03 8:58 ` [v7 2/4] dt-bindings: remoteproc: qcom: Add Q6V5 Modem PIL binding for QCS404 Gokul Sriram Palanisamy
2020-07-09 20:38 ` Rob Herring
2020-07-03 8:58 ` [v7 3/4] remoteproc: qcom: wcss: Add non pas wcss Q6 support " Gokul Sriram Palanisamy
2020-07-03 8:58 ` [v7 4/4] remoteproc: qcom: wcss: explicitly request exclusive reset control Gokul Sriram Palanisamy
2020-07-10 23:40 ` [v7 0/4] Add non PAS wcss Q6 support for QCS404 Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cf8aa0af13a104a8e4171ebcb0a6e62@codeaurora.org \
--to=gokulsri@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=govinds@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).