From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-amlogic@lists.infradead.org, jbrunet@baylibre.com,
linux-clk@vger.kernel.org, sboyd@kernel.org,
linux-arm-kernel@lists.infradead.org, mturquette@baylibre.com,
Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 0/2] clk: meson8b: fix typo "ABP" -> "APB"
Date: Sun, 10 Feb 2019 11:58:33 +0100 [thread overview]
Message-ID: <5C6003D9.9090304@baylibre.com> (raw)
In-Reply-To: <CAFBinCCrYrxnb6Dk-0kGwbk0ttwe+je+wKZqxe6GUASnNdAckQ@mail.gmail.com>
Hi Martin,
Le 09/02/2019 01:24, Martin Blumenstingl a écrit :
> Hi Neil,
>
> On Mon, Jan 21, 2019 at 11:40 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> On 19/01/2019 21:51, Martin Blumenstingl wrote:
>>> It turns out that I'm not good at spelling "APB". Unfortunately an ABP
>>> (instead of APB) typo snug into two clocks in v5.0.
>>>
>>> Currently there are no users of that clock yet, so fix it now
>>> before it's too late (meaning before it's used by <something>).
>>>
>>> I decided to go the "normal" route where we can have separate
>>> branches for the dt-bindings and the drivers in the clk-meson
>>> repo. This means:
>>> - new (typo-free) clock #define
>>> - change the clock controller to use the new #define
>>> - (next development cycle) drop the old #define
>>>
>>>
>>> Changes since v1 at [0]:
>>> - split into a dt-bindings and clock controller driver patch
>>>
>>>
>>> [0] https://patchwork.kernel.org/cover/10742001/
>>>
>>>
>>> Martin Blumenstingl (2):
>>> dt-bindings: clock: meson8b: add APB clock definition
>>> clk: meson: meson8b: fix the naming of the APB clocks
>>>
>>> drivers/clk/meson/meson8b.c | 26 ++++++++++++------------
>>> drivers/clk/meson/meson8b.h | 2 +-
>>> include/dt-bindings/clock/meson8b-clkc.h | 1 +
>>> 3 files changed, 15 insertions(+), 14 deletions(-)
>>>
>>
>> Once rob acks it, I'll apply both to next/drivers since it's not used (yet ?)
>> and not a critical fix.
> I have just noticed that I forgot to CC Rob and devicetree@vger.kernel.org.
> do you want me to re-send this series?
Yes please re-send !
Neil
>
> as you already noticed this is not critical, so taking this through
> next/drivers is fine for me.
>
>
> Regards
> Martin
>
prev parent reply other threads:[~2019-02-10 10:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-19 20:51 [PATCH v2 0/2] clk: meson8b: fix typo "ABP" -> "APB" Martin Blumenstingl
2019-01-19 20:51 ` [PATCH v2 1/2] dt-bindings: clock: meson8b: add APB clock definition Martin Blumenstingl
2019-01-19 20:51 ` [PATCH v2 2/2] clk: meson: meson8b: fix the naming of the APB clocks Martin Blumenstingl
2019-01-21 10:40 ` [PATCH v2 0/2] clk: meson8b: fix typo "ABP" -> "APB" Neil Armstrong
2019-02-09 0:24 ` Martin Blumenstingl
2019-02-10 10:58 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C6003D9.9090304@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).