From: Aisheng Dong <aisheng.dong@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
Fabio Estevam <fabio.estevam@nxp.com>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH RESEND v1 2/4] dt-bindings: fsl: scu: add imx8qm scu clock support
Date: Tue, 22 Jan 2019 12:58:38 +0000 [thread overview]
Message-ID: <AM0PR04MB421124D0E6031D97E6693E9680980@AM0PR04MB4211.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20190121232730.GA22676@bogus>
> > Required properties:
> > - compatible: Should be one of:
> > - "fsl,imx8qxp-clock"
> > + "fsl,imx8qm-clock",
> > + "fsl,imx8qxp-clock".
>
> No need for the punctuation here. The whole point of one per line is to have 1
> line changes. Otherwise,
>
Got it, thanks.
I will update it later.
> Reviewed-by: Rob Herring <robh@kernel.org>
>
> > followed by "fsl,scu-clk"
> > - #clock-cells: Should be 1. Contains the Clock ID value.
> > - clocks: List of clock specifiers, must contain an entry for
> > --
> > 2.7.4
> >
next prev parent reply other threads:[~2019-01-22 12:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 11:55 [PATCH RESEND v1 0/4] dt-binding: clk: prepare for imx8qm clock support Aisheng Dong
2019-01-11 11:55 ` [PATCH RESEND v1 1/4] dt-bindings: fsl: scu: add fallback compatible string for clock Aisheng Dong
2019-01-21 23:25 ` Rob Herring
2019-01-22 19:05 ` Stephen Boyd
2019-01-11 11:56 ` [PATCH RESEND v1 2/4] dt-bindings: fsl: scu: add imx8qm scu clock support Aisheng Dong
2019-01-21 23:27 ` Rob Herring
2019-01-22 12:58 ` Aisheng Dong [this message]
2019-01-22 19:06 ` Stephen Boyd
2019-01-11 11:56 ` [PATCH RESEND v1 3/4] clk: imx: scu: add fallback compatible string support Aisheng Dong
2019-01-11 11:56 ` [PATCH RESEND v1 4/4] dt-bindings: imx8-clock: add a53 and a72 clock id Aisheng Dong
2019-01-22 0:10 ` Rob Herring
2019-01-22 12:59 ` Aisheng Dong
2019-01-30 16:45 ` Rob Herring
2019-01-16 5:40 ` [PATCH RESEND v1 0/4] dt-binding: clk: prepare for imx8qm clock support Aisheng Dong
2019-01-16 11:02 ` Shawn Guo
2019-01-22 19:06 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR04MB421124D0E6031D97E6693E9680980@AM0PR04MB4211.eurprd04.prod.outlook.com \
--to=aisheng.dong@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).