From: Peng Fan <peng.fan@nxp.com>
To: Leonard Crestez <leonard.crestez@nxp.com>,
Shawn Guo <shawnguo@kernel.org>, Abel Vesa <abel.vesa@nxp.com>
Cc: Jacky Bai <ping.bai@nxp.com>, Stephen Boyd <sboyd@kernel.org>,
Anson Huang <anson.huang@nxp.com>,
Marco Felsch <m.felsch@pengutronix.de>,
Michael Turquette <mturquette@baylibre.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
dl-linux-imx <linux-imx@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH] clk: imx: Fix imx8m_clk_hw_composite_core flags
Date: Tue, 14 Jan 2020 00:41:17 +0000 [thread overview]
Message-ID: <AM0PR04MB4481E14B1E82DE106F6D579188340@AM0PR04MB4481.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <7d118c8ad52e87a7cadb438097fcdfbeeb822dd7.1578958643.git.leonard.crestez@nxp.com>
> Subject: [PATCH] clk: imx: Fix imx8m_clk_hw_composite_core flags
>
> Just like other imx8m composites the "core" slice needs the
> CLK_SET_RATE_NO_REPARENT and CLK_OPS_PARENT_ENABLE flags. It is not
> clear why they were omitted.
>
> In particular without the CLK_OPS_PARENT_ENABLE flag the system can hang
> when attempting to disable a clock whose parent is disabled. This current
> happens for arm_m4_div on imx8mm-evk, breaking boot.
>
> Fixes: 5fcdb45497a0 ("clk: imx: composite-8m: add
> imx8m_clk_hw_composite_core")
>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
My bad. Thanks for the fix.
Reviewed-by: Peng Fan <peng.fan@nxp.com>
>
> ---
> Since this is a very recent breakage (just next-20200113) the fix should
> probably be squashed.
>
> drivers/clk/imx/clk.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk.h b/drivers/clk/imx/clk.h index
> cd2a60c10a71..17a66a4290fb 100644
> --- a/drivers/clk/imx/clk.h
> +++ b/drivers/clk/imx/clk.h
> @@ -487,11 +487,11 @@ struct clk_hw
> *imx8m_clk_hw_composite_flags(const char *name,
> unsigned long flags);
>
> #define imx8m_clk_hw_composite_core(name, parent_names, reg) \
> imx8m_clk_hw_composite_flags(name, parent_names, \
> ARRAY_SIZE(parent_names), reg, \
> - IMX_COMPOSITE_CORE, 0)
> + IMX_COMPOSITE_CORE, CLK_SET_RATE_NO_REPARENT |
> +CLK_OPS_PARENT_ENABLE)
>
> #define imx8m_clk_composite_flags(name, parent_names, num_parents,
> reg, \
> flags) \
> to_clk(imx8m_clk_hw_composite_flags(name, parent_names, \
> num_parents, reg, 0, flags))
> --
> 2.17.1
prev parent reply other threads:[~2020-01-14 0:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 23:42 [PATCH] clk: imx: Fix imx8m_clk_hw_composite_core flags Leonard Crestez
2020-01-14 0:41 ` Peng Fan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR04MB4481E14B1E82DE106F6D579188340@AM0PR04MB4481.eurprd04.prod.outlook.com \
--to=peng.fan@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=anson.huang@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=m.felsch@pengutronix.de \
--cc=mturquette@baylibre.com \
--cc=ping.bai@nxp.com \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).