From: Rob Herring <robh+dt@kernel.org>
To: Jeffrey Hugo <jhugo@codeaurora.org>
Cc: Stephen Boyd <sboyd@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Marc Gonzalez <marc.w.gonzalez@free.fr>,
Michael Turquette <mturquette@baylibre.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v11 1/4] dt-bindings: clock: Document external clocks for MSM8998 gcc
Date: Tue, 7 Jan 2020 16:14:44 -0600 [thread overview]
Message-ID: <CAL_Jsq+b45XoZ+RnDkuguW+NaPF_fEjzNmHueWT-cQFrX3+2Bg@mail.gmail.com> (raw)
In-Reply-To: <1576595987-10043-1-git-send-email-jhugo@codeaurora.org>
On Tue, Dec 17, 2019 at 9:19 AM Jeffrey Hugo <jhugo@codeaurora.org> wrote:
>
> The global clock controller on MSM8998 can consume a number of external
> clocks. Document them.
>
> For 7180 and 8150, the hardware always exists, so no clocks are truly
> optional. Therefore, simplify the binding by removing the min/max
> qualifiers to clocks. Also, fixup an example so that dt_binding_check
> passes.
>
> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/clock/qcom,gcc.yaml | 73 +++++++++++++++++-----
> 1 file changed, 59 insertions(+), 14 deletions(-)
This breaks 'make dt_binding_check'...
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> index e73a56f..f2b5cd6 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> @@ -40,20 +40,40 @@ properties:
> - qcom,gcc-sm8150
>
> clocks:
> - minItems: 1
> - maxItems: 3
> - items:
> - - description: Board XO source
> - - description: Board active XO source
> - - description: Sleep clock source
> + oneOf:
> + #qcom,gcc-sm8150
> + #qcom,gcc-sc7180
> + - items:
> + - description: Board XO source
> + - description: Board active XO source
> + - description: Sleep clock source
> + #qcom,gcc-msm8998
> + - items:
> + - description: Board XO source
> + - description: Sleep clock source
> + - description: USB 3.0 phy pipe clock
> + - description: UFS phy rx symbol clock for pipe 0
> + - description: UFS phy rx symbol clock for pipe 1
> + - description: UFS phy tx symbol clock
> + - description: PCIE phy pipe clock
>
> clock-names:
> - minItems: 1
> - maxItems: 3
> - items:
> - - const: bi_tcxo
> - - const: bi_tcxo_ao
> - - const: sleep_clk
> + oneOf:
> + #qcom,gcc-sm8150
> + #qcom,gcc-sc7180
> + - items:
> + - const: bi_tcxo
> + - const: bi_tcxo_ao
> + - const: sleep_clk
> + #qcom,gcc-msm8998
> + - items:
> + - const: xo
> + - const: sleep_clk
> + - const: usb3_pipe
> + - const: ufs_rx_symbol0
> + - const: ufs_rx_symbol1
> + - const: ufs_tx_symbol0
> + - const: pcie0_pipe
>
> '#clock-cells':
> const: 1
> @@ -118,6 +138,7 @@ else:
> compatible:
> contains:
> enum:
> + - qcom,gcc-msm8998
> - qcom,gcc-sm8150
> - qcom,gcc-sc7180
> then:
> @@ -179,10 +200,34 @@ examples:
> clock-controller@100000 {
> compatible = "qcom,gcc-sc7180";
> reg = <0x100000 0x1f0000>;
> - clocks = <&rpmhcc 0>, <&rpmhcc 1>;
> - clock-names = "bi_tcxo", "bi_tcxo_ao";
> + clocks = <&rpmhcc 0>, <&rpmhcc 1>, <0>;
> + clock-names = "bi_tcxo", "bi_tcxo_ao", "sleep_clk";
> + #clock-cells = <1>;
> + #reset-cells = <1>;
> + #power-domain-cells = <1>;
> + };
> +
> + # Example of MSM8998 GCC:
> + - |
> + clock-controller@100000 {
> + compatible = "qcom,gcc-msm8998";
> #clock-cells = <1>;
> #reset-cells = <1>;
> #power-domain-cells = <1>;
> + reg = <0x00100000 0xb0000>;
> + clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>,
Probably because of this define.
> + <&sleep>,
> + <0>,
> + <0>,
> + <0>,
> + <0>,
> + <0>;
Why are these all 0?
> + clock-names = "xo",
> + "sleep",
> + "usb3_pipe",
> + "ufs_rx_symbol0",
> + "ufs_rx_symbol1",
> + "ufs_tx_symbol0",
> + "pcie0_pipe";
> };
> ...
> --
> Qualcomm Technologies, Inc. is a member of the
> Code Aurora Forum, a Linux Foundation Collaborative Project.
>
next prev parent reply other threads:[~2020-01-07 22:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 15:19 [PATCH v11 0/4] MSM8998 Multimedia Clock Controller Jeffrey Hugo
2019-12-17 15:19 ` [PATCH v11 1/4] dt-bindings: clock: Document external clocks for MSM8998 gcc Jeffrey Hugo
2019-12-19 5:57 ` Stephen Boyd
2020-01-07 22:14 ` Rob Herring [this message]
2019-12-17 15:20 ` [PATCH v11 2/4] dt-bindings: clock: Convert qcom,mmcc to DT schema Jeffrey Hugo
2019-12-19 5:57 ` Stephen Boyd
2019-12-17 15:20 ` [PATCH v11 3/4] dt-bindings: clock: Add support for the MSM8998 mmcc Jeffrey Hugo
2019-12-19 5:57 ` Stephen Boyd
2019-12-17 15:20 ` [PATCH v11 4/4] clk: qcom: Add MSM8998 Multimedia Clock Controller (MMCC) driver Jeffrey Hugo
2019-12-19 5:57 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_Jsq+b45XoZ+RnDkuguW+NaPF_fEjzNmHueWT-cQFrX3+2Bg@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).