From: <Nicolas.Ferre@microchip.com>
To: <Eugen.Hristev@microchip.com>, <mturquette@baylibre.com>,
<sboyd@kernel.org>, <alexandre.belloni@bootlin.com>,
<linux-clk@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: at91: sam9x60: fix programmable clock
Date: Tue, 24 Sep 2019 11:53:32 +0000 [thread overview]
Message-ID: <a0139a50-9109-77d2-1aff-8c43439e5ec3@microchip.com> (raw)
In-Reply-To: <1569321191-27606-1-git-send-email-eugen.hristev@microchip.com>
On 24/09/2019 at 12:39, Eugen Hristev - M18282 wrote:
> From: Eugen Hristev <eugen.hristev@microchip.com>
>
> The prescaler mask for sam9x60 must be 0xff (8 bits).
> Being set to 0, means that we cannot set any prescaler, thus the
> programmable clocks do not work (except the case with prescaler 0)
> Set the mask accordingly in layout struct.
>
> Fixes: 01e2113de9a5 ("clk: at91: add sam9x60 pmc driver")
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Thanks Eugen. Best regards,
Nicolas
> ---
> drivers/clk/at91/sam9x60.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/at91/sam9x60.c b/drivers/clk/at91/sam9x60.c
> index 9790ddf..86238d5 100644
> --- a/drivers/clk/at91/sam9x60.c
> +++ b/drivers/clk/at91/sam9x60.c
> @@ -43,6 +43,7 @@ static const struct clk_pll_characteristics upll_characteristics = {
> };
>
> static const struct clk_programmable_layout sam9x60_programmable_layout = {
> + .pres_mask = 0xff,
> .pres_shift = 8,
> .css_mask = 0x1f,
> .have_slck_mck = 0,
>
--
Nicolas Ferre
next prev parent reply other threads:[~2019-09-24 11:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 10:39 [PATCH] clk: at91: sam9x60: fix programmable clock Eugen.Hristev
2019-09-24 11:53 ` Nicolas.Ferre [this message]
2019-09-24 12:00 ` Alexandre Belloni
2019-10-03 20:59 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0139a50-9109-77d2-1aff-8c43439e5ec3@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=Eugen.Hristev@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).