From: Marc Gonzalez <marc.w.gonzalez@free.fr>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk <linux-clk@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v1] clk: Add devm_clk_{prepare,enable,prepare_enable}
Date: Mon, 25 Nov 2019 14:50:56 +0100 [thread overview]
Message-ID: <c4d6c458-3cdf-fbfa-5615-5ab4441d3f60@free.fr> (raw)
In-Reply-To: <20190715214647.GY7234@tuxbook-pro>
Doh! Your reply never made it to my inbox, and I never thought to check
the mailing list...
On 15/07/2019 23:46, Bjorn Andersson wrote:
> On Mon 15 Jul 08:34 PDT 2019, Marc Gonzalez wrote:
>
> [..]
>> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
>> index c0990703ce54..5e85548357c0 100644
>> --- a/drivers/clk/clk.c
>> +++ b/drivers/clk/clk.c
>> @@ -914,6 +914,18 @@ int clk_prepare(struct clk *clk)
>> }
>> EXPORT_SYMBOL_GPL(clk_prepare);
>>
>> +static void unprepare(void *clk)
>
> This deserves a less generic name.
Fair enough. Though it's only because of C's function pointer idiosyncrasies
that a function wrapper is even needed.
> clk_enable() is used in code that can't sleep, in what scenario do you
> envision it being useful to enable a clock from such region until devres
> cleans up the associated device?
The use-case I had in mind was
"Device drivers that call
1) clk_prepare_enable from probe()
2) clk_disable_unprepare() in remove()"
(Russell King has pointed out the short-comings of such an approach
in a different sub-thread.)
>> +int devm_clk_prepare(struct device *dev, struct clk *clk);
>> +int devm_clk_enable(struct device *dev, struct clk *clk);
>> +static inline int devm_clk_prepare_enable(struct device *dev, struct clk *clk)
>
> devm_clk_prepare_enable() sounds very useful, devm_clk_prepare() might
> be useful, so keep those and drop devm_clk_enable().
Oooh, I think I understand what you mean...
I saw clk_prepare_enable() defined as clk_prepare() + clk_enable(),
and figured I'd define devm_clk_prepare_enable() as
devm_clk_prepare() + devm_clk_enable() without realizing that
devm_clk_enable() made no sense.
Solution: drop devm_clk_enable() from include/linux/clk.h
Consequence devm_clk_prepare_enable() cannot be static inline,
but that may not be a big deal...
Regards.
next prev parent reply other threads:[~2019-11-25 13:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 15:34 [PATCH v1] clk: Add devm_clk_{prepare,enable,prepare_enable} Marc Gonzalez
2019-07-15 21:46 ` Bjorn Andersson
2019-11-25 13:50 ` Marc Gonzalez [this message]
2019-07-16 0:25 ` Guenter Roeck
2019-07-16 8:18 ` Marc Gonzalez
2019-08-20 8:46 ` Marc Gonzalez
2019-11-25 12:46 ` Marc Gonzalez
2019-11-25 12:51 ` Marc Gonzalez
2019-11-25 12:52 ` Russell King - ARM Linux admin
2019-11-25 13:16 ` Marc Gonzalez
2019-11-25 13:31 ` Russell King - ARM Linux admin
2019-11-25 13:34 ` Marc Gonzalez
2019-11-25 13:38 ` Russell King - ARM Linux admin
2019-11-25 12:55 ` Russell King - ARM Linux admin
2019-11-25 13:10 ` Marc Gonzalez
2019-11-25 13:37 ` Russell King - ARM Linux admin
2019-11-25 14:11 ` Marc Gonzalez
2019-11-25 20:43 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4d6c458-3cdf-fbfa-5615-5ab4441d3f60@free.fr \
--to=marc.w.gonzalez@free.fr \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).