From: Marek Vasut <marex@denx.de>
To: Gatien CHEVALLIER <gatien.chevallier@foss.st.com>,
linux-crypto@vger.kernel.org
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Gabriel Fernandez" <gabriel.fernandez@foss.st.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Olivia Mackall" <olivia@selenic.com>,
"Rob Herring" <robh@kernel.org>,
"Stephen Boyd" <sboyd@kernel.org>,
"Yang Yingliang" <yangyingliang@huawei.com>,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH] [RFC] clk: stm32mp1: Keep RNG1 clock always running
Date: Tue, 14 May 2024 16:37:14 +0200 [thread overview]
Message-ID: <cc6f98eb-f6b2-4a34-a8ed-c0f759fa4c79@denx.de> (raw)
In-Reply-To: <b2d0dfcb-37d6-4375-a4ad-ca96a5339840@foss.st.com>
On 5/14/24 10:10 AM, Gatien CHEVALLIER wrote:
> Hi Marek,
Hi,
> Strange indeed.
Yes.
> A potential reason that comes to my mind would be that something tries
> to get a random number after the driver suspended and fails to do so.
Possibly.
> Else it might just be a bad clock balance.
I don't think so, this would be reported by the kernel and it would show
up in /sys/kernel/debug/clk/clk_summary as incrementing use count. It
would also not happen in a non-deterministic manner like this happens
here, the hang doesn't always happen after well defined suspend/resume
cycle count.
> Can you describe the software ecosystem that you're running please?
> (SCMI/no SCMI)?
STM32MP157C DHCOM PDK2 with mainline U-Boot 2024.07-rc2 , no SCMI.
> Do you have the 3 fixes of stm32_rng.c that you've sent recently in your
> software when testing?
Yes, but this happens even without them.
> What if you add a trace in a random generation function in random.c?
Do you have a function name or line number for me ?
> After this, I'll try to reproduce the issue.
If you have a minute to test it on some ST MP15 board, that would be
real nice. Thanks !
next prev parent reply other threads:[~2024-05-14 15:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 22:02 [PATCH] [RFC] clk: stm32mp1: Keep RNG1 clock always running Marek Vasut
2024-05-14 8:10 ` Gatien CHEVALLIER
2024-05-14 14:37 ` Marek Vasut [this message]
2024-05-15 9:16 ` Gatien CHEVALLIER
2024-05-16 1:06 ` Marek Vasut
2024-05-16 7:42 ` Gatien CHEVALLIER
2024-05-16 10:43 ` Marek Vasut
2024-05-16 14:35 ` Gatien CHEVALLIER
2024-05-16 20:01 ` Marek Vasut
2024-05-17 15:39 ` Gatien CHEVALLIER
2024-05-21 10:27 ` Marek Vasut
2024-05-28 13:55 ` Gatien CHEVALLIER
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc6f98eb-f6b2-4a34-a8ed-c0f759fa4c79@denx.de \
--to=marex@denx.de \
--cc=alexandre.torgue@foss.st.com \
--cc=gabriel.fernandez@foss.st.com \
--cc=gatien.chevallier@foss.st.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mturquette@baylibre.com \
--cc=olivia@selenic.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).