From: Sowjanya Komatineni <skomatineni@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>, <thierry.reding@gmail.com>,
<jonathanh@nvidia.com>, <mperttunen@nvidia.com>,
<sboyd@kernel.org>
Cc: <gregkh@linuxfoundation.org>, <tglx@linutronix.de>,
<robh+dt@kernel.org>, <mark.rutland@arm.com>,
<allison@lohutok.net>, <pdeschrijver@nvidia.com>,
<pgaikwad@nvidia.com>, <mturquette@baylibre.com>,
<horms+renesas@verge.net.au>, <Jisheng.Zhang@synaptics.com>,
<krzk@kernel.org>, <arnd@arndb.de>, <spujar@nvidia.com>,
<josephl@nvidia.com>, <vidyas@nvidia.com>,
<daniel.lezcano@linaro.org>, <mmaddireddy@nvidia.com>,
<markz@nvidia.com>, <devicetree@vger.kernel.org>,
<linux-clk@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 00/11] Move PMC clocks into Tegra PMC driver
Date: Wed, 27 Nov 2019 13:38:27 -0800 [thread overview]
Message-ID: <ebcce0df-bb7a-2f24-cfbc-daaf3ac6bb4f@nvidia.com> (raw)
In-Reply-To: <04b093fe-5eff-1ad2-9a8a-7674dcb2318a@nvidia.com>
On 11/27/19 9:02 AM, Sowjanya Komatineni wrote:
>
> On 11/27/19 6:31 AM, Dmitry Osipenko wrote:
>> 27.11.2019 07:59, Sowjanya Komatineni пишет:
>>> Tegra PMC has clk_out_1, clk_out_2, clk_out_3 and blink controls which
>>> are currently registered by Tegra clock driver using clk_regiser_mux
>>> and
>>> clk_register_gate which performs direct Tegra PMC register access.
>>>
>>> When Tegra PMC is in secure mode, any access from non-secure world will
>>> not go through.
>>>
>>> This patch series adds these Tegra PMC clocks and blink controls to
>>> Tegra
>>> PMC driver with PMC as clock provider and removed them from Tegra clock
>>> driver. This also adds PMC specific clock id's to use in device tree
>>> and
>>> removed clock ids of PMC clock from Tegra clock driver.
>>>
>>> This series also includes patch to update clock provider from tegra_car
>>> to pmc in the device tree tegra210-smaug.dts that uses clk_out_2
>>> from PMC.
>>>
>>> [v2]: Changes between v1 and v2 are
>>> - v2 includes patches for adding clk_out_1, clk_out_2, clk_out_3,
>>> blink controls to Tegra PMC driver and removing clk-tegra-pmc.
>>> - feedback related to pmc clocks in Tegra PMC driver from v1
>>> - Removed patches for WB0 PLLM overrides and PLLE IDDQ PMC
>>> programming
>>> by the clock driver using helper functions from Tegra PMC.
>>>
>>> Note:
>>> To use helper functions from PMC driver, PMC early init need to
>>> happen prior to using helper functions and these helper
>>> functions are
>>> for PLLM Override and PLLE IDDQ programming in PMC during
>>> PLLM/PLLE
>>> clock registration which happen in clock_init prior to Tegra PMC
>>> probe.
>>> Moving PLLM/PLLE clocks registration to happen after Tegra PMC
>>> impacts other clocks EMC, MC and corresponding tegra_emc_init and
>>> tegra_mc_init.
>>> This implementation of configuring PMC registers thru helper
>>> functions in clock driver needs proper changes across PMC, Clock,
>>> EMC and MC inits to have it work across all Tegra platforms.
>>>
>>> Currently PLLM Override is not enabled in the bootloader so
>>> proper
>>> patches for this fix will be taken care separately.
>> Hello Sowjanya,
>>
>> Could you please clarify what do you mean by "PLLM Override not enabled
>> in bootloader"?
>>
>> There is T124 Nyan Big Chromebook which is supported in upstream kernel,
>> it has PLLM Override set by bootloader. I also have T30 Nexus 7 tablet
>> which has the PLLM Override set by bootloader as well. It's not clear to
>> me whether this patch series is supposed to break these devices. If the
>> breakage is the case here, then I'm afraid you can't postpone supporting
>> the PLLM Override and a full-featured implementation is needed.
>
> Hi Dmitry,
>
> Secure boot currently is enabled only on Tegra210 and Tegra210
> bootloader doesn't enable PLLM override.
>
> So PLLM override/PLLE IDDQ being in clock driver currently will not
> break on any of existing Tegra platforms.
>
>>
>> I briefly tried to test this series on T30 and this time it doesn't hang
>> on boot, but somehow WiFi MMC card detection is broken. AFAIK, the WiFi
>> chip uses the Blink clock source and the clock should be enabled by the
>> MMC core because this is how DT part looks like:
>>
>> brcm_wifi_pwrseq: wifi-pwrseq {
>> compatible = "mmc-pwrseq-simple";
>> clocks = <&pmc TEGRA_PMC_CLK_BLINK>;
>> clock-names = "ext_clock";
>> reset-gpios = <&gpio TEGRA_GPIO(D, 3) GPIO_ACTIVE_LOW>;
>> post-power-on-delay-ms = <300>;
>> power-off-delay-us = <300>;
>> };
>>
>> BTW, I tried this series on a T20 device which also uses the Blink
>> clock for WiFi card and it works. So looks like this patchset has some
>> problem in regards to the T30 PMC clocks implementation.
>>
>> [snip]
>
> Blink init state is set to true for both Tegra20 and Tegra30 and all
> go through the same blink programming sequence.
>
> Will try to add more debug messages to dump registers and will test
> blink through device tree on T30 and will get back...
>
>
define value for BLINK uses BIT macro instead of just position. Will fix
this in v3.
next prev parent reply other threads:[~2019-11-27 21:38 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 4:59 [PATCH v2 00/11] Move PMC clocks into Tegra PMC driver Sowjanya Komatineni
2019-11-27 4:59 ` [PATCH v2 01/11] dt-bindings: soc: tegra-pmc: Add Tegra PMC clock ids Sowjanya Komatineni
2019-11-27 4:59 ` [PATCH v2 02/11] soc: tegra: Add Tegra PMC clock registrations into PMC driver Sowjanya Komatineni
2019-11-27 14:32 ` Dmitry Osipenko
2019-11-27 14:32 ` Dmitry Osipenko
2019-11-27 15:14 ` Dmitry Osipenko
2019-11-27 22:57 ` Sowjanya Komatineni
2019-11-28 13:25 ` Dmitry Osipenko
2019-12-02 20:09 ` Sowjanya Komatineni
2019-12-02 21:50 ` Dmitry Osipenko
2019-12-02 22:58 ` Sowjanya Komatineni
2019-12-02 23:10 ` Sowjanya Komatineni
2019-12-02 23:14 ` Sowjanya Komatineni
2019-12-03 0:07 ` Sowjanya Komatineni
2019-12-03 16:45 ` Sowjanya Komatineni
2019-12-04 13:39 ` Dmitry Osipenko
2019-12-04 16:02 ` Sowjanya Komatineni
2019-12-04 20:08 ` Sowjanya Komatineni
2019-12-04 20:28 ` Dmitry Osipenko
2019-12-04 20:33 ` Sowjanya Komatineni
2019-12-04 21:12 ` Dmitry Osipenko
2019-12-04 21:26 ` Sowjanya Komatineni
2019-11-27 4:59 ` [PATCH v2 03/11] dt-bindings: soc: tegra-pmc: Add id for Tegra PMC blink control Sowjanya Komatineni
2019-11-27 4:59 ` [PATCH v2 04/11] soc: pmc: Add blink output clock registration to Tegra PMC Sowjanya Komatineni
2019-11-28 13:07 ` Dmitry Osipenko
2019-11-27 4:59 ` [PATCH v2 05/11] clk: tegra: Remove tegra_pmc_clk_init along with clk ids Sowjanya Komatineni
2019-11-27 4:59 ` [PATCH v2 06/11] dt-bindings: clock: tegra: Remove pmc clock ids from clock dt-bindings Sowjanya Komatineni
2019-11-27 14:32 ` Dmitry Osipenko
2019-11-27 17:06 ` Sowjanya Komatineni
2019-11-28 12:18 ` Thierry Reding
2019-11-28 13:07 ` Dmitry Osipenko
2019-11-27 4:59 ` [PATCH v2 07/11] arm: tegra: Add clock-cells property to Tegra PMC Sowjanya Komatineni
2019-11-27 4:59 ` [PATCH v2 08/11] arm64: tegra: Add clock-cells property to Tegra pmc Sowjanya Komatineni
2019-11-27 4:59 ` [PATCH v2 09/11] dt-bindings: Add Tegra PMC clock configuration bindings Sowjanya Komatineni
2019-11-27 4:59 ` [PATCH v2 10/11] arm64: tegra: smaug: Change clk_out_2 provider from tegra_car to pmc Sowjanya Komatineni
2019-11-27 4:59 ` [PATCH v2 11/11] ASoC: nau8825: change Tegra " Sowjanya Komatineni
2019-11-27 14:31 ` [PATCH v2 00/11] Move PMC clocks into Tegra PMC driver Dmitry Osipenko
2019-11-27 17:02 ` Sowjanya Komatineni
2019-11-27 21:38 ` Sowjanya Komatineni [this message]
2019-11-28 13:06 ` Dmitry Osipenko
2019-12-02 17:09 ` Dmitry Osipenko
2019-12-02 18:47 ` Sowjanya Komatineni
2019-11-28 12:26 ` Thierry Reding
2019-11-28 13:10 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebcce0df-bb7a-2f24-cfbc-daaf3ac6bb4f@nvidia.com \
--to=skomatineni@nvidia.com \
--cc=Jisheng.Zhang@synaptics.com \
--cc=allison@lohutok.net \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=horms+renesas@verge.net.au \
--cc=jonathanh@nvidia.com \
--cc=josephl@nvidia.com \
--cc=krzk@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=markz@nvidia.com \
--cc=mmaddireddy@nvidia.com \
--cc=mperttunen@nvidia.com \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=spujar@nvidia.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).