From: "Семен Верченко" <semverchenko@factor-ts.ru>
To: Hans de Goede <hdegoede@redhat.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "David Müller" <dave.mueller@gmx.ch>,
"Fujinaka, Todd" <todd.fujinaka@intel.com>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"e1000-devel@lists.sf.net" <e1000-devel@lists.sf.net>,
"Stephen Boyd" <sboyd@kernel.org>,
linux-clk@vger.kernel.org,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@codeaurora.org>
Subject: Re: [E1000-devel] igb driver with Intel Atom Bay Trail issue
Date: Fri, 29 Mar 2019 16:59:17 +0300 [thread overview]
Message-ID: <ef893b2e-121a-d395-9843-47d0c9f1515a@factor-ts.ru> (raw)
In-Reply-To: <d4c44bc8-ae0c-a6ff-3042-ae3185ceb33e@redhat.com>
On 29.03.2019 15:30, Hans de Goede wrote:
> Hi,
>
> On 3/28/19 4:49 PM, Andy Shevchenko wrote:
>> On Thu, Mar 28, 2019 at 04:32:27PM +0100, Hans de Goede wrote:
>>> On 28-03-19 16:24, Andy Shevchenko wrote:
>>>> On Thu, Mar 28, 2019 at 04:01:37PM +0100, Hans de Goede wrote:
>>>>> On 28-03-19 15:58, Andy Shevchenko wrote:
>>>>>> On Thu, Mar 28, 2019 at 03:35:58PM +0100, David Müller wrote:
>>>>>>> Andy Shevchenko wrote:
>>>>>>>> On Wed, Mar 27, 2019 at 06:31:19PM +0100, David Müller wrote:
>>
>>>>>>>> Any driver for device which is using PMC clock should take it into
>>>>>>>> consideration.
>>>>>>>
>>>>>>> I agree that each driver should properly request the clocks and
>>>>>>> other
>>>>>>> resources needed.
>>
>>>>>> Can you elaborate a bit more the case you are talking about?
>>
>>>>> I think the board with igb ethernet controllers might
>>>>> just as well be handled the same way (I already checked it has usable
>>>>> DMI identifying info).
>>>>
>>>> But am I right that in the case of igb we will loose power at
>>>> suspend? Wouldn't
>>>> be better to patch the driver?
>>>
>>> This is an industrial embedded PC, so it is not running on battery and
>>> I doubt it typically spends a lot of time in suspend at all.
>>
>> Okay, but still from logical point of view wouldn't be better to fix
>> the driver
>> for such case? At least I see benefits out of this approach: a) less
>> hackish,
>> less quirk code; b) if this happens on non-industrial case it would
>> be better
>> to have in the driver due to power consumption.
>
> Maybe, I guess we first need to figure out which platforms clock(s) is
> (are)
> being used, if there is more then one; or it is a different one then
> in the
> realtek ethernet case it might be better to go with the dmi quirk option.
>
> Semyon Verchenko can you (as root) run the following command on a kernel
> where the ethernet does work:
>
> grep . /sys/kernel/debug/clk/pmc_plt_clk_?/flags
>
> And then email us the output please?
>
> Regards,
>
> Hans
>
I don't have flags files in /sys/kernel/debug/clk/pmc_plt_clk_?; did you
mean clk_flags?
[root@archatom ~]# grep . /sys/kernel/debug/clk/pmc_plt_clk_?/flags
grep: /sys/kernel/debug/clk/pmc_plt_clk_?/flags: No such file or directory
[root@archatom ~]# grep . /sys/kernel/debug/clk/pmc_plt_clk_?/clk_flags
/sys/kernel/debug/clk/pmc_plt_clk_0/clk_flags:CLK_IS_CRITICAL
/sys/kernel/debug/clk/pmc_plt_clk_1/clk_flags:CLK_IS_CRITICAL
/sys/kernel/debug/clk/pmc_plt_clk_2/clk_flags:CLK_IS_CRITICAL
/sys/kernel/debug/clk/pmc_plt_clk_3/clk_flags:CLK_IS_CRITICAL
[root@archatom ~]# ls /sys/kernel/debug/clk
clk_dump clk_orphan_summary pll pmc_plt_clk_1
pmc_plt_clk_3 pmc_plt_clk_5
clk_orphan_dump clk_summary pmc_plt_clk_0 pmc_plt_clk_2
pmc_plt_clk_4 xtal
Kernel is 5.0.4 with commit 648e921888ad ("clk: x86: Stop marking clocks
as CLK_IS_CRITICAL") reversed, is it enough or I need to install older
kernel?
next prev parent reply other threads:[~2019-03-29 14:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1c433bef-055e-2ac3-990c-325aa2d3899e@factor-ts.ru>
[not found] ` <9B4A1B1917080E46B64F07F2989DADD69AF4DDE7@ORSMSX115.amr.corp.intel.com>
2019-03-27 16:02 ` [E1000-devel] igb driver with Intel Atom Bay Trail issue Hans de Goede
2019-03-27 16:47 ` Andy Shevchenko
2019-03-27 17:31 ` David Müller
2019-03-27 19:19 ` Andy Shevchenko
2019-03-28 14:35 ` David Müller
2019-03-28 14:58 ` Andy Shevchenko
2019-03-28 15:01 ` Hans de Goede
2019-03-28 15:24 ` Andy Shevchenko
2019-03-28 15:32 ` Hans de Goede
2019-03-28 15:49 ` Andy Shevchenko
2019-03-29 4:46 ` Hisashi T Fujinaka
2019-03-29 12:32 ` Hans de Goede
2019-03-29 12:30 ` Hans de Goede
2019-03-29 13:59 ` Семен Верченко [this message]
2019-03-29 15:53 ` Hans de Goede
2019-04-04 14:43 ` Hans de Goede
[not found] ` <20190408172111.GX9224@smile.fi.intel.com>
2019-04-08 18:43 ` Hans de Goede
2019-04-09 15:31 ` Andy Shevchenko
2019-04-18 13:09 ` Hans de Goede
2019-04-18 13:26 ` Semyon Verchenko
2019-04-18 15:12 ` Hans de Goede
2019-04-22 10:20 ` Semyon Verchenko
2019-04-29 15:02 ` Hans de Goede
2019-03-28 14:48 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef893b2e-121a-d395-9843-47d0c9f1515a@factor-ts.ru \
--to=semverchenko@factor-ts.ru \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dave.mueller@gmx.ch \
--cc=e1000-devel@lists.sf.net \
--cc=hdegoede@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=todd.fujinaka@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).