From: Chanwoo Choi <cw00.choi@samsung.com>
To: Kamil Konieczny <k.konieczny@partner.samsung.com>,
linux-samsung-soc@vger.kernel.org
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Kukjin Kim <kgene@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v5 4/5] dt-bindings: clk: exynos5433: add imem clock
Date: Thu, 31 Jan 2019 21:30:58 +0900 [thread overview]
Message-ID: <fd39fd40-f452-f763-c9ab-d717c80967cd@samsung.com> (raw)
In-Reply-To: <20190122090232.29194-5-k.konieczny@partner.samsung.com>
Hi,
On 19. 1. 22. 오후 6:02, Kamil Konieczny wrote:
> Add Exynos5433 DT bindings to describe imem clocks for SlimSSS (Slim
> Security SubSystem).
>
> Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com>
> ---
> include/dt-bindings/clock/exynos5433.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/dt-bindings/clock/exynos5433.h b/include/dt-bindings/clock/exynos5433.h
> index 87bb2b017143..52652aaabc06 100644
> --- a/include/dt-bindings/clock/exynos5433.h
> +++ b/include/dt-bindings/clock/exynos5433.h
> @@ -1406,4 +1406,10 @@
>
> #define CAM1_NR_CLK 113
>
> +/* CMU_IMEM */
> +#define CLK_ACLK_SLIMSSS 2
> +#define CLK_PCLK_SLIMSSS 35
> +
> +#define IMEM_NR_CLK 52
> +
> #endif /* _DT_BINDINGS_CLOCK_EXYNOS5433_H */
>
If you define that IMEM_NR_CLK is 52, clock driver allocates
the memory for 52 clocks. It cause the memory waste.
IMO, you better to change it as following:
#define CLK_ACLK_SLIMSSS 1
#define CLK_PCLK_SLIMSSS 2
#define IMEM_NR_CLK 3
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2019-01-31 12:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190122090249eucas1p1e464ab92e8d5a706981f8dbcb63b1500@eucas1p1.samsung.com>
2019-01-22 9:02 ` [PATCH v5 0/5] Add imem clock for Exynos 5433 Kamil Konieczny
[not found] ` <CGME20190122090249eucas1p161cfc1364fb8ee76d2d04383935e8f3b@eucas1p1.samsung.com>
2019-01-22 9:02 ` [PATCH v5 1/5] clk: samsung: exynos5433: fix typo in imem divider Kamil Konieczny
2019-01-22 9:33 ` Greg KH
2019-01-25 12:41 ` Kamil Konieczny
[not found] ` <CGME20190122090250eucas1p246a6a567d77d075716fc9f257f72a26e@eucas1p2.samsung.com>
2019-01-22 9:02 ` [PATCH v5 2/5] clk: samsung: exynos5433: fix name typo in sssx Kamil Konieczny
[not found] ` <CGME20190122090251eucas1p2db2f383c0b8b4034f66b6a82b0a22d67@eucas1p2.samsung.com>
2019-01-22 9:02 ` [PATCH v5 3/5] dt-bindings: clk: exynos5433: document imem clock Kamil Konieczny
[not found] ` <CGME20190122090251eucas1p122f1c6d47f3cb60febeadda88ada3a76@eucas1p1.samsung.com>
2019-01-22 9:02 ` [PATCH v5 4/5] dt-bindings: clk: exynos5433: add " Kamil Konieczny
2019-01-30 15:46 ` Rob Herring
2019-01-31 12:30 ` Chanwoo Choi [this message]
2019-02-01 10:57 ` Sylwester Nawrocki
2019-02-01 13:30 ` [PATCH v5 0/5] Add imem clock for Exynos 5433 Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd39fd40-f452-f763-c9ab-d717c80967cd@samsung.com \
--to=cw00.choi@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=k.konieczny@partner.samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).