From: Herbert Xu <herbert@gondor.apana.org.au>
To: Harald Freudenberger <freude@linux.vnet.ibm.com>
Cc: linux-crypto@vger.kernel.org, schwidefsky@de.ibm.com
Subject: Re: crypto: hang in crypto_larval_lookup
Date: Thu, 23 Feb 2017 19:19:57 +0800 [thread overview]
Message-ID: <20170223111957.GA14000@gondor.apana.org.au> (raw)
In-Reply-To: <02b80c39-0fd5-b7bd-39da-07e5d71abbad@linux.vnet.ibm.com>
Harald Freudenberger <freude@linux.vnet.ibm.com> wrote:
>
> Hello all
>
> I am currently following a hang at modprobe aes_s390 where
> crypto_register_alg() does not come back for the xts(aes) algorithm.
>
> The registration is waiting forever in algapi.c crypto_wait_for_test() but
> the completion never occurs. The cryptomgr is triggering a test via
> kthread_run to invoce cryptomgr_probe and this thread is calling the
> create() function of the xts template (file xts.c). Following this thread
> it comes down to api.c crypto_larval_lookup(name="aes") which is first
> requesting the module "crypto-aes" via request_module() successful and then
> blocking forever in requesting the module "crypto-aes-all".
>
> The xts(aes) has at registration CRYPTO_ALG_NEED_FALLBACK flag on.
>
> This problem is seen since about 6 weeks now, first only on the linux next
> kernel. Now it appers on the 4.10-rc kernels as well. And I still have no
> idea on how this could be fixed or what's wrong with just the xts
> registration (ecb, cbc, ctr work fine).
>
> Any ideas or hints?
Sorry, my fault. I should've converted all the fallback users of
the old blkcipher interface over to skcipher before converting the
core algorithms to skcipher.
I'll send a patch.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2017-02-23 11:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 17:50 crypto: hang in crypto_larval_lookup Harald Freudenberger
2017-02-23 11:19 ` Herbert Xu [this message]
2017-02-23 11:39 ` Herbert Xu
2017-02-23 16:02 ` Harald Freudenberger
2017-02-24 8:42 ` Harald Freudenberger
2017-02-24 10:32 ` Harald Freudenberger
2017-02-24 11:21 ` Harald Freudenberger
2017-02-24 23:44 ` Marcelo Cerri
2017-02-25 15:17 ` Herbert Xu
2017-02-25 19:20 ` Marcelo Cerri
2017-02-26 4:22 ` Herbert Xu
2017-02-26 4:24 ` [v2 PATCH] crypto: xts - Propagate NEED_FALLBACK bit Herbert Xu
2017-02-26 19:14 ` crypto: hang in crypto_larval_lookup Harald Freudenberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170223111957.GA14000@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=freude@linux.vnet.ibm.com \
--cc=linux-crypto@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).