From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Horia Geantă" <horia.geanta@nxp.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Aymen Sghaier <aymen.sghaier@nxp.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Wen Yang <yellowriver2010@hotmail.com>
Subject: Re: [PATCH RESEND v3] crypto: caam - add missing put_device() call
Date: Thu, 7 Mar 2019 16:26:09 +0800 [thread overview]
Message-ID: <20190307082609.fj3thwpg5ggoxmn7@gondor.apana.org.au> (raw)
In-Reply-To: <20190301171925.22650-1-horia.geanta@nxp.com>
On Fri, Mar 01, 2019 at 07:19:25PM +0200, Horia Geantă wrote:
> From: Wen Yang <yellowriver2010@hotmail.com>
>
> The of_find_device_by_node() takes a reference to the underlying device
> structure, we should release that reference.
>
> Fixes: 35af64038623 ("crypto: caam - Check for CAAM block presence before registering with crypto layer")
> Fixes: b189817cf789 ("crypto: caam/qi - add ablkcipher and authenc algorithms")
> Reviewed-by: Horia Geantă <horia.geanta@nxp.com>
> Signed-off-by: Wen Yang <yellowriver2010@hotmail.com>
> ---
>
> Looks like previous versions, for some unknown reason, did not reach
> the mailing lists.
>
> Resending v3 with the addition of a 2nd Fixes and Reviewed-by tags,
> cf. https://lkml.org/lkml/2019/2/11/383
>
> drivers/crypto/caam/caamalg.c | 12 +++++++-----
> drivers/crypto/caam/caamalg_qi.c | 11 ++++++++---
> drivers/crypto/caam/caamhash.c | 18 +++++++++++-------
> drivers/crypto/caam/caampkc.c | 14 ++++++++++----
> drivers/crypto/caam/caamrng.c | 22 ++++++++++++++--------
> 5 files changed, 50 insertions(+), 27 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2019-03-07 8:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 17:19 [PATCH RESEND v3] crypto: caam - add missing put_device() call Horia Geantă
2019-03-07 8:26 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307082609.fj3thwpg5ggoxmn7@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=aymen.sghaier@nxp.com \
--cc=davem@davemloft.net \
--cc=horia.geanta@nxp.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yellowriver2010@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).