From: Herbert Xu <herbert@gondor.apana.org.au>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: testmgr - make extra tests depend on cryptomgr
Date: Thu, 30 May 2019 21:41:12 +0800 [thread overview]
Message-ID: <20190530134112.d7xzk3kmcvgrgfrp@gondor.apana.org.au> (raw)
In-Reply-To: <20190520164829.167433-1-ebiggers@kernel.org>
On Mon, May 20, 2019 at 09:48:29AM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> The crypto self-tests are part of the "cryptomgr" module, which can
> technically be disabled (though it rarely is). If you do so, currently
> you can still enable CRYPTO_MANAGER_EXTRA_TESTS, which doesn't make
> sense since in that case testmgr.c isn't compiled at all. Fix it by
> making it CRYPTO_MANAGER_EXTRA_TESTS depend on CRYPTO_MANAGER2, like
> CRYPTO_MANAGER_DISABLE_TESTS already does.
>
> Fixes: 5b2706a4d459 ("crypto: testmgr - introduce CONFIG_CRYPTO_MANAGER_EXTRA_TESTS")
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> crypto/Kconfig | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2019-05-30 13:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 16:48 [PATCH] crypto: testmgr - make extra tests depend on cryptomgr Eric Biggers
2019-05-30 13:41 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190530134112.d7xzk3kmcvgrgfrp@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).