From: Herbert Xu <herbert@gondor.apana.org.au>
To: Iuliana Prodan <iuliana.prodan@nxp.com>
Cc: Horia Geanta <horia.geanta@nxp.com>,
Aymen Sghaier <aymen.sghaier@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH v5 00/14] crypto: caam - fixes for kernel v5.3
Date: Fri, 9 Aug 2019 16:19:01 +1000 [thread overview]
Message-ID: <20190809061901.GL10392@gondor.apana.org.au> (raw)
In-Reply-To: <1564578495-9883-1-git-send-email-iuliana.prodan@nxp.com>
On Wed, Jul 31, 2019 at 04:08:01PM +0300, Iuliana Prodan wrote:
> The series solves:
> - the failures found with fuzz testing;
> - resources clean-up on caampkc/caamrng exit path.
>
> The first 10 patches solve the issues found with
> CONFIG_CRYPTO_MANAGER_EXTRA_TESTS enabled.
> They modify the drivers to provide a valid error (and not the hardware
> error ID) to the user, via completion callbacks.
> They check key length, assoclen, authsize and input size to solve the
> fuzz tests that expect -EINVAL to be returned when these values are
> not valid.
>
> The next 4 patches check the algorithm registration for caampkc
> module and unregister it only if the registration was successful.
> Also, on caampkc/caamrng, the exit point function is executed only if the
> registration was successful to avoid double freeing of resources in case
> the initialization function failed.
>
> This patch depends on series:
> https://patchwork.kernel.org/project/linux-crypto/list/?series=153441
>
> Changes since v4:
> - use, newly renamed, helper aes function, to validate keylen.
>
> Horia Geantă (5):
> crypto: caam/qi - fix error handling in ERN handler
> crypto: caam - fix return code in completion callbacks
> crypto: caam - update IV only when crypto operation succeeds
> crypto: caam - keep both virtual and dma key addresses
> crypto: caam - fix MDHA key derivation for certain user key lengths
>
> Iuliana Prodan (9):
> crypto: caam - check key length
> crypto: caam - check authsize
> crypto: caam - check assoclen
> crypto: caam - check zero-length input
> crypto: caam - update rfc4106 sh desc to support zero length input
> crypto: caam - free resources in case caam_rng registration failed
> crypto: caam - execute module exit point only if necessary
> crypto: caam - unregister algorithm only if the registration succeeded
> crypto: caam - change return value in case CAAM has no MDHA
>
> drivers/crypto/caam/Kconfig | 2 +
> drivers/crypto/caam/caamalg.c | 227 +++++++++++++++----------
> drivers/crypto/caam/caamalg_desc.c | 47 ++++--
> drivers/crypto/caam/caamalg_desc.h | 2 +-
> drivers/crypto/caam/caamalg_qi.c | 225 +++++++++++++++----------
> drivers/crypto/caam/caamalg_qi2.c | 320 +++++++++++++++++++++++-------------
> drivers/crypto/caam/caamhash.c | 114 ++++++++-----
> drivers/crypto/caam/caamhash_desc.c | 5 +-
> drivers/crypto/caam/caamhash_desc.h | 2 +-
> drivers/crypto/caam/caampkc.c | 80 ++++++---
> drivers/crypto/caam/caamrng.c | 17 +-
> drivers/crypto/caam/desc_constr.h | 34 ++--
> drivers/crypto/caam/error.c | 61 ++++---
> drivers/crypto/caam/error.h | 2 +-
> drivers/crypto/caam/key_gen.c | 14 +-
> drivers/crypto/caam/qi.c | 10 +-
> drivers/crypto/caam/regs.h | 1 +
> 17 files changed, 748 insertions(+), 415 deletions(-)
All applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2019-08-09 6:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 13:08 [PATCH v5 00/14] crypto: caam - fixes for kernel v5.3 Iuliana Prodan
2019-07-31 13:08 ` [PATCH v5 01/14] crypto: caam/qi - fix error handling in ERN handler Iuliana Prodan
2019-07-31 13:08 ` [PATCH v5 02/14] crypto: caam - fix return code in completion callbacks Iuliana Prodan
2019-07-31 13:08 ` [PATCH v5 03/14] crypto: caam - update IV only when crypto operation succeeds Iuliana Prodan
2019-07-31 13:08 ` [PATCH v5 04/14] crypto: caam - check key length Iuliana Prodan
2019-07-31 13:08 ` [PATCH v5 05/14] crypto: caam - check authsize Iuliana Prodan
2019-07-31 13:08 ` [PATCH v5 06/14] crypto: caam - check assoclen Iuliana Prodan
2019-07-31 13:08 ` [PATCH v5 07/14] crypto: caam - check zero-length input Iuliana Prodan
2019-07-31 13:08 ` [PATCH v5 08/14] crypto: caam - update rfc4106 sh desc to support zero length input Iuliana Prodan
2019-07-31 13:08 ` [PATCH v5 09/14] crypto: caam - keep both virtual and dma key addresses Iuliana Prodan
2019-07-31 13:08 ` [PATCH v5 10/14] crypto: caam - fix MDHA key derivation for certain user key lengths Iuliana Prodan
2019-07-31 13:08 ` [PATCH v5 11/14] crypto: caam - free resources in case caam_rng registration failed Iuliana Prodan
2019-07-31 13:08 ` [PATCH v5 12/14] crypto: caam - execute module exit point only if necessary Iuliana Prodan
2019-07-31 13:08 ` [PATCH v5 13/14] crypto: caam - unregister algorithm only if the registration succeeded Iuliana Prodan
2019-07-31 13:08 ` [PATCH v5 14/14] crypto: caam - change return value in case CAAM has no MDHA Iuliana Prodan
2019-08-09 6:19 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809061901.GL10392@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=aymen.sghaier@nxp.com \
--cc=davem@davemloft.net \
--cc=horia.geanta@nxp.com \
--cc=iuliana.prodan@nxp.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).