From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89003C4360C for ; Wed, 16 Oct 2019 08:01:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 65FB22082C for ; Wed, 16 Oct 2019 08:01:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390578AbfJPIBN (ORCPT ); Wed, 16 Oct 2019 04:01:13 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:14366 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730874AbfJPIBN (ORCPT ); Wed, 16 Oct 2019 04:01:13 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x9G7gMtl001121 for ; Wed, 16 Oct 2019 04:01:11 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0b-001b2d01.pphosted.com with ESMTP id 2vnvpy5a1q-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 16 Oct 2019 04:01:11 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 16 Oct 2019 09:01:09 +0100 Received: from b06avi18878370.portsmouth.uk.ibm.com (9.149.26.194) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 16 Oct 2019 09:01:06 +0100 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x9G814l543516312 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 16 Oct 2019 08:01:04 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BB37DA4064; Wed, 16 Oct 2019 08:01:04 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 82BA4A4065; Wed, 16 Oct 2019 08:01:04 +0000 (GMT) Received: from osiris (unknown [9.152.212.85]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Wed, 16 Oct 2019 08:01:04 +0000 (GMT) Date: Wed, 16 Oct 2019 10:01:03 +0200 From: Heiko Carstens To: Eric Biggers , Herbert Xu Cc: linux-crypto@vger.kernel.org, linux-s390@vger.kernel.org, Vasily Gorbik , Christian Borntraeger , Harald Freudenberger Subject: Re: [RFT PATCH 0/3] crypto: s390 - convert to skcipher API References: <20191012201809.160500-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191012201809.160500-1-ebiggers@kernel.org> X-TM-AS-GCONF: 00 x-cbid: 19101608-0020-0000-0000-000003797DB9 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19101608-0021-0000-0000-000021CF9FF0 Message-Id: <20191016080103.GA4267@osiris> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-10-16_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910160072 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sat, Oct 12, 2019 at 01:18:06PM -0700, Eric Biggers wrote: > This series converts the glue code for the S390 CPACF implementations of > AES, DES, and 3DES modes from the deprecated "blkcipher" API to the > "skcipher" API. This is needed in order for the blkcipher API to be > removed. > > I've compiled this patchset, and the conversion is very similar to that > which has been done for many other crypto drivers. But I don't have the > hardware to test it, nor is S390 CPACF supported by QEMU. So I really > need someone with the hardware to test it. You can do so by setting: ... > Eric Biggers (3): > crypto: s390/aes - convert to skcipher API > crypto: s390/paes - convert to skcipher API > crypto: s390/des - convert to skcipher API > > arch/s390/crypto/aes_s390.c | 609 ++++++++++++++--------------------- > arch/s390/crypto/des_s390.c | 419 ++++++++++-------------- > arch/s390/crypto/paes_s390.c | 414 ++++++++++-------------- > 3 files changed, 580 insertions(+), 862 deletions(-) Herbert, should these go upstream via the s390 or crypto tree?